Author: Felipe de Azevedo Piovezan Date: 2025-04-14T16:21:24-07:00 New Revision: 7491ff74d2b99c0e5e879ec7fd370fe9654528c4
URL: https://github.com/llvm/llvm-project/commit/7491ff74d2b99c0e5e879ec7fd370fe9654528c4 DIFF: https://github.com/llvm/llvm-project/commit/7491ff74d2b99c0e5e879ec7fd370fe9654528c4.diff LOG: [lldb] Override Should{Select,Show} in StopReasonBreakpoint (#135637) This is necessary so that LLDB does not select (or show the stop reason for) a thread which stopped at an internal breakpoint. Other than manual testing/inspection, which I've done, this does not seem to lend itself to API testing, as we cannot set internal breakpoints through the SBAPI. Added: Modified: lldb/source/Target/StopInfo.cpp Removed: ################################################################################ diff --git a/lldb/source/Target/StopInfo.cpp b/lldb/source/Target/StopInfo.cpp index f1272a723a8cb..3160446ae1d17 100644 --- a/lldb/source/Target/StopInfo.cpp +++ b/lldb/source/Target/StopInfo.cpp @@ -263,6 +263,10 @@ class StopInfoBreakpoint : public StopInfo { return bp_site_sp->GetSuggestedStackFrameIndex(); } + bool ShouldShow() const override { return !m_was_all_internal; } + + bool ShouldSelect() const override { return !m_was_all_internal; } + protected: bool ShouldStop(Event *event_ptr) override { // This just reports the work done by PerformAction or the synchronous _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
