https://github.com/ashgti approved this pull request.
Looks great!
https://github.com/llvm/llvm-project/pull/129332
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,38 @@
+import { ChildProcessWithoutNullStreams, spawn } from "child_process";
+import { BaseProcessTree, ProcessTreeParser } from "../base-process-tree";
+
+export class LinuxProcessTree extends BaseProcessTree {
+ protected override spawnProcess(): ChildProcessWithout
ajordanr-google wrote:
/cherry-pick 8d017e6c0178f2628b246c18b2a634909815e54f
eec242aa97c8d153574923f8237754ca3fa6f0a6
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
llvmbot wrote:
>/cherry-pick 8d017e6c0178f2628b246c18b2a634909815e54f
>eec242aa97c8d153574923f8237754ca3fa6f0a6
Error: Command failed due to missing milestone.
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commi
Author: Felipe de Azevedo Piovezan
Date: 2025-02-28T16:13:12-08:00
New Revision: 11b9466c04db4da7439fc1d9d8ba7241a9d68705
URL:
https://github.com/llvm/llvm-project/commit/11b9466c04db4da7439fc1d9d8ba7241a9d68705
DIFF:
https://github.com/llvm/llvm-project/commit/11b9466c04db4da7439fc1d9d8ba7241a
ajordanr-google wrote:
/cherry-pick 8fff0c181f26a5e8b2344c061ebf2559118b1160
bb6a273d9ab9ee90dbb957e541f4d810fffb22ee
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/129340
We didn't also copy over the next stop hook id, which meant we would overwrite
the stop hooks from the dummy target with stop hooks set after they are copied
over.
>From 02e908312518e85f1d637529c9f62e3dd9551
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
We didn't also copy over the next stop hook id, which meant we would overwrite
the stop hooks from the dummy target with stop hooks set after they are copied
over.
---
Full diff: https://github.com/llvm/llvm-proje
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/129307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
273fca94d4c4896df15f967a1388b7c533b76062...02e908312518e85f1d637529c9f62e3dd9551035
lldb/
llvmbot wrote:
/pull-request llvm/llvm-project#129342
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/129275
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/129340
>From 02e908312518e85f1d637529c9f62e3dd9551035 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Fri, 28 Feb 2025 15:55:03 -0800
Subject: [PATCH 1/2] Fix a bug copying the stop hooks from the dummy target.
We d
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/129262
>From b40c3e7e4ebb154c5f231676451acbd17e1f39f7 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Fri, 28 Feb 2025 11:08:25 -0500
Subject: [PATCH 1/2] allow providing debug adapter arguments
---
lldb/
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/129307
I recently received an internal error report that LLDB was OOM'ing when
creating a Minidump. In my 64b refactor we made a decision to acquire buffers
the size of the largest memory region so we could read all o
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 1/5] add a process picker for attaching by PID
---
lld
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/129294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,22 @@
+#include "DAPLog.h"
JDevlieghere wrote:
Missing copyright header
https://github.com/llvm/llvm-project/pull/129294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/129294
>From 8d466e5c4b1b6913e788fd11d46689af8f0b8eec Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 27 Feb 2025 15:33:51 -0800
Subject: [PATCH 1/2] [lldb-dap] Updating the logging of lldb-dap to use
existing
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/128957
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/129275
>From cd6661b5fb7a9a71352c79740d4b0c0601e61d43 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 28 Feb 2025 09:11:11 -0800
Subject: [PATCH 1/4] [lldb] Add ability to inspect backing th
ashgti wrote:
Also, for reference, this does change the output format.
```
$ cat
lldb-test-build.noindex/tools/lldb-dap/launch/TestDAP_launch.test_termination/dap.txt
1740771506.578514099 stdin/stdout -->
{"command":"disconnect","type":"request","arguments":{},"seq":1}
1740771506.578675032 std
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 1/5] add a process picker for attaching by PID
---
lld
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/129294
Today, logging is handling by a simple `std::ofstream *` for handling logging.
LLDBLog.h can help improve logging by adding new categories of logs and give us
additional formatting support for log messages. We
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/129294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/129294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ajordanr-google wrote:
We haven't had any issues since on our end. I'll check with Fuchsia again to be
sure, then will try to backport.
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
@@ -0,0 +1,102 @@
+import { ChildProcessWithoutNullStreams } from "child_process";
+import { Process, ProcessTree } from ".";
+import { Transform } from "stream";
+
+/** Parses process information from a given line of process output. */
+export type ProcessTreeParser = (line: stri
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/129301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/129275
>From cd6661b5fb7a9a71352c79740d4b0c0601e61d43 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 28 Feb 2025 09:11:11 -0800
Subject: [PATCH 1/3] [lldb] Add ability to inspect backing th
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
Jonas recently added a trampoline handling strategy for simple language thunks
that does: "step through language thunks stepping in one level deep and
stopping if you hit user code". That was actually pulled over
felipepiovezan wrote:
Linux bots seem to print the TID using decimal numbers, so I updated the regex.
https://github.com/llvm/llvm-project/pull/129275
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -0,0 +1,102 @@
+import { ChildProcessWithoutNullStreams } from "child_process";
+import { Process, ProcessTree } from ".";
+import { Transform } from "stream";
+
+/** Parses process information from a given line of process output. */
+export type ProcessTreeParser = (line: stri
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/129294
>From 8d466e5c4b1b6913e788fd11d46689af8f0b8eec Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 27 Feb 2025 15:33:51 -0800
Subject: [PATCH 1/3] [lldb-dap] Updating the logging of lldb-dap to use
existing
@@ -0,0 +1,34 @@
+//===-- DAPLog.h *- C++
-*-===//
ashgti wrote:
Done.
https://github.com/llvm/llvm-project/pull/129294
___
lldb-commits mailing list
lldb-commits@lists.
@@ -0,0 +1,22 @@
+#include "DAPLog.h"
ashgti wrote:
Added
https://github.com/llvm/llvm-project/pull/129294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/129301
Jonas recently added a trampoline handling strategy for simple language thunks
that does: "step through language thunks stepping in one level deep and
stopping if you hit user code". That was actually pulled
https://github.com/JDevlieghere approved this pull request.
LGMT modulo copyright header & the patch file removed.
https://github.com/llvm/llvm-project/pull/129294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -0,0 +1,34 @@
+//===-- DAPLog.h *- C++
-*-===//
JDevlieghere wrote:
```suggestion
//===-- DAPLog.h --===//
```
https://github.com/llvm/llvm-project/pull/1
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/129307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
Today, logging is handling by a simple `std::ofstream *` for handling logging.
LLDBLog.h can help improve logging by adding new categories of logs and give us
additional formatting support for log messages. W
@@ -0,0 +1,114 @@
+//===-- MemoryMonitor.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/129307
>From 2f77beefb752ffdae908101d75381268203311d6 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 28 Feb 2025 11:38:35 -0800
Subject: [PATCH 1/2] Update MinidumpFileBuilder to read and write in chunks
---
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a3ac1f2278dec155e0e0b4d06ec816ba325f6979
8d466e5c4b1b6913e788fd11d46689af8f0b8eec --e
https://github.com/felipepiovezan approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/129301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 56cc9299b7804257549edb4a7ba15999cbb5
a26c5596ac599f1b51cffebd658f3823388e --e
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/129301
>From a26c5596ac599f1b51cffebd658f3823388e Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Fri, 28 Feb 2025 11:45:51 -0800
Subject: [PATCH 1/2] Control the "step out through thunk" logic explicitly
when p
Jlalond wrote:
@labath / @clayborg to preempt some expected feedback, I intend to expose this
chunk size in a future setting
https://github.com/llvm/llvm-project/pull/129307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
I recently received an internal error report that LLDB was OOM'ing when
creating a Minidump. In my 64b refactor we made a decision to acquire buffers
the size of the largest memory region so we could read al
Author: jimingham
Date: 2025-02-28T13:44:17-08:00
New Revision: ddbce2fd2380a4eafce9065ad991318f46a3292b
URL:
https://github.com/llvm/llvm-project/commit/ddbce2fd2380a4eafce9065ad991318f46a3292b
DIFF:
https://github.com/llvm/llvm-project/commit/ddbce2fd2380a4eafce9065ad991318f46a3292b.diff
LOG
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/129332
This implements a memory monitor for macOS & Linux, and registers a callback
that invokes SBDebugger::MemoryPressureDetected() when a low memory event is
detected.
>From c63350db79ac6bcc6f180cc84a37e829d1
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This implements a memory monitor for macOS & Linux, and registers a
callback that invokes SBDebugger::MemoryPressureDetected() when a low memory
event is detected.
---
Full diff: https://github.com
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/129294
>From 8d466e5c4b1b6913e788fd11d46689af8f0b8eec Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 27 Feb 2025 15:33:51 -0800
Subject: [PATCH 1/3] [lldb-dap] Updating the logging of lldb-dap to use
existing
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/129340
>From 02e908312518e85f1d637529c9f62e3dd9551035 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Fri, 28 Feb 2025 15:55:03 -0800
Subject: [PATCH 1/3] Fix a bug copying the stop hooks from the dummy target.
We d
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/129038
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang commented:
Thank you for your persistence to get this across the finish line! 🎉
A couple of (late) review comments below. Sorry for the late review :/
https://github.com/llvm/llvm-project/pull/128957
___
lldb-commits m
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/128957
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -115,41 +123,71 @@ export class LLDBDapDescriptorFactory
}
const configEnvironment =
config.get<{ [key: string]: string }>("environment") || {};
-const dapPath = await getDAPExecutable(session);
+const dapPath = (await getDAPExecutable(session)) ?? exec
@@ -115,41 +123,71 @@ export class LLDBDapDescriptorFactory
}
const configEnvironment =
config.get<{ [key: string]: string }>("environment") || {};
-const dapPath = await getDAPExecutable(session);
+const dapPath = (await getDAPExecutable(session)) ?? exec
@@ -26,10 +26,15 @@ def test_stop_hooks_step_out(self):
self.step_out_test()
def test_stop_hooks_after_expr(self):
-"""Test that a stop hook fires when hitting a breakpoint
-that runs an expression"""
+"""Test that a stop hook fires when hit
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/25] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
@@ -137,53 +157,59 @@ export class LLDBDapDescriptorFactory
const dbgOptions = {
env: {
-...executable?.options?.env,
...configEnvironment,
...env,
},
};
-const dbgArgs = executable?.args ?? [];
vogelsgesang
@@ -137,53 +157,59 @@ export class LLDBDapDescriptorFactory
const dbgOptions = {
env: {
-...executable?.options?.env,
...configEnvironment,
...env,
},
};
-const dbgArgs = executable?.args ?? [];
+const dbgArgs = getDAPArg
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/129262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -137,53 +157,59 @@ export class LLDBDapDescriptorFactory
const dbgOptions = {
env: {
-...executable?.options?.env,
...configEnvironment,
...env,
},
};
-const dbgArgs = executable?.args ?? [];
+const dbgArgs = getDAPArg
@@ -115,41 +123,71 @@ export class LLDBDapDescriptorFactory
}
const configEnvironment =
config.get<{ [key: string]: string }>("environment") || {};
-const dapPath = await getDAPExecutable(session);
+const dapPath = (await getDAPExecutable(session)) ?? exec
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/129294
>From 8d466e5c4b1b6913e788fd11d46689af8f0b8eec Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 27 Feb 2025 15:33:51 -0800
Subject: [PATCH] [lldb-dap] Updating the logging of lldb-dap to use existing
LLDB
https://github.com/matthewbastien created
https://github.com/llvm/llvm-project/pull/129262
Added a new setting called lldb-dap.arguments and a debug configuration
attribute called debugAdapterArgs that can be used to set the arguments used to
launch the debug adapter. Right now this is mostly
@@ -115,41 +123,71 @@ export class LLDBDapDescriptorFactory
}
const configEnvironment =
config.get<{ [key: string]: string }>("environment") || {};
-const dapPath = await getDAPExecutable(session);
+const dapPath = (await getDAPExecutable(session)) ?? exec
ashgti wrote:
> Random question: what happens when the server crashes? Do you get a popup in
> the UI telling you?
If the server is killed while the debug session is running then the debug
session stops. This is the same behavior as today when running not in server
mode.
If the server crashe
DavidSpickett wrote:
If this and the follow up are working well, consider backporting them to 20.x.
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/SuibianP edited
https://github.com/llvm/llvm-project/pull/121269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -987,6 +998,16 @@ void Debugger::Clear() {
// static void Debugger::Destroy(lldb::DebuggerSP &debugger_sp);
// static void Debugger::Terminate();
llvm::call_once(m_clear_once, [this]() {
+lldb_private::telemetry::ScopedDispatcher<
+lldb_private::tel
@@ -18,25 +18,35 @@
namespace lldb_private {
-struct FakeTelemetryInfo : public llvm::telemetry::TelemetryInfo {
+struct FakeTelemetryInfo : public telemetry::LLDBBaseTelemetryInfo {
std::string msg;
+ int num;
+
+ ::llvm::telemetry::KindType getKind() const override { r
@@ -761,7 +765,14 @@ void Debugger::InstanceInitialize() {
DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
void *baton) {
+ lldb_private::telemetry::ScopedDispatcher<
+ lldb_private::telemetry::DebuggerInfo>
+
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/23] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
@@ -56,13 +58,38 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+/// Describes the exit status of a debugger.
+struct ExitDescription {
+ int exit_code;
+ std::string des
oontvoo wrote:
@labath
> IOW, can we drop the exit_desc field from this struct?
Well, we need a way to distinguish the start and the exit entries
How about just keeping `exit_code` (which is set to zero)
> I still think it's important to have a simple and succinct way to check
> whether tele
labath wrote:
> @labath
>
> > IOW, can we drop the exit_desc field from this struct?
>
> Well, we need a way to distinguish the start and the exit entries How about
> just keeping `exit_code` (which is set to zero)
You could distinguish them with a bool or enum field. I don't think an
exit_c
@@ -73,9 +100,50 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
oontvoo wrote:
> One reason for storing it in the
@@ -56,13 +58,38 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+/// Describes the exit status of a debugger.
+struct ExitDescription {
+ int exit_code;
+ std::string des
https://github.com/matthewbastien edited
https://github.com/llvm/llvm-project/pull/129262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/matthewbastien edited
https://github.com/llvm/llvm-project/pull/129262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -75,6 +75,15 @@
"type": "string",
"description": "The path to the lldb-dap binary."
},
+"lldb-dap.arguments": {
+ "scope": "resource",
+ "type": "array",
+ "default": [],
+ "items": {
+"type"
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/129262
>From 8926756d800b9ecd171b6d645a459b01342e9458 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Fri, 28 Feb 2025 11:08:25 -0500
Subject: [PATCH 1/2] allow providing debug adapter arguments
---
lldb/
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/129262
>From 8926756d800b9ecd171b6d645a459b01342e9458 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Fri, 28 Feb 2025 11:08:25 -0500
Subject: [PATCH 1/2] allow providing debug adapter arguments
---
lldb/
@@ -75,6 +75,15 @@
"type": "string",
"description": "The path to the lldb-dap binary."
},
+"lldb-dap.arguments": {
+ "scope": "resource",
+ "type": "array",
+ "default": [],
+ "items": {
+"type"
@@ -116,40 +131,31 @@ export class LLDBDapDescriptorFactory
const configEnvironment =
config.get<{ [key: string]: string }>("environment") || {};
const dapPath = await getDAPExecutable(session);
+const dapArgs = getDAPArguments(session);
const dbgOptions
@@ -0,0 +1,102 @@
+import { ChildProcessWithoutNullStreams } from "child_process";
+import { Process, ProcessTree } from ".";
+import { Transform } from "stream";
+
+/** Parses process information from a given line of process output. */
+export type ProcessTreeParser = (line: stri
Author: John Harrison
Date: 2025-02-28T10:49:24-08:00
New Revision: a3ac1f2278dec155e0e0b4d06ec816ba325f6979
URL:
https://github.com/llvm/llvm-project/commit/a3ac1f2278dec155e0e0b4d06ec816ba325f6979
DIFF:
https://github.com/llvm/llvm-project/commit/a3ac1f2278dec155e0e0b4d06ec816ba325f6979.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/94034
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/94034
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/129038
>From 67e0bd38889c1a62c9f457432f9e9d46c6ece8dc Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 26 Feb 2025 10:01:39 +
Subject: [PATCH] [lldb] Restore register state if PrepareTrivialCall fails
jimingham wrote:
Apparently I need more coffee... This is just in the info command (somehow I
thought the change was to ThreadObjectIterateOverThreads... Done this way,
that's okay.
https://github.com/llvm/llvm-project/pull/129275
___
lldb-commits
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/129275
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@e-kwsm Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build,
https://github.com/JDevlieghere approved this pull request.
LGTM. Thanks for adding the comment with the motivation!
https://github.com/llvm/llvm-project/pull/129135
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/24] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
https://github.com/JDevlieghere commented:
I definitely like this approach much better. Two suggestions:
- Should this use a FileSpec instead of a `std::string` for the sysroot?
- I like the simplicity of a `std::pair` but on the other hand it's hard to
tell what the string represents. I thi
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Matthew Bastien (matthewbastien)
Changes
Added a new setting called lldb-dap.arguments and a debug configuration
attribute called debugAdapterArgs that can be used to set the arguments used to
launch the debug adapter. Right now this is mo
1 - 100 of 187 matches
Mail list logo
