================ @@ -137,53 +157,59 @@ export class LLDBDapDescriptorFactory const dbgOptions = { env: { - ...executable?.options?.env, ...configEnvironment, ...env, }, }; - const dbgArgs = executable?.args ?? []; ---------------- vogelsgesang wrote:
There might be some downstream users who are actually bundling an `lldb-dap` binary into their re-packaged distribution of this VS-Code extension. At least the commit message from https://github.com/llvm/llvm-project/commit/b5d4332286154838557a8ab5c76b794e85d946b3 indicates, that there were some thoughts that downstream consumers might inject the lldb-dap path when using this extension as a library. @JDevlieghere @walter-erquinigo are you aware if anyone is re-packaging this VS-Code extension together with an lldb-dap binary and might be relying on setting the lldb-dap path through the `package.json`? https://github.com/llvm/llvm-project/pull/129262 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits