https://github.com/JDevlieghere commented:
I definitely like this approach much better. Two suggestions: - Should this use a FileSpec instead of a `std::string` for the sysroot? - I like the simplicity of a `std::pair` but on the other hand it's hard to tell what the string represents. I think it would help to either store the `sysroot` in the `XcodeSDK` (potentially as an `std::optional`) or having this return a `struct` with named fiels (e.g. `xcode_sdk`, `sysroot`). Putting the sysroot in the XcodeSDK means you don't have to update the Doxygen comments which are now all outdated. https://github.com/llvm/llvm-project/pull/128712 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
