[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

labath added a comment. I don't know how this is intended to be used, but I find it a rather heavyweight approach towards implementing, well... anything. The idea that something as innocuous as SBAddress::IsValid() will end up iterating through _all_ SBDebugger objects seems wrong, regardless o

[Lldb-commits] [PATCH] D133181: [test] Remove problematic thread from MainLoopTest to fix flakiness

labath added a comment. In D133181#3772830 , @rupprecht wrote: > In D133181#3771747 , @labath wrote: > >> (I've reverted the pthread_kill part, as the mac build did not like it.) > > Thanks! I didn't get any build

[Lldb-commits] [PATCH] D133410: [lldb] Fix ThreadedCommunication races

labath added a comment. I've only seen one flake on linux so far, but the windows bot seems more susceptible to this

[Lldb-commits] [PATCH] D133410: [lldb] Fix ThreadedCommunication races

labath created this revision. labath added reviewers: mgorny, JDevlieghere. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. The Read function could end up blocking if data (or EOF) arrived just as it was about to start waiting for the events. Th

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

labath added a comment. I've added you to D133410 , as I think it demonstrates very well the difficulties in getting two threads to talk to one another. This code has been here since forever (and may have contributed to your desire to introduce interrupts), but

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

kpdev42 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130062/new/ https://reviews.llvm.org/D130062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

labath updated this revision to Diff 458405. labath added a comment. dynamically resize error buffer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133352/new/ https://reviews.llvm.org/D133352 Files: lldb/source/Host/posix/ProcessLauncherPosixFor

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

labath added inline comments. Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:293 +r = llvm::sys::RetryAfterSignal(-1, read, pipe.GetReadFileDescriptor(), pos, +buf.end() - pos); + } while (r > 0); rupprec

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

labath updated this revision to Diff 458408. labath added a comment. Use `pos` instead of the previous size in the resize expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133352/new/ https://reviews.llvm.org/D133352 Files: lldb/source/H

[Lldb-commits] [PATCH] D133410: [lldb] Fix ThreadedCommunication races

mgorny added inline comments. Comment at: lldb/source/Core/ThreadedCommunication.cpp:113 - if (event_type & eBroadcastBitReadThreadDidExit) { -// If the thread exited of its own accord, it either means it -// hit an end-of-file condition or an error. -

[Lldb-commits] [PATCH] D133410: [lldb] Fix ThreadedCommunication races

labath added inline comments. Comment at: lldb/source/Core/ThreadedCommunication.cpp:113 - if (event_type & eBroadcastBitReadThreadDidExit) { -// If the thread exited of its own accord, it either means it -// hit an end-of-file condition or an error. -

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

mgorny added inline comments. Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteLaunch.py:18 +args = [exe_path, "stderr:arg1", "stderr:arg2", "stderr:arg3"] +hex_args = [seven.hexlify(x) for x in args] + labath wrote: > mgorny wrote: > > la

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

labath added inline comments. Comment at: lldb/include/lldb/Target/StackFrame.h:264 /// A pointer to a list of variables. - VariableList *GetVariableList(bool get_file_globals); + VariableList *GetVariableList(bool get_file_globals, Status *error_ptr);

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve updated this revision to Diff 458439. fdeazeve added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 Files: lldb/packages/Python/lldbsuite/test/make/Makefil

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve added inline comments. Comment at: lldb/test/API/commands/expression/fixits/TestFixIts.py:54 +# FIXME: LLDB struggles with this when stdlib has debug info. +if not lldbutil.has_debug_info_in_libcxx(target): +self.assertEquals(value.GetError().

[Lldb-commits] [PATCH] D133410: [lldb] Fix ThreadedCommunication races

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks for noticing and fixing this. Comment at: lldb/source/Core/ThreadedCommunication.cpp:113 - if (event_type & eBroadcastBitReadThreadDidExit) { -// If the

[Lldb-commits] [PATCH] D133427: [gdb-remote] Move broadcasting logic down to GDBRemoteClientBase

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Move the broadcasting support from GDBRemoteCommunication to GDBRemoteClientBase since this is

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes a crash that mistaken global ctor/dtor as funciton methods. Repository

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1198 clang::DeclContext *parent = GetParentDeclContext(PdbSymUid(func_id)); if (!parent) Should the check be done before GetParentDeclContext or be done insi

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

rupprecht accepted this revision. rupprecht added a comment. Thanks again! Still looks good. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:70 +static void consumeNamespace(llvm::StringRef &name) { + // Delete past an inline namespace, if any: __[a

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

rupprecht accepted this revision. rupprecht added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:293 +r = llvm::sys::RetryAfterSignal(-1, read, pipe.GetReadFileDescriptor(), pos, +

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu updated this revision to Diff 458583. zequanwu marked an inline comment as done. zequanwu added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133446/new/ https://reviews.llvm.org/D133446 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D133461: [LLDB][NativePDB] Set block address range.

zequanwu created this revision. zequanwu added reviewers: rnk, labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The block address range was missing before. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 458608. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D133393: [test] Use localhost in place of 127.0.0.1 to run in ipv6-only environments.

rupprecht updated this revision to Diff 458609. rupprecht added a comment. - Add a GetLocalhostIp helper to socket host utilities Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133393/new/ https://reviews.llvm.org/D133393 Files: lldb/unittests/Te

[Lldb-commits] [PATCH] D133393: [test] Use localhost in place of 127.0.0.1 to run in ipv6-only environments.

rupprecht added a comment. In D133393#3773793 , @labath wrote: > I believe the reasons are still relevant. Basically the problem is that > listening on `localhost:x` creates two sockets (one for 127.0.0.1, one for > ::1), and there's no way to guarantee

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:70 +static void consumeNamespace(llvm::StringRef &name) { + // Delete past an inline namespace, if any: __[a-zA-Z0-9_]+:: rupprecht wrote: > nit: this

[Lldb-commits] [PATCH] D133393: [test] Use either `127.0.0.1` or `[::1]` to run in ipv6-only environments.

JDevlieghere added inline comments. Comment at: lldb/unittests/TestingSupport/Host/SocketTestUtilities.h:50 +/// is detected. If neither are detected, return an error. +llvm::Expected GetLocalhostIp(); + nit Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D133393: [test] Use either `127.0.0.1` or `[::1]` to run in ipv6-only environments.

rupprecht updated this revision to Diff 458611. rupprecht added a comment. - Ip -> IP casing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133393/new/ https://reviews.llvm.org/D133393 Files: lldb/unittests/TestingSupport/Host/SocketTestUtilities

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:396 + ifneq ($(or $(USE_LIBSTDCPP), $(USE_LIBCPP)),) + $(error Cannot use system's library and a custom library toget