rnk added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1198 clang::DeclContext *parent = GetParentDeclContext(PdbSymUid(func_id)); if (!parent) ---------------- Should the check be done before GetParentDeclContext or be done inside GetParentDeclContext so that we don't do wasted work computing a parent that won't be used for dynamic initializers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133446/new/ https://reviews.llvm.org/D133446 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
