fdeazeve added inline comments.

================
Comment at: lldb/test/API/commands/expression/fixits/TestFixIts.py:54
+        # FIXME: LLDB struggles with this when stdlib has debug info.
+        if not lldbutil.has_debug_info_in_libcxx(target):
+            self.assertEquals(value.GetError().GetCString(), "error: No value")
----------------
labath wrote:
> What kind of error are you getting here? Are you sure this is not some form 
> of https://github.com/llvm/llvm-project/issues/34391, which could be worked 
> around by renaming some variables in the expression?
The error is indeed about a name clash with `X`, where the expression evaluator 
also sees a definition of a type `X` inside a function in 
`libcxxabi/src/private_typeinfo.cpp`.

It seems like the link you described has a variant of this problem, so I'll 
make a comment there and rename the `X` in this test to something else. Thanks 
for the link!


================
Comment at: 
lldb/test/API/commands/expression/import-std-module/forward_list-dbg-info-content/TestDbgInfoContentForwardListFromStdModule.py:35
         # FIXME: The value here isn't actually empty.
-        self.expect_expr("a.front()",
-                         result_type=value_type,
-                         result_children=[ValueCheck()])
+        # FIXME: LLDB struggles with this when stdlib has debug info.
+        if not lldbutil.has_debug_info_in_libcxx(target):
----------------
labath wrote:
> And here it might be better to just remove the check, as it's checking for 
> buggy behavior anyway.
Done!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132940/new/

https://reviews.llvm.org/D132940

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to