[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

labath added a comment. I can't help the feeling that the boilerplate introduced by the enum compression is just not worth the benefit it brings, but otherwise this looks ok apart from the two inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h:

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is what I hand in mind. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115073/new/ https://reviews.llvm.org/D115073 ___

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

labath accepted this revision. labath added a comment. I am still not sure this is the right solution, but a) I don't know what *is* the right solution; and (b) I don't think this makes the situation worse; so I am hitting accept. In D113930#3175022 , @

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

zrthxn updated this revision to Diff 392305. zrthxn added a comment. Removed old/dead code and commented out sections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D115178 Files: lldb/source/Plugins/Language/

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

zrthxn updated this revision to Diff 392308. zrthxn added a comment. Cosmetic changes and incorporate requested changes from review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D115178 Files: lldb/source/Plu

[Lldb-commits] [PATCH] D115151: [lldb/qemu] Add emulator-args setting

DavidSpickett added a comment. LGTM. Not clear what qemu options will be most useful yet and a catch all is always useful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115151/new/ https://reviews.llvm.org/D115151 ___

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

tschuett added a comment. I believe the `Basic` library in Clang does not depend on other Clang libraries. It is a tail library. Do you envision a Basic, Utility, ... library that does not depend on Clang and provides basic utilities. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11521

[Lldb-commits] [lldb] f72ae5c - [lldb] Fix windows path guessing for root paths

Author: Jaroslav Sevcik Date: 2021-12-07T11:16:04+01:00 New Revision: f72ae5cba1d625301aa8a668a3d54ec3ac5b7806 URL: https://github.com/llvm/llvm-project/commit/f72ae5cba1d625301aa8a668a3d54ec3ac5b7806 DIFF: https://github.com/llvm/llvm-project/commit/f72ae5cba1d625301aa8a668a3d54ec3ac5b7806.dif

[Lldb-commits] [PATCH] D115104: [lldb] Fix guessing of windows path style

This revision was automatically updated to reflect the committed changes. Closed by commit rGf72ae5cba1d6: [lldb] Fix windows path guessing for root paths (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115104/new/ https://reviews

[Lldb-commits] [PATCH] D114911: [lldb] Introduce a FreeBSDKernel plugin for vmcores

mgorny updated this revision to Diff 392328. mgorny added a comment. Fix segv when there's no executable module. Move dependency check to LLDBConfig and use `find_package()`-style check. Add initial test files (still WIP). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114911/new/ https

[Lldb-commits] [PATCH] D114911: [lldb] Introduce a FreeBSDKernel plugin for vmcores

mgorny updated this revision to Diff 392333. mgorny added a comment. Remove a debugging hack, make the test actually test something. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114911/new/ https://reviews.llvm.org/D114911 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/packages/P

[Lldb-commits] [PATCH] D114911: [lldb] Introduce a FreeBSDKernel plugin for vmcores

mgorny updated this revision to Diff 392352. mgorny added a comment. Finish that one tet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114911/new/ https://reviews.llvm.org/D114911 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/sou

[Lldb-commits] [PATCH] D115151: [lldb/qemu] Add emulator-args setting

This revision was automatically updated to reflect the committed changes. Closed by commit rG611fdde4c765: [lldb/qemu] Add emulator-args setting (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115151/new/ https://reviews.llvm.org

[Lldb-commits] [lldb] 611fdde - [lldb/qemu] Add emulator-args setting

Author: Pavel Labath Date: 2021-12-07T14:19:43+01:00 New Revision: 611fdde4c765d1ed213744263cb2bbc04bd5060c URL: https://github.com/llvm/llvm-project/commit/611fdde4c765d1ed213744263cb2bbc04bd5060c DIFF: https://github.com/llvm/llvm-project/commit/611fdde4c765d1ed213744263cb2bbc04bd5060c.diff

[Lldb-commits] [lldb] d4083a2 - [lldb] Fix flakyness in TestQemuLaunch.test_stdio_redirect

Author: Pavel Labath Date: 2021-12-07T14:19:44+01:00 New Revision: d4083a296ac828440604574e7a9fac70ede96d66 URL: https://github.com/llvm/llvm-project/commit/d4083a296ac828440604574e7a9fac70ede96d66 DIFF: https://github.com/llvm/llvm-project/commit/d4083a296ac828440604574e7a9fac70ede96d66.diff

[Lldb-commits] [PATCH] D115246: [lldb/qemu] Separate host and target environments

labath created this revision. labath added reviewers: DavidSpickett, mgorny, JDevlieghere. labath requested review of this revision. Herald added a project: LLDB. Qemu normally forwards its (host) environment variables to the emulated process. While this works fine for most variables, there are so

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger added inline comments. Comment at: lldb/source/Symbol/SymbolFile.cpp:148 + std::string(scope.GetCString()), type_class, + true); +} I need to change this. This was correct in the first iteratio

[Lldb-commits] [PATCH] D115246: [lldb/qemu] Separate host and target environments

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.cpp:121 +auto host_it = host.find(KV.first()); +if (host_it == host.end() || host_it->second != KV.second) + set_env.push_back(Environment::compose(KV)); -

[Lldb-commits] [PATCH] D115246: [lldb/qemu] Separate host and target environments

DavidSpickett added a comment. Oh and: This patch also adds a new setting -- target-env-vars Might want to clarify that it adds this setting **to the qemu user platform**. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115246/new/ https://review

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

werat added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2461 + bool has_scope = !scope.IsEmpty(); + llvm::StringRef sc(scope.GetStringRef()); + std::string storage; nit: maybe call it `scope_ref`? Co

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

JDevlieghere added a comment. In D115211#3175581 , @labath wrote: > I am definitely not sad to see lldbBase go away, but I am wondering if we > really need a separate library for this functionality (function). > > The only reason I can think of is that t

[Lldb-commits] [lldb] 244258e - Modify DataEncoder to be able to encode data in an object owned buffer.

Author: Greg Clayton Date: 2021-12-07T09:44:57-08:00 New Revision: 244258e35acc92b3293e91ddecee6a8c8613ec20 URL: https://github.com/llvm/llvm-project/commit/244258e35acc92b3293e91ddecee6a8c8613ec20 DIFF: https://github.com/llvm/llvm-project/commit/244258e35acc92b3293e91ddecee6a8c8613ec20.diff

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

This revision was automatically updated to reflect the committed changes. Closed by commit rG244258e35acc: Modify DataEncoder to be able to encode data in an object owned buffer. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D115201: [lldb] Move UpdateSymbolContextScopeForType

shafik added a comment. Can you add a motivation for this to your summary, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115201/new/ https://reviews.llvm.org/D115201 ___ lldb-commits mailing l

[Lldb-commits] [lldb] a3a8ed3 - [LLDB][NativePDB] Fix function decl creation for class methods

Author: Zequan Wu Date: 2021-12-07T10:41:28-08:00 New Revision: a3a8ed33a1d6a5047aae29790e02f3c7955297af URL: https://github.com/llvm/llvm-project/commit/a3a8ed33a1d6a5047aae29790e02f3c7955297af DIFF: https://github.com/llvm/llvm-project/commit/a3a8ed33a1d6a5047aae29790e02f3c7955297af.diff LOG

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3a8ed33a1d6: [LLDB][NativePDB] Fix function decl creation for class methods (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D113930?vs=391777&id=392465#toc Repository: rG L

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

labath added a comment. The main reason I wanted to avoid a separate library is because I could not imagine how would it fit into the general library landscape in lldb. It's also moderately strange to have a library for just a single function, but that is something I can live with. If the idea

[Lldb-commits] [lldb] cfe5d76 - Fix buildbot after https://reviews.llvm.org/D115073.

Author: Greg Clayton Date: 2021-12-07T12:03:45-08:00 New Revision: cfe5d768be95ae0a62cf430e56e7762cebf81a65 URL: https://github.com/llvm/llvm-project/commit/cfe5d768be95ae0a62cf430e56e7762cebf81a65 DIFF: https://github.com/llvm/llvm-project/commit/cfe5d768be95ae0a62cf430e56e7762cebf81a65.diff

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

clayborg added a comment. Fixed a buildbot issue for linux with: commit cfe5d768be95ae0a62cf430e56e7762cebf81a65 (HEAD -> main, origin/main, origin/HEAD) Author: Greg Clayton Date: Tue Dec 7 12:03:45 2021 -0800 Fix buil

[Lldb-commits] [PATCH] D115126: [LLDB] Add unit tests for Editline keyboard shortcuts

nealsid updated this revision to Diff 392497. nealsid edited the summary of this revision. nealsid added a comment. Testing ARC, no action necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115126/new/ https://reviews.llvm.org/D115126 Files:

[Lldb-commits] [lldb] 220854a - Fix buildbots after https://reviews.llvm.org/D115073.

Author: Greg Clayton Date: 2021-12-07T12:19:00-08:00 New Revision: 220854a47bdc0c281dbaafb54411ec65e76212b3 URL: https://github.com/llvm/llvm-project/commit/220854a47bdc0c281dbaafb54411ec65e76212b3 DIFF: https://github.com/llvm/llvm-project/commit/220854a47bdc0c281dbaafb54411ec65e76212b3.diff

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

clayborg added a comment. Another fix for buildbots. Don't use llvm::ArrayRef to refer to data, store in std::vector<>. In release builds this will fail. commit 220854a47bdc0c281dbaafb54411ec65e76212b3 (HEAD -> main, origin/

[Lldb-commits] [PATCH] D115277: [lldb] Workaround for type-like entities defined in a lexical block

krisb created this revision. krisb added reviewers: jingham, aprantl, JDevlieghere. Herald added a subscriber: pengfei. krisb requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D113741 and D113743

[Lldb-commits] [lldb] f758859 - Fix error reporting for "process load" and add a test for it.

Author: Jim Ingham Date: 2021-12-07T15:08:05-08:00 New Revision: f75885977cefe4d5ebbe51f85b353bb9989dd777 URL: https://github.com/llvm/llvm-project/commit/f75885977cefe4d5ebbe51f85b353bb9989dd777 DIFF: https://github.com/llvm/llvm-project/commit/f75885977cefe4d5ebbe51f85b353bb9989dd777.diff LO

[Lldb-commits] [PATCH] D115017: Fix error reporting for "process load" and add a test for it.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf75885977cef: Fix error reporting for "process load" and add a test for it. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115017/new/

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

JDevlieghere updated this revision to Diff 392590. JDevlieghere added a comment. Rename Basic -> Version CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115211/new/ https://reviews.llvm.org/D115211 Files: lldb/include/lldb/Version/Version.h lldb/include/lldb/Version/Version.inc.in

[Lldb-commits] [PATCH] D115308: [LLDB][DWARF] Fix duplicate TypeSP in type list

zequanwu created this revision. zequanwu added reviewers: labath, shafik, teemperor. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115308 Files: lldb/source/Plug

[Lldb-commits] [PATCH] D115277: [lldb] Workaround for type-like entities defined in a lexical block

jingham added a comment. I worry this makes the case where a function has two definitions of the same type in one function a more confusing error than the "can't find type" error you would get without this patch. Is this of sufficient urgency that we can't take the time to fix it correctly?

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial location at function start

mib created this revision. mib requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It can happen that a line entry reports that some source code is located at line 0. In DWARF, line 0 is a special location which indicates that code has no 1-1 m

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial location at function start

mib updated this revision to Diff 392622. mib added reviewers: aprantl, jingham. Herald added a subscriber: JDevlieghere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115313/new/ https://reviews.llvm.org/D115313 Files: lldb/source/Target/StackFra

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial location at function start

dblaikie added a comment. Side note: The src_file is not to be trusted/used either - once line 0 is specified, nothing else in that line entry is valid. LLVM lets the previous line entries file persist because this reduces encoding size (by not having to switch all the fields in the line table

[Lldb-commits] [PATCH] D115308: [LLDB][DWARF] Fix duplicate TypeSP in type list

labath added a comment. Thanks for fixing this. I assume that the type is already being added to the type list somewhere else -- it'd be nice to say, for future archaeologists' sake, where that actually happens. But my main question is really about the test. Comment at: lldb