labath added a comment.
Thanks for fixing this. I assume that the type is already being added to the
type list somewhere else -- it'd be nice to say, for future archaeologists'
sake, where that actually happens.
But my main question is really about the test.
================
Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/find-basic-type.cpp:40
// NAME-DAG: name = "foo", {{.*}} decl = find-basic-type.cpp:[[@LINE-1]]
+// TYPES: name = "foo", size = 1, decl = find-basic-type.cpp:[[@LINE-2]]
----------------
Does this actually check that the type is not emitted more than once?
This is the reason why the other checks have the "Found <X> types" assertion
above. We currently don't have such output from --find=none, but feel free to
add something.
It might also be better to make this a separate test, as the output also
includes things like `int` -- it would start to get messy if you included all
of that here, and this test was about testing something different anyway.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115308/new/
https://reviews.llvm.org/D115308
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
