[Lldb-commits] [lldb] 7dd76cc - [LLDB] Skip TestExitDuringExpression on aarch64/linux buildbot

Author: Muhammad Omair Javaid Date: 2021-03-19T15:30:10+05:00 New Revision: 7dd76a02ee59588647f2d97f1b554c48f580 URL: https://github.com/llvm/llvm-project/commit/7dd76a02ee59588647f2d97f1b554c48f580 DIFF: https://github.com/llvm/llvm-project/commit/7dd76a02ee59588647f2d97f1b554c48f5

[Lldb-commits] [PATCH] D98822: [lldb] follow-fork/vfork support [WIP]

mgorny updated this revision to Diff 331824. mgorny marked 3 inline comments as done. mgorny added a comment. Switched `Extension` to bitmask-enum, fixed prototype and decl for `getPIDForTID` and switched server features into a virtual as suggested by @labath. CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 331830. omjavaid added a comment. This update address review comments from @labath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 331834. omjavaid added a comment. This update further cleans up and removes static functions that calculated m_register_info_p GetRegisterInfoPtr and m_register_info_count GetRegisterInfoCount CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/ne

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 331835. omjavaid added a comment. Rebased after changes to parent D96458 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRe

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 331836. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/commands/register/register/aarch64_dynamic_regset/Makefile lldb/test/API/com

[Lldb-commits] [PATCH] D98822: [lldb] follow-fork/vfork support [WIP]

mgorny updated this revision to Diff 331846. mgorny added a comment. Fix typo: qSupported needs to be joined using `;`, not `,`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://reviews.llvm.org/D98822 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lld

[Lldb-commits] [PATCH] D98822: [lldb] follow-fork/vfork support [WIP]

jingham added a comment. The gdb model - since gdb only supports one debugee per gdb - is to either follow the fork or follow the parent. It would be more in keeping with lldb's model to make a new target for the child side of the fork, and use that to follow the child. That way you can conti

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

JDevlieghere updated this revision to Diff 331918. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98842/new/ https://reviews.llvm.org/D98842 Files: lldb/test/API/CMakeLists.txt lldb/test/CMakeLists.txt lldb/test/Shell/CMakeLists.txt lldb/test

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added a comment. In D97739#2636343 , @jingham wrote: > Thanks for doing this! The event version looks pretty clean to me. I think > we should go that way. I don't think we should have two ways, that seems > confusing and still leaves us calli

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Clean builds for all the test targets work now and this also looks good, so let's ship it. (also thanks for working on that, the unit test builds where a big annoyance when testing API

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c52d4fd4c24: [lldb] Make the API, Shell and Unit tests independent lit test suites (authored by JDevlieghere). Herald added a project: LLDB. Change

[Lldb-commits] [lldb] 6c52d4f - [lldb] Make the API, Shell and Unit tests independent lit test suites

Author: Jonas Devlieghere Date: 2021-03-19T11:13:46-07:00 New Revision: 6c52d4fd4c24a0cf738e44516ca8378d65dcf019 URL: https://github.com/llvm/llvm-project/commit/6c52d4fd4c24a0cf738e44516ca8378d65dcf019 DIFF: https://github.com/llvm/llvm-project/commit/6c52d4fd4c24a0cf738e44516ca8378d65dcf019.d

[Lldb-commits] [lldb] 9406d43 - Make the stop-on-sharedlibrary-events setting work.

Author: Jim Ingham Date: 2021-03-19T12:02:16-07:00 New Revision: 9406d43138811ac4dfd0ab31434f65a649bc882e URL: https://github.com/llvm/llvm-project/commit/9406d43138811ac4dfd0ab31434f65a649bc882e DIFF: https://github.com/llvm/llvm-project/commit/9406d43138811ac4dfd0ab31434f65a649bc882e.diff LO

[Lldb-commits] [PATCH] D98914: Make target.process.stop-on-sharedlibrary-events setting work

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9406d4313881: Make the stop-on-sharedlibrary-events setting work. (authored by jingham). Changed prior to commit: https://reviews.llvm.org/D98914?

[Lldb-commits] [PATCH] D98914: Make target.process.stop-on-sharedlibrary-events setting work

jingham added a comment. I added a couple more tests for having a breakpoint at the load site before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98914/new/ https://reviews.llvm.org/D98914

[Lldb-commits] [lldb] a8d62fc - Skip all the tests for Windows.

Author: Jim Ingham Date: 2021-03-19T12:05:16-07:00 New Revision: a8d62fc8ff1c836e16cfb1a510ee8063ac2652ff URL: https://github.com/llvm/llvm-project/commit/a8d62fc8ff1c836e16cfb1a510ee8063ac2652ff DIFF: https://github.com/llvm/llvm-project/commit/a8d62fc8ff1c836e16cfb1a510ee8063ac2652ff.diff LO

[Lldb-commits] [lldb] e8e07b3 - Revert "Skip all the tests for Windows."

Author: Jim Ingham Date: 2021-03-19T12:38:23-07:00 New Revision: e8e07b3a5e6032edeed559db448402094cff31bf URL: https://github.com/llvm/llvm-project/commit/e8e07b3a5e6032edeed559db448402094cff31bf DIFF: https://github.com/llvm/llvm-project/commit/e8e07b3a5e6032edeed559db448402094cff31bf.diff LO

[Lldb-commits] [lldb] 9d081a7 - Revert "Make the stop-on-sharedlibrary-events setting work."

Author: Jim Ingham Date: 2021-03-19T12:38:41-07:00 New Revision: 9d081a7ffe5c2f9575f77bedd6cbf4385287aeec URL: https://github.com/llvm/llvm-project/commit/9d081a7ffe5c2f9575f77bedd6cbf4385287aeec DIFF: https://github.com/llvm/llvm-project/commit/9d081a7ffe5c2f9575f77bedd6cbf4385287aeec.diff LO

[Lldb-commits] [PATCH] D98822: [lldb] follow-fork/vfork support [WIP]

mgorny updated this revision to Diff 331982. mgorny added a comment. Now using the new thingie for threads. `getTIDForPID()` temporarily commented out but I plan to use it to distinguish `clone()` for new thread from `clone()` for new process. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY

kastiglione added inline comments. Comment at: lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:609 if (!path_strings) { - result_ptr->image_ptr = dlopen(name, 2); + result_ptr->image_ptr = dlopen(name, )" DLOPEN_OPTIONS R"(); if (result_ptr->image_ptr)

[Lldb-commits] [PATCH] D98987: [lldb] Call os_log_fault on lldb_assert

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, aprantl. JDevlieghere requested review of this revision. Call `os_log_fault` when an lldb assert fails. We piggyback off of the `LLVM_SUPPORT_XCODE_SIGNPOSTS` to for `os_log` support rather than introducing another check and

[Lldb-commits] [PATCH] D98987: [lldb] Call os_log_fault on lldb_assert

JDevlieghere updated this revision to Diff 331997. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98987/new/ https://reviews.llvm.org/D98987 Files: lldb/include/lldb/Utility/LLDBAssert.h lldb/source/Utility/LLDBAssert.cpp lldb/test/Shell/Error/assert.test lldb/tools/lldb-test/lldb

[Lldb-commits] [PATCH] D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY

vsk updated this revision to Diff 331998. vsk added a comment. - Define RTLD_LAZY in the expression as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98879/new/ https://reviews.llvm.org/D98879 Files: lldb/source/Plugins/Platform/POSIX/P

[Lldb-commits] [PATCH] D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY

vsk updated this revision to Diff 331999. vsk added a comment. - Delete an unused '#undef DLOPEN_OPTIONS' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98879/new/ https://reviews.llvm.org/D98879 Files: lldb/source/Plugins/Platform/POSIX/Platform

[Lldb-commits] [PATCH] D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98879/new/ https://reviews.llvm.org/D98879 _

[Lldb-commits] [lldb] e089b5e - [lldb] Call os_log_fault on lldb_assert

Author: Jonas Devlieghere Date: 2021-03-19T14:23:50-07:00 New Revision: e089b5e9e11a61be0a11378f8df9af806807bddc URL: https://github.com/llvm/llvm-project/commit/e089b5e9e11a61be0a11378f8df9af806807bddc DIFF: https://github.com/llvm/llvm-project/commit/e089b5e9e11a61be0a11378f8df9af806807bddc.d

[Lldb-commits] [PATCH] D98987: [lldb] Call os_log_fault on lldb_assert

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe089b5e9e11a: [lldb] Call os_log_fault on lldb_assert (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorep

[Lldb-commits] [lldb] cdac601 - [lldb] Update assert.test to be less strict

Author: Jonas Devlieghere Date: 2021-03-19T14:31:56-07:00 New Revision: cdac60107db9f04b27077379259678adf6f03617 URL: https://github.com/llvm/llvm-project/commit/cdac60107db9f04b27077379259678adf6f03617 DIFF: https://github.com/llvm/llvm-project/commit/cdac60107db9f04b27077379259678adf6f03617.d

[Lldb-commits] [PATCH] D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY

kastiglione accepted this revision. kastiglione added a comment. 🚢 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98879/new/ https://reviews.llvm.org/D98879 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [lldb] cb8c1ee - [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY

Author: Vedant Kumar Date: 2021-03-19T15:13:43-07:00 New Revision: cb8c1ee269da72eb6e2c18800cd8ab0a74050785 URL: https://github.com/llvm/llvm-project/commit/cb8c1ee269da72eb6e2c18800cd8ab0a74050785 DIFF: https://github.com/llvm/llvm-project/commit/cb8c1ee269da72eb6e2c18800cd8ab0a74050785.diff

[Lldb-commits] [PATCH] D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb8c1ee269da: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY (authored by vsk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D98822: [lldb] follow-fork/vfork support [WIP]

mgorny added a comment. In D98822#2637871 , @jingham wrote: > The gdb model - since gdb only supports one debugee per gdb - is to either > follow the fork or follow the parent. It would be more in keeping with > lldb's model to make a new target for the

[Lldb-commits] [PATCH] D98822: [lldb] follow-fork/vfork support [WIP]

mgorny updated this revision to Diff 332013. mgorny added a comment. Add a super-trivial test that the debugger doesn't lose parent after the fork. Next on the list: clear software breakpoints in the detached fork. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://review

[Lldb-commits] [lldb] d8d5ef2 - Revert "[lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY"

Author: Vedant Kumar Date: 2021-03-19T15:26:16-07:00 New Revision: d8d5ef2e9d84fbbc2878b3fd977f9c62ea0661d7 URL: https://github.com/llvm/llvm-project/commit/d8d5ef2e9d84fbbc2878b3fd977f9c62ea0661d7 DIFF: https://github.com/llvm/llvm-project/commit/d8d5ef2e9d84fbbc2878b3fd977f9c62ea0661d7.diff

[Lldb-commits] [PATCH] D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY

vsk updated this revision to Diff 332024. vsk added a comment. Add asserts checking that the library paths exist, and restrict the test to Darwin. See https://bugs.llvm.org/show_bug.cgi?id=49656 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98879/new/ https://reviews.llvm.org/D98879 F

[Lldb-commits] [lldb] 4bd2bfb - [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY (reapply)

Author: Vedant Kumar Date: 2021-03-19T16:06:00-07:00 New Revision: 4bd2bfb6ec0980853d7f9d1874e0547b68b7a61e URL: https://github.com/llvm/llvm-project/commit/4bd2bfb6ec0980853d7f9d1874e0547b68b7a61e DIFF: https://github.com/llvm/llvm-project/commit/4bd2bfb6ec0980853d7f9d1874e0547b68b7a61e.diff

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

stella.stamenova added a comment. This did end up breaking the windows build bot... https://lab.llvm.org/buildbot/#/builders/83/builds/4808 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98842/new/ https://reviews.llvm.org/D98842 _

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

JDevlieghere added a comment. In D98842#2638929 , @stella.stamenova wrote: > This did end up breaking the windows build bot... > > https://lab.llvm.org/buildbot/#/builders/83/builds/4808 Thanks, the error message suggests the tests are run twice and the

[Lldb-commits] [PATCH] D98996: Teach DWARFExpression about DWARF 4+ Location Descriptions

aprantl created this revision. aprantl added reviewers: jasonmolenda, JDevlieghere, labath. aprantl requested review of this revision. DWARFExpression implements the DWARF2 expression model that left ambiguity on whether the result of an expression was a value or an address. This patch implement

[Lldb-commits] [lldb] e76b866 - Revert "[lldb] Make the API, Shell and Unit tests independent lit test suites"

Author: Jonas Devlieghere Date: 2021-03-19T17:57:26-07:00 New Revision: e76b86642f51c868c307d097cb129df1b1ac6423 URL: https://github.com/llvm/llvm-project/commit/e76b86642f51c868c307d097cb129df1b1ac6423 DIFF: https://github.com/llvm/llvm-project/commit/e76b86642f51c868c307d097cb129df1b1ac6423.d

Re: [Lldb-commits] [lldb] e76b866 - Revert "[lldb] Make the API, Shell and Unit tests independent lit test suites"

Would be great if you could include some detail in the commit message (or, in this case, in a follow-up reply) about why the patch was reverted, thanks! On Fri, Mar 19, 2021 at 5:57 PM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Jonas Devlieghere > Date: 2

[Lldb-commits] [PATCH] D98996: Teach DWARFExpression about DWARF 4+ Location Descriptions

dblaikie added a comment. (idle question: Is this code remotely related to any code in LLVM's libDebugInfoDWARF? Does this patch take us closer to or further away from unifying them? If it takes us further away, any chance of designing it in a direction that points towards each other rather tha

[Lldb-commits] [PATCH] D98996: Teach DWARFExpression about DWARF 4+ Location Descriptions

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This fits with my reading of the DWARF5 doc; LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98996/new/ https://reviews.llvm.org/D98996 __