[Lldb-commits] [PATCH] D90298: [lldb] [Process/FreeBSDRemote] Implement thread GetName()

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Implement NativeThreadFreeBSD::GetName(). This is based on the equivalent code in the legacy FreeBSD plugin, except it is modernized

[Lldb-commits] [PATCH] D90298: [lldb] [Process/FreeBSDRemote] Implement thread GetName()

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.cpp:151 -std::string NativeThreadFreeBSD::GetName() { return ""; } +std::string NativeThreadFreeBSD::GetName() { + if (!m_thread_name) { It is probabl

[Lldb-commits] [PATCH] D90298: [lldb] [Process/FreeBSDRemote] Implement thread GetName()

labath added a comment. I am not sure that the caching is really needed, but this seems ok to me. I'm assuming that this fixes TestGdbRemoteThreadName.py... Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.cpp:164 + if (ptr == nullptr || (error !

[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

JosephTremoulet added a comment. I'd been hoping to get this bugfix into 11.0.1, but it (and D89156 , which is just some cleanup that occurred to me while working on this code) have been stalled for a few weeks, and I don't have any insight into the reason. If

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 301271. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 Files: lldb/bindings/interface/SBType.i lldb/include/lldb/API/SBModule.h lldb/include/lldb/API/SBType.h l

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. Please commit it for me. Ilya Bukonkin fallk...@yahoo.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D90313: [lldb] Use reverse connection method for lldb-server tests

labath created this revision. labath added reviewers: rupprecht, JDevlieghere. Herald added a subscriber: jfb. Herald added a project: LLDB. labath requested review of this revision. This fixes an flakyness is all gdb-remote tests. These tests have been (mildly) flaky since we started using "local

[Lldb-commits] [PATCH] D90313: [lldb] Use reverse connection method for lldb-server tests

JDevlieghere added a comment. On GreenDragon we've also noticed the increased flakiness and it sounds like it could very well be the same issue? It seems like this would only solve it for lldb-server, while we run these tests with debugserver. The latter doesn't support `--reverse-connect`, so

[Lldb-commits] [PATCH] D90313: [lldb] Use reverse connection method for lldb-server tests

labath added a comment. In D90313#2359273 , @JDevlieghere wrote: > On GreenDragon we've also noticed the increased flakiness and it sounds like > it could very well be the same issue? It seems like this would only solve it > for lldb-server, while we ru

[Lldb-commits] [PATCH] D90313: [lldb] Use reverse connection method for lldb-server tests

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D90313#2359300 , @labath wrote: > In D90313#2359273 , @JDevlieghere > wrote: > >> On GreenDrago

[Lldb-commits] [PATCH] D90276: [lldb/utils] Add the lldb-env tool

vsk added a comment. >> Re: making the lit.site.cfg self-contained, IIUC the situation is that there >> are a couple places where we shell out via `subprocess`, but that you'd like >> to get rid of these? I wonder whether we could bundle up the necessary >> scripts along with lit.site.cfg inste

[Lldb-commits] [PATCH] D90298: [lldb] [Process/FreeBSDRemote] Implement thread GetName()

mgorny marked 3 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.cpp:151 -std::string NativeThreadFreeBSD::GetName() { return ""; } +std::string NativeThreadFreeBSD::GetName() { + if (!m_thread_na

[Lldb-commits] [PATCH] D90298: [lldb] [Process/FreeBSDRemote] Implement thread GetName()

mgorny updated this revision to Diff 301319. mgorny added a comment. Removed overallocation and put plain `m_state` into log message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90298/new/ https://reviews.llvm.org/D90298 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeThread

[Lldb-commits] [PATCH] D90318: Return actual type from SBType::GetArrayElementType

werat created this revision. werat added reviewers: teemperor, jarin. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. werat requested review of this revision. `SBType::GetArrayElementType` should return the actual type, not the canonica

[Lldb-commits] [PATCH] D90318: Return actual type from SBType::GetArrayElementType

jingham added a comment. This was done on purpose, in commit 902974277d507a149e33487d32e4ba58c41451b6 . The comment there is: Data formatters: Look through array element typedefs Summary: Motivation: When formatting

[Lldb-commits] [PATCH] D90276: [lldb/utils] Add the lldb-env tool

vsk abandoned this revision. vsk added a comment. Jonas walked me through some of the issues here offline: - Looks like this makes testing depend on having a configured lldb-env tool, this will make it hard to run testing against an lldb root. - If we need to launch ./bin/lldb in some other work

[Lldb-commits] [PATCH] D90325: [lldb][NFC] Refactor getUUID functionality

zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. zequanwu requested review of this revision. Herald added a subscriber: JDevlieghere. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90325 Fil

[Lldb-commits] [PATCH] D90318: Return actual type from SBType::GetArrayElementType

jarin accepted this revision. jarin added a comment. This revision is now accepted and ready to land. The code change looks good to me and it is in line with the change that Raphael and Greg wanted in https://reviews.llvm.org/D72133. As far as I remember, https://reviews.llvm.org/D72133 did not

[Lldb-commits] [lldb] 158f336 - [lldb] Delete lldb/utils/test

Author: Vedant Kumar Date: 2020-10-28T12:06:02-07:00 New Revision: 158f3360438f92cefc60041dcb8db980d7d1c744 URL: https://github.com/llvm/llvm-project/commit/158f3360438f92cefc60041dcb8db980d7d1c744 DIFF: https://github.com/llvm/llvm-project/commit/158f3360438f92cefc60041dcb8db980d7d1c744.diff

[Lldb-commits] [PATCH] D90325: [lldb][NFC] Refactor getUUID functionality

zequanwu updated this revision to Diff 301378. zequanwu added a comment. include correct header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90325/new/ https://reviews.llvm.org/D90325 Files: lldb/include/lldb/Utility/UUID.h lldb/source/Plugin

[Lldb-commits] [PATCH] D90332: Mark the execution of commands in stop hooks as non-interactive

jingham created this revision. jingham added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. jingham requested review of this revision. stop-hooks were not intended to be interactive, that would be really confusing when there are many in flight. S

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm updated this revision to Diff 301450. aadsm added a comment. - Fixed formatting issues - Updated comment on the reason we need to do this - Improved the lit test by also checking how many matches it found Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I can't see anything wrong with this, it seems to follow the practice of other parts of GetSharedModule. I'm still not quite certain why I've never seen an instance where the absence of you

[Lldb-commits] [lldb] 49c84fd - Revert "[AppleObjCRuntimeV2] Force lazily allocated class names to be resolved."

Author: Jonas Devlieghere Date: 2020-10-28T16:53:02-07:00 New Revision: 49c84fd5a4bd88cbf61ac6888a66c5da07705c5e URL: https://github.com/llvm/llvm-project/commit/49c84fd5a4bd88cbf61ac6888a66c5da07705c5e DIFF: https://github.com/llvm/llvm-project/commit/49c84fd5a4bd88cbf61ac6888a66c5da07705c5e.d

[Lldb-commits] [PATCH] D89999: [lldb] Implement ObjCGetClassNameRaw using a UtilityFunction

JDevlieghere abandoned this revision. JDevlieghere added a comment. 49c84fd5a4bd CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8/new/ https://reviews.llvm.org/D8 _

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

aadsm updated this revision to Diff 301503. aadsm added a comment. Rewrote the test in lit. I had to do it in an non standard way. It seems that lldb will exit with an error code if you do -b -o of a command that doesn't "work", (e.g.: image lookup finds nothing). Since lit runs this with set -