jarin accepted this revision. jarin added a comment. This revision is now accepted and ready to land.
The code change looks good to me and it is in line with the change that Raphael and Greg wanted in https://reviews.llvm.org/D72133. As far as I remember, https://reviews.llvm.org/D72133 did not change the previous behavior because I felt that changing API semantics was out of scope of what I wanted to do with the formatters. Someone else should look at the test. The addition seems to be a bit ad-hoc, but overall reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90318/new/ https://reviews.llvm.org/D90318 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits