krytarowski added inline comments.
================
Comment at:
lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.cpp:151
-std::string NativeThreadFreeBSD::GetName() { return ""; }
+std::string NativeThreadFreeBSD::GetName() {
+ if (!m_thread_name) {
----------------
It is probably fine, but I would use:
1. `PT_GETNUMLWPS`
2. `PT_GETLWPLIST` with optional caching
3. Read `pl_tdname` from `ptrace_lwpinfo`
================
Comment at:
lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.cpp:164
+ if (ptr == nullptr || (error != 0 && errno == ENOMEM)) {
+ // Add extra space in case threads are added before next call.
+ kp.resize((len / sizeof(struct kinfo_proc)) + 10);
----------------
Isn't this call always synchronous and all the threads are stopped?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90298/new/
https://reviews.llvm.org/D90298
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
