[Lldb-commits] [lldb] 48acece - [lldb][NFC] Cleanup ClangASTImporter::LayoutInfo

Author: Raphael Isemann Date: 2020-01-31T09:06:09+01:00 New Revision: 48acece15dcf63cb4fee043a4e66ddf3917a359a URL: https://github.com/llvm/llvm-project/commit/48acece15dcf63cb4fee043a4e66ddf3917a359a DIFF: https://github.com/llvm/llvm-project/commit/48acece15dcf63cb4fee043a4e66ddf3917a359a.dif

[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

labath added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2041 void ValueObject::GetExpressionPath(Stream &s, bool qualify_cxx_base_classes, GetExpressionPathFormat epformat) { xiaobai wrote: > labath wrote

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks good to me, and I believe everyone else also felt the same way. There are still some loops here (TypeSystemClang<->SymbolFileDWARF/PDB), but I think those could be broken fairly eas

[Lldb-commits] [lldb] 46ca55f - [lldb][NFC] Add safe Decl->CompilerDecl conversion function TypeSystemClang

Author: Raphael Isemann Date: 2020-01-31T09:44:24+01:00 New Revision: 46ca55f2a2c88609657dff7f49ec54d5a71032d3 URL: https://github.com/llvm/llvm-project/commit/46ca55f2a2c88609657dff7f49ec54d5a71032d3 DIFF: https://github.com/llvm/llvm-project/commit/46ca55f2a2c88609657dff7f49ec54d5a71032d3.dif

[Lldb-commits] [PATCH] D73767: [lldb] [test] Respect LLVM_LIBDIR_SUFFIX when linking liblldb

mgorny created this revision. mgorny added reviewers: labath, beanz. Pass LLVM_LIBDIR_SUFFIX over to dotest, and append it to 'lib' when linking liblldb. This fixes link failures when tests are run within stand-alone builds on systems where LLVM_LIBDIR_SUFFIX is not empty. https://reviews.llvm.

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

labath accepted this revision. labath added a comment. In D73594#1851044 , @clayborg wrote: > Looks reasonable to me. Any objections from anyone else? We do have tests for > this right? LGTM too. There are tests for this command already, but of course,

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

anton.kolesov added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/target/set-exec/TestSetExecutable.py:16 +"""Test adding images to the target.""" +self.build() + clayborg wrote: > Create a yaml file and put it in the

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

labath added a comment. In D73279#1851068 , @jankratochvil wrote: > But then maybe it also needs: > > # Our current version of gtest does not properly recognize C++11 support > # with MSVC, so it falls back to tr1 / experimental classes. Since LLVM >

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks great, modulo the inline comment. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3987-4008 + DWARFASTParser *dwarf_ast = GetDWARFParser(*die.GetC

[Lldb-commits] [PATCH] D73766: [RFC] Make substrs argument to self.expect ordered by default.

labath added a comment. I think this is great, but do we really need the extra `ordered` argument for this? If you just fix the order of everything beforehand, then the switch to an ordered mode can be a no-op. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73766/new/ https://reviews.l

[Lldb-commits] [lldb] 99e63f5 - [lldb] Print the command output when 'expect' fails even if a custom msg is passed

Author: Raphael Isemann Date: 2020-01-31T10:16:46+01:00 New Revision: 99e63f5825ac30912bab1daa563cae9e6c292d52 URL: https://github.com/llvm/llvm-project/commit/99e63f5825ac30912bab1daa563cae9e6c292d52 DIFF: https://github.com/llvm/llvm-project/commit/99e63f5825ac30912bab1daa563cae9e6c292d52.dif

[Lldb-commits] [PATCH] D73766: [RFC] Make substrs argument to self.expect ordered by default.

teemperor added a comment. FWIW I'm currently going over the failing tests and fixing them, so unless I find a test that actually needs unordered subsets I don't think having the parameter makes sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73766/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D73767: [lldb] [test] Respect LLVM_LIBDIR_SUFFIX when linking liblldb

labath added a comment. If we go down this path, then I think we should just pass the full path to the lib directory, and remove all the code which tries to autodetect it. But if you're looking for a quick fix, I think adding "netbsd" to the list of operating systems at dotest.py:625 should fix

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/target/set-exec/TestSetExecutable.py:16 +"""Test adding images to the target.""" +self.build() + anton.kolesov wrote: > clayborg wrote: > > Create a yaml file

[Lldb-commits] [PATCH] D73767: [lldb] [test] Respect LLVM_LIBDIR_SUFFIX when linking liblldb

mgorny added a comment. I'm actually trying to make 10.0.0 a little less broken for Gentoo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73767/new/ https://reviews.llvm.org/D73767 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D73767: [lldb] [test] Respect LLVM_LIBDIR_SUFFIX when linking liblldb

labath added a comment. Aha, I see. Could you then simply pass LLDB_LIBS_DIR instead of just the suffix? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73767/new/ https://reviews.llvm.org/D73767 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D73767: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb

mgorny updated this revision to Diff 241672. mgorny retitled this revision from "[lldb] [test] Respect LLVM_LIBDIR_SUFFIX when linking liblldb" to "[lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb". mgorny edited the summary of this revision. mgorny added a comment. The question i

[Lldb-commits] [lldb] 19f1ce6 - [lldb][NFC] Remove ParserVars::m_parser_type member that was never read

Author: Raphael Isemann Date: 2020-01-31T12:54:01+01:00 New Revision: 19f1ce67353c197ab86039bcc15c3ebca02cbaea URL: https://github.com/llvm/llvm-project/commit/19f1ce67353c197ab86039bcc15c3ebca02cbaea DIFF: https://github.com/llvm/llvm-project/commit/19f1ce67353c197ab86039bcc15c3ebca02cbaea.dif

[Lldb-commits] [lldb] 1ccc702 - [lldb][NFC] Remove unnecessary ClangASTImporter checks in ClangASTSource

Author: Raphael Isemann Date: 2020-01-31T13:17:08+01:00 New Revision: 1ccc702912fa9c41a58b9007807780a0dcb07707 URL: https://github.com/llvm/llvm-project/commit/1ccc702912fa9c41a58b9007807780a0dcb07707 DIFF: https://github.com/llvm/llvm-project/commit/1ccc702912fa9c41a58b9007807780a0dcb07707.dif

[Lldb-commits] [lldb] 09217b6 - [lldb][NFC] Add a CompilerDecl->clang::Decl conversion function to ClangUtil

Author: Raphael Isemann Date: 2020-01-31T13:20:02+01:00 New Revision: 09217b60fcf1301e0333a69c37c6408d81c46ca5 URL: https://github.com/llvm/llvm-project/commit/09217b60fcf1301e0333a69c37c6408d81c46ca5 DIFF: https://github.com/llvm/llvm-project/commit/09217b60fcf1301e0333a69c37c6408d81c46ca5.dif

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

anton.kolesov added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/target/set-exec/TestSetExecutable.py:16 +"""Test adding images to the target.""" +self.build() + labath wrote: > anton.kolesov wrote: > > clayborg wrote

[Lldb-commits] [PATCH] D73767: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb

labath added a comment. In D73767#1851418 , @mgorny wrote: > The question is, does this break any of the platform hacks? ;-) I think it /may/ break one. See inline comment. BTW, I think the best way to clean a lot of this up would be to take the tests

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

labath requested changes to this revision. labath added a comment. Hmm... now that I actually have read what this patch does, I am starting to think that this is not a good idea: - on linux it was possible to load an executable via "dlopen", at least until last year, when it was (partially?) di

[Lldb-commits] [lldb] 877963a - [lldb/DWARF] Delete some dead code in SymbolFileDWARF

Author: Pavel Labath Date: 2020-01-31T14:47:25+01:00 New Revision: 877963a35a0405576fc805d5b5087619e14e9f5f URL: https://github.com/llvm/llvm-project/commit/877963a35a0405576fc805d5b5087619e14e9f5f DIFF: https://github.com/llvm/llvm-project/commit/877963a35a0405576fc805d5b5087619e14e9f5f.diff

[Lldb-commits] [PATCH] D73781: [lldb/DWARF] Don't assume that a SymbolFileDWARFDwo contains one compile unit

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a subscriber: arphaman. Herald added a project: LLDB. labath added a child revision: D73782: [lldb/DWARF] Don't hold a unique SymbolFileDWARFDwo in a DWARFUnit. This is a preparatory patch to re-en

[Lldb-commits] [PATCH] D73782: [lldb/DWARF] Don't hold a unique SymbolFileDWARFDwo in a DWARFUnit

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. labath added a parent revision: D73781: [lldb/DWARF] Don't assume that a SymbolFileDWARFDwo contains one compile unit. labath added a child revis

[Lldb-commits] [PATCH] D73783: [lldb/DWARF] Re-enable basic dwp support

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added subscribers: mgrang, mgorny. Herald added a project: LLDB. labath added a parent revision: D73782: [lldb/DWARF] Don't hold a unique SymbolFileDWARFDwo in a DWARFUnit. This patch removes the bitrott

[Lldb-commits] [lldb] 789beee - [lldb] Move non-DWARF code: DWARFUnit -> SymbolFileDWARF

Author: Jan Kratochvil Date: 2020-01-31T15:16:31+01:00 New Revision: 789beeeca3cdeecc00cd731c940e52effdd7c7df URL: https://github.com/llvm/llvm-project/commit/789beeeca3cdeecc00cd731c940e52effdd7c7df DIFF: https://github.com/llvm/llvm-project/commit/789beeeca3cdeecc00cd731c940e52effdd7c7df.diff

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

This revision was automatically updated to reflect the committed changes. Closed by commit rG789beeeca3cd: [lldb] Move non-DWARF code: DWARFUnit -> SymbolFileDWARF (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D70646?vs=241634&id=241715#toc Repository: rG LLV

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

jankratochvil marked 2 inline comments as done. jankratochvil added a comment. Checked in, thanks for the review. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3987-4008 + DWARFASTParser *dwarf_ast = GetDWARFParser(*die.GetCU()); + if (dwarf_ast) +r

[Lldb-commits] [lldb] b8966de - [lldb] Remove some dead code from SharingPtr.h

Author: Pavel Labath Date: 2020-01-31T15:46:41+01:00 New Revision: b8966de73f1c7c6b7d585ce4f3ed171d121328ae URL: https://github.com/llvm/llvm-project/commit/b8966de73f1c7c6b7d585ce4f3ed171d121328ae DIFF: https://github.com/llvm/llvm-project/commit/b8966de73f1c7c6b7d585ce4f3ed171d121328ae.diff

[Lldb-commits] [lldb] 33f65f3 - [lldb] Add a basic unit test for the SharedCluster class

Author: Pavel Labath Date: 2020-01-31T15:46:41+01:00 New Revision: 33f65f393f6652a0974582f7b13a9aa38a9929a3 URL: https://github.com/llvm/llvm-project/commit/33f65f393f6652a0974582f7b13a9aa38a9929a3 DIFF: https://github.com/llvm/llvm-project/commit/33f65f393f6652a0974582f7b13a9aa38a9929a3.diff

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil marked 2 inline comments as done. jankratochvil added a comment. In D73279#1851201 , @labath wrote: > That might explain the warnings I have seen when building with msvc the other > day. It might good to add those too. Added. ==

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil updated this revision to Diff 241721. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73279/new/ https://reviews.llvm.org/D73279 Files: lldb/unittests/Expression/DWARFExpressionTest.cpp lldb/unittests/SymbolFile/DWARF/DWARFASTParserC

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

jankratochvil marked an inline comment as done. jankratochvil added a comment. This commit broke: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/7400/ Going to revert the return value refactorization. That `DWARFDebugInfoEntry::GetDWARFDeclContext()` refactorization for return value was

[Lldb-commits] [lldb] 6dd0163 - [lldb] Revert refactorization from: Move non-DWARF code: DWARFUnit -> SymbolFileDWARF

Author: Jan Kratochvil Date: 2020-01-31T16:06:23+01:00 New Revision: 6dd0163502ff8c48195643b2b08a123c495743a0 URL: https://github.com/llvm/llvm-project/commit/6dd0163502ff8c48195643b2b08a123c495743a0 DIFF: https://github.com/llvm/llvm-project/commit/6dd0163502ff8c48195643b2b08a123c495743a0.diff

[Lldb-commits] [PATCH] D73767: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1680 self.dylibPath] if self.dylibPath in os.environ else None -lib_dir = os.environ["LLDB_LIB_DIR"] +lib_dir = configur

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

jankratochvil added a comment. Reverted the refactorization by: https://github.com/llvm/llvm-project/commit/6dd0163502ff8c48195643b2b08a123c495743a0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70646/new/ https://reviews.llvm.org/D70646 __

[Lldb-commits] [PATCH] D73767: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb

mgorny updated this revision to Diff 241728. mgorny added a comment. Removed the aforementioned chunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73767/new/ https://reviews.llvm.org/D73767 Files: lldb/packages/Python/lldbsuite/test/configuration.py lldb/packages/Python/lldbsuite

[Lldb-commits] [lldb] edc3f4f - [NFC] [lldb] Unindent DWARFDebugInfoEntry::GetDWARFDeclContext

Author: Jan Kratochvil Date: 2020-01-31T16:51:33+01:00 New Revision: edc3f4f02e54c2ae1067f60f6a0ed6caf5b92ef6 URL: https://github.com/llvm/llvm-project/commit/edc3f4f02e54c2ae1067f60f6a0ed6caf5b92ef6 DIFF: https://github.com/llvm/llvm-project/commit/edc3f4f02e54c2ae1067f60f6a0ed6caf5b92ef6.diff

[Lldb-commits] [PATCH] D73787: [NFC] Refactor `GetDWARFDeclContext` to return `DWARFDeclContext`

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. Herald added a subscriber: aprantl. Herald added a reviewer: shafik. In D70646 I broke http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/7400/

[Lldb-commits] [PATCH] D73766: [RFC] Make substrs argument to self.expect ordered by default.

JDevlieghere added a comment. In D73766#1851224 , @teemperor wrote: > FWIW I'm currently going over the failing tests and fixing them, so unless I > find a test that actually needs unordered subsets I don't think having the > parameter makes sense. Yep

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

shafik added a comment. Making this a plugin makes sense. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73661/new/ https://reviews.llvm.org/D73661 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] 6c7efe2 - [lldb][NFC] Fix expect calls with wrong order of 'substrs' items for D73766

Author: Raphael Isemann Date: 2020-01-31T17:54:18+01:00 New Revision: 6c7efe2eecf1495d2416ebc485025859d9dee74a URL: https://github.com/llvm/llvm-project/commit/6c7efe2eecf1495d2416ebc485025859d9dee74a DIFF: https://github.com/llvm/llvm-project/commit/6c7efe2eecf1495d2416ebc485025859d9dee74a.dif

[Lldb-commits] [PATCH] D73148: [lldb/Value] Avoid reading more data than the host has available

shafik added a comment. In D73148#1850978 , @vsk wrote: > Yikes, this version seems to break TestClassTemplateParameterPack.py (and > probably other tests as well). Maybe we expect to be able to read past the > end of the buffer inside of a ValueObjectCh

[Lldb-commits] [PATCH] D73781: [lldb/DWARF] Don't assume that a SymbolFileDWARFDwo contains one compile unit

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. DWO is not really my area of expertise but this looks pretty straightforward. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwoDwp.cpp:29 +:

[Lldb-commits] [lldb] 2c19d05 - [lldb/Test] Fix substrs order in self.expect for more tests (NFC)

Author: Jonas Devlieghere Date: 2020-01-31T10:29:33-08:00 New Revision: 2c19d05ae91e263585cd4633788d83563e67157a URL: https://github.com/llvm/llvm-project/commit/2c19d05ae91e263585cd4633788d83563e67157a DIFF: https://github.com/llvm/llvm-project/commit/2c19d05ae91e263585cd4633788d83563e67157a.d

[Lldb-commits] [PATCH] D73782: [lldb/DWARF] Don't hold a unique SymbolFileDWARFDwo in a DWARFUnit

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:56 +return nullptr; + if (hash != cu->GetUnitDIEOnly().GetAttributeValueAsUnsigned(DW_AT_GNU_dwo_id, 0)) +return nullptr; How often does this functio

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

clayborg accepted this revision. clayborg added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73661/new/ https://reviews.llvm.org/D73661 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D73766: [RFC] Make substrs argument to self.expect ordered by default.

jingham added a comment. The current behavior does make tests less dependent on the exact details of lldb's command output. If there were two independent pieces of data in a command output that you wanted to compare against, you would have to fix some tests if you ever changed the ordering in

[Lldb-commits] [lldb] 574685b - [lldb/Symbol] Use StringRef ctor to prevent incorrect overload

Author: Jonas Devlieghere Date: 2020-01-31T11:00:46-08:00 New Revision: 574685b879acff462faa1e5e480825033c589778 URL: https://github.com/llvm/llvm-project/commit/574685b879acff462faa1e5e480825033c589778 DIFF: https://github.com/llvm/llvm-project/commit/574685b879acff462faa1e5e480825033c589778.d

[Lldb-commits] [PATCH] D73783: [lldb/DWARF] Re-enable basic dwp support

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73783/new/ https://reviews.llvm.org/D73783 ___

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

aprantl added a comment. I like the direction! Comment at: lldb/unittests/TestingSupport/Symbol/YAMLModuleTester.cpp:1 +//===- YAMLModuleTester.cpp -*- C++ -*-===// +// Nit: the `-*- C++ -*-` only makes sense in a .h file wh

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil updated this revision to Diff 241784. jankratochvil marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73279/new/ https://reviews.llvm.org/D73279 Files: lldb/unittests/Expression/DWARFExpressionTest.cpp

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil marked 8 inline comments as done. jankratochvil added inline comments. Comment at: lldb/unittests/TestingSupport/Symbol/YAMLModuleTester.h:24 +class YAMLModuleTester { + // SubsystemRAII subsystems; + SubsystemRAII subsystems; aprantl wrote: > ?

[Lldb-commits] [lldb] 8be3021 - [lldb] Move clang-based files out of Symbol

Author: Alex Langford Date: 2020-01-31T12:20:10-08:00 New Revision: 8be30215feeff1d82fe2bde0c9fb0e6cd1bfc15c URL: https://github.com/llvm/llvm-project/commit/8be30215feeff1d82fe2bde0c9fb0e6cd1bfc15c DIFF: https://github.com/llvm/llvm-project/commit/8be30215feeff1d82fe2bde0c9fb0e6cd1bfc15c.diff

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

This revision was automatically updated to reflect the committed changes. Closed by commit rG8be30215feef: [lldb] Move clang-based files out of Symbol (authored by xiaobai). Changed prior to commit: https://reviews.llvm.org/D73661?vs=241584&id=241791#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 81b0bec - [lldb/Test] Fix substrs order in self.expect for more tests (NFC)

Author: Jonas Devlieghere Date: 2020-01-31T12:44:24-08:00 New Revision: 81b0becaaee65fa5342eca6c2dc7855852a92372 URL: https://github.com/llvm/llvm-project/commit/81b0becaaee65fa5342eca6c2dc7855852a92372 DIFF: https://github.com/llvm/llvm-project/commit/81b0becaaee65fa5342eca6c2dc7855852a92372.d

[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Introduce support for i386 platform that is shared with amd64 in the same plugin. The concept is partially based on the Linux implementation. The plugin tries to reuse as much code as possible. As a result, i386 register

[Lldb-commits] [lldb] d02fb00 - [lldb/Test] Make substrs argument to self.expect ordered.

Author: Jonas Devlieghere Date: 2020-01-31T13:35:37-08:00 New Revision: d02fb002dd6b57e2ecbc3a4c3df91f5ed3a6054e URL: https://github.com/llvm/llvm-project/commit/d02fb002dd6b57e2ecbc3a4c3df91f5ed3a6054e DIFF: https://github.com/llvm/llvm-project/commit/d02fb002dd6b57e2ecbc3a4c3df91f5ed3a6054e.d

[Lldb-commits] [PATCH] D73766: [RFC] Make substrs argument to self.expect ordered by default.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd02fb002dd6b: [lldb/Test] Make substrs argument to self.expect ordered. (authored by JDevlieghere). Changed prior to comm

[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextNetBSD_i386.cpp:62 + GPR gpr; + FPR_i386 i387; + uint32_t u_debugreg[8]; // Debug registers (DR0 - DR7). Please add `uint32_t tlsbase;`. CHANGES SINCE LAST ACT

[Lldb-commits] [lldb] 6f2a4c4 - Revert "[lldb/Test] Make substrs argument to self.expect ordered."

Author: Jonas Devlieghere Date: 2020-01-31T13:50:39-08:00 New Revision: 6f2a4c424e14e2564c64450d9416036ebe97b260 URL: https://github.com/llvm/llvm-project/commit/6f2a4c424e14e2564c64450d9416036ebe97b260 DIFF: https://github.com/llvm/llvm-project/commit/6f2a4c424e14e2564c64450d9416036ebe97b260.d

[Lldb-commits] [PATCH] D73148: [lldb/Value] Avoid reading more data than the host has available

vsk updated this revision to Diff 241814. vsk edited the summary of this revision. vsk added a comment. - Go with @gclayton's original suggestion, as it's proven to be impractical to alter the notion of a Value's size in the Value/ValueObject logic. - I've tested this and gotten a clean check-lld

[Lldb-commits] [lldb] d3bdd51 - [lldb/Platform] Always print Kernel last

Author: Jonas Devlieghere Date: 2020-01-31T14:36:39-08:00 New Revision: d3bdd51f70449435443b3e8ff254cba49d4aba80 URL: https://github.com/llvm/llvm-project/commit/d3bdd51f70449435443b3e8ff254cba49d4aba80 DIFF: https://github.com/llvm/llvm-project/commit/d3bdd51f70449435443b3e8ff254cba49d4aba80.d

[Lldb-commits] [PATCH] D73808: [lldb/ClangASTContext] Supply trivial TypeSourceInfo to NonTypeTemplateParmDecl::Create

vsk created this revision. vsk added reviewers: teemperor, shafik. Herald added a subscriber: kristof.beyls. This fixes a UBSan error seen while debugging clang: Member call on null pointer of type 'clang::TypeSourceInfo' rdar://58783517 https://reviews.llvm.org/D73808 Files: lldb/packages

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev updated this revision to Diff 241824. paolosev marked 2 inline comments as done. paolosev added a comment. Fixed the tests as suggested, and also added a couple more tests, to cover both the case where the Wasm module is loaded from memory and the case where it is loaded from a file. >

[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

amccarth added a comment. In D73589#1845971 , @jasonmolenda wrote: > Looks good, for the --shlib option I would get rid of the "full path or base > name" language and just say "name", my two cents. I agree just "name" seems fine. Done. CHANGES SINCE

[Lldb-commits] [lldb] 8e36d24 - [lldb] Remove unused CPPLanguageRuntime dependency

Author: Alex Langford Date: 2020-01-31T15:23:18-08:00 New Revision: 8e36d24fca9f4586bcde588a10c8892ff62e1ff5 URL: https://github.com/llvm/llvm-project/commit/8e36d24fca9f4586bcde588a10c8892ff62e1ff5 DIFF: https://github.com/llvm/llvm-project/commit/8e36d24fca9f4586bcde588a10c8892ff62e1ff5.diff

Re: [Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

> On Mar 5, 2019, at 5:07 PM, Adrian Prantl via lldb-commits > wrote: > > Author: adrian > Date: Tue Mar 5 17:07:45 2019 > New Revision: 355466 > > URL: http://llvm.org/viewvc/llvm-project?rev=355466&view=rev > Log: > Replace debug-only assert with a plain old assert. > > Modified: >lld

Re: [Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

This could be the known bug where a CommandObject is scheduled while the same CommandObject is already deeper on the command stack. I tried digging up the bugreport for that, but I couldn't find it. -- adrian > On Jan 31, 2020, at 3:59 PM, Vedant Kumar wrote: > > > >> On Mar 5, 2019, at 5:0

Re: [Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

Interesting. I'll keep poking at this. > On Jan 31, 2020, at 4:04 PM, Adrian Prantl via lldb-commits > wrote: > > This could be the known bug where a CommandObject is scheduled while the same > CommandObject is already deeper on the command stack. I tried digging up the > bugreport for that,

[Lldb-commits] [lldb] 009e3e5 - [lldb/MCDisasm] Simplify predicates in MCDisasmInstance, NFC

Author: Vedant Kumar Date: 2020-01-31T16:33:12-08:00 New Revision: 009e3e53c1fe4848916a3b7de1dff60a2644fa46 URL: https://github.com/llvm/llvm-project/commit/009e3e53c1fe4848916a3b7de1dff60a2644fa46 DIFF: https://github.com/llvm/llvm-project/commit/009e3e53c1fe4848916a3b7de1dff60a2644fa46.diff

[Lldb-commits] [lldb] 14135f5 - [lldb/Value] Avoid reading more data than the host has available

Author: Vedant Kumar Date: 2020-01-31T16:33:12-08:00 New Revision: 14135f50a036af4d3a64b8e2e0dc2ecda5260533 URL: https://github.com/llvm/llvm-project/commit/14135f50a036af4d3a64b8e2e0dc2ecda5260533 DIFF: https://github.com/llvm/llvm-project/commit/14135f50a036af4d3a64b8e2e0dc2ecda5260533.diff

[Lldb-commits] [PATCH] D73148: [lldb/Value] Avoid reading more data than the host has available

This revision was automatically updated to reflect the committed changes. Closed by commit rG14135f50a036: [lldb/Value] Avoid reading more data than the host has available (authored by vsk). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D73148?vs=241814&id=2418

Re: [Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

That shouldn't be ASAN specific, that should happen on and LLDB_CONFIGURATION_DEBUG build. If it only happens on ASAN builds, something else must be going wrong. BTW, those asserts only make sense if you can't re-enter the command interpreter while a command is active. In the case of a comman

Re: [Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

> On Jan 31, 2020, at 4:53 PM, Jim Ingham wrote: > > That shouldn't be ASAN specific, that should happen on and > LLDB_CONFIGURATION_DEBUG build. If it only happens on ASAN builds, something > else must be going wrong. > > BTW, those asserts only make sense if you can't re-enter the command

[Lldb-commits] [lldb] c62ffb1 - [lldb/Reproducers] Include string length in string (de)serialization.

Author: Jonas Devlieghere Date: 2020-01-31T17:40:49-08:00 New Revision: c62ffb1b192daa66a8602d1511e04fb31809ffbe URL: https://github.com/llvm/llvm-project/commit/c62ffb1b192daa66a8602d1511e04fb31809ffbe DIFF: https://github.com/llvm/llvm-project/commit/c62ffb1b192daa66a8602d1511e04fb31809ffbe.d

[Lldb-commits] [lldb] 2637769 - [lldb] Remove LanguageRuntime::GetOverrideExprOptions

Author: Alex Langford Date: 2020-01-31T22:05:23-08:00 New Revision: 2637769b9f38010082276b7b839a17b102d1ac93 URL: https://github.com/llvm/llvm-project/commit/2637769b9f38010082276b7b839a17b102d1ac93 DIFF: https://github.com/llvm/llvm-project/commit/2637769b9f38010082276b7b839a17b102d1ac93.diff

[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextNetBSD_i386.cpp:62 + GPR gpr; + FPR_i386 i387; + uint32_t u_debugreg[8]; // Debug registers (DR0 - DR7). krytarowski wrote: >

[Lldb-commits] [PATCH] D73827: [lldb] Delete ClangForward.h

xiaobai created this revision. xiaobai added a reviewer: LLDB. Herald added subscribers: usaxena95, arphaman. Herald added a project: LLDB. I think that there are very few things from clang that actually need forward declaration, so not having a ClangForward header makes sense. Repository: rG