mgorny marked an inline comment as done.
mgorny added inline comments.
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1680
self.dylibPath] if self.dylibPath in os.environ else None
- lib_dir = os.environ["LLDB_LIB_DIR"]
+ lib_dir = configuration.lldb_libs_dir
if existing_library_path:
----------------
labath wrote:
> I'm not sure if this is right, because (despite the name) `LLDB_LIB_DIR`
> points to the "bin" dir. But then again, this whole function seems pretty
> wrong, so it's hard to say what should it really do here.
>
> If you don't need this part (the previous patch didn't have it) and want to
> make this safe-ish for cherry-picking, maybe you could leave this part out
> for now.
Ok, I'll do a second run and see if the result changes without it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73767/new/
https://reviews.llvm.org/D73767
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
