clayborg added inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:56
+ return nullptr;
+ if (hash !=
cu->GetUnitDIEOnly().GetAttributeValueAsUnsigned(DW_AT_GNU_dwo_id, 0))
+ return nullptr;
----------------
How often does this function get called? Should we cache the DW_AT_GNU_dwo_id
in the DWARFCompileUnit to avoid extracting the DW_AT_GNU_dwo_id attribute
maybe multiple times?
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h:67
SymbolFileDWARF &GetBaseSymbolFile() { return m_base_symbol_file; }
+ DWARFCompileUnit *FindSingleCompileUnit();
----------------
Curious: what is a single compile unit? A bit of a comment in header doc here
might be nice.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73782/new/
https://reviews.llvm.org/D73782
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
