[Lldb-commits] [lldb] r345127 - [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (.debug_rnglists)

2019-10-04 Thread George Rimar via lldb-commits
Author: grimar Date: Wed Oct 24 02:56:20 2018 New Revision: 345127 URL: http://llvm.org/viewvc/llvm-project?rev=345127&view=rev Log: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (.debug_rnglists) The patch implements the support for DW_RLE_base_address and DW_RLE_o

[Lldb-commits] [lldb] r342153 - [LLDB] - Improved DWARF5 support.

2019-10-04 Thread George Rimar via lldb-commits
Author: grimar Date: Thu Sep 13 10:06:47 2018 New Revision: 342153 URL: http://llvm.org/viewvc/llvm-project?rev=342153&view=rev Log: [LLDB] - Improved DWARF5 support. This patch improves the support of DWARF5. Particularly the reporting of source code locations. Differential revision: https://re

[Lldb-commits] [lldb] r353161 - [Expressions] Fix -Wreorder warning from r353149

2019-10-04 Thread Krasimir Georgiev via lldb-commits
Author: krasimir Date: Tue Feb 5 03:35:45 2019 New Revision: 353161 URL: http://llvm.org/viewvc/llvm-project?rev=353161&view=rev Log: [Expressions] Fix -Wreorder warning from r353149 Summary: ``` ClangExpressionDeclMap.cpp:72:60: error: field 'm_struct_vars' will be initialized after field 'm_c

[Lldb-commits] [lldb] r359120 - [lldb] Use local definition of get_cpuid_count

2019-10-04 Thread Joseph Tremoulet via lldb-commits
Author: josepht Date: Wed Apr 24 11:00:12 2019 New Revision: 359120 URL: http://llvm.org/viewvc/llvm-project?rev=359120&view=rev Log: [lldb] Use local definition of get_cpuid_count Summary: This is needed for gcc/cstdlib++ 5.4.0, where __get_cpuid_count is not defined in cpuid.h. Reviewers: laba

[Lldb-commits] [lldb] r344328 - [LLDB] - Add support for DW_FORM_implicit_const.

2019-10-04 Thread George Rimar via lldb-commits
Author: grimar Date: Fri Oct 12 02:46:15 2018 New Revision: 344328 URL: http://llvm.org/viewvc/llvm-project?rev=344328&view=rev Log: [LLDB] - Add support for DW_FORM_implicit_const. LLDB does not support this DWARF5 form atm. At least gcc emits it in some cases when doing optimization for abbrevi

[Lldb-commits] [lldb] r346841 - Suppress a "-Wliteral-conversion" compiler warning.

2019-10-04 Thread Haojian Wu via lldb-commits
Author: hokein Date: Wed Nov 14 01:53:45 2018 New Revision: 346841 URL: http://llvm.org/viewvc/llvm-project?rev=346841&view=rev Log: Suppress a "-Wliteral-conversion" compiler warning. error: implicit conversion from 'double' to 'uint64_t' (aka 'unsigned long') changes value from -0 to 0 [-Werro

[Lldb-commits] [lldb] r344722 - Revert "Return a named error in the result object of an expression with no result"

2019-10-04 Thread Krasimir Georgiev via lldb-commits
Author: krasimir Date: Wed Oct 17 20:10:43 2018 New Revision: 344722 URL: http://llvm.org/viewvc/llvm-project?rev=344722&view=rev Log: Revert "Return a named error in the result object of an expression with no result" This reverts commit r344647. This causes build failures with [-Werror, -Wswitc

[Lldb-commits] [lldb] r345157 - Revert rL345127: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries

2019-10-04 Thread George Rimar via lldb-commits
Author: grimar Date: Wed Oct 24 09:21:56 2018 New Revision: 345157 URL: http://llvm.org/viewvc/llvm-project?rev=345157&view=rev Log: Revert rL345127: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries It broke BB: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/

[Lldb-commits] [lldb] r346839 - Fix the "make_unique is ambiguous" compiler error.

2019-10-04 Thread Haojian Wu via lldb-commits
Author: hokein Date: Wed Nov 14 01:42:28 2018 New Revision: 346839 URL: http://llvm.org/viewvc/llvm-project?rev=346839&view=rev Log: Fix the "make_unique is ambiguous" compiler error. Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/trunk/source/Utility/Rep

[Lldb-commits] [lldb] r373668 - [lldb] Calculate relative path for symbol links

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Thu Oct 3 14:52:20 2019 New Revision: 373668 URL: http://llvm.org/viewvc/llvm-project?rev=373668&view=rev Log: [lldb] Calculate relative path for symbol links Summary: This replaces the hard coded path. Reviewers: labath, mgorny Subscribers: lldb-commits Tags: #lldb Differe

[Lldb-commits] [lldb] r368125 - Detect HAVE_SYS_TYPES_H in lldb

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Tue Aug 6 23:15:01 2019 New Revision: 368125 URL: http://llvm.org/viewvc/llvm-project?rev=368125&view=rev Log: Detect HAVE_SYS_TYPES_H in lldb Summary: After rL368069 I noticed that HAVE_SYS_TYPES_H is not defined in Platform.h, or anywhere else in lldb. This change fixes that.

[Lldb-commits] [lldb] r368352 - [lldb] Fix HAVE_LIBCOMPRESSION

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Thu Aug 8 14:42:33 2019 New Revision: 368352 URL: http://llvm.org/viewvc/llvm-project?rev=368352&view=rev Log: [lldb] Fix HAVE_LIBCOMPRESSION Summary: This test doesn't make sense. Change to be consistent with what we did in GDBRemoteCommunication.cpp. Reviewers: labath Subsc

[Lldb-commits] [lldb] r372895 - [lldb] Move swig call from python code to cmake

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Wed Sep 25 09:37:11 2019 New Revision: 372895 URL: http://llvm.org/viewvc/llvm-project?rev=372895&view=rev Log: [lldb] Move swig call from python code to cmake Summary: Elimiates lots of unused code. Reviewers: labath, mgorny Subscribers: lldb-commits Tags: #lldb Differentia

[Lldb-commits] [lldb] r368496 - Detects whether RESOURCE_TYPE_IO is defined.

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Fri Aug 9 15:47:46 2019 New Revision: 368496 URL: http://llvm.org/viewvc/llvm-project?rev=368496&view=rev Log: Detects whether RESOURCE_TYPE_IO is defined. Summary: This fixes lldb build on macOS SDK prior to 10.12. Reviewers: JDevlieghere Subscribers: lldb-commits Tags: #ll

Re: [Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

2019-10-04 Thread Guilherme Andrade via lldb-commits
Thank you for the suggestion, Jason! The feature is like this https://docs.microsoft.com/en-us/visualstudio/debugger/how-to-use-the-registers-window?view=vs-2019 - the user can select the register sets they want to see. There's an extra complication, though. I am using the C++ API, so I actually ge

[Lldb-commits] [lldb] r372194 - Cache PYTHON_EXECUTABLE for windows

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Tue Sep 17 18:00:12 2019 New Revision: 372194 URL: http://llvm.org/viewvc/llvm-project?rev=372194&view=rev Log: Cache PYTHON_EXECUTABLE for windows Summary: This way it can be overwritten when cross compiling. Subscribers: mgorny, lldb-commits Tags: #lldb Differential Revisio

[Lldb-commits] [lldb] r372364 - Revert "Fix swig python package path"

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Thu Sep 19 17:45:26 2019 New Revision: 372364 URL: http://llvm.org/viewvc/llvm-project?rev=372364&view=rev Log: Revert "Fix swig python package path" Summary: This reverts commit 5a115e81cdd40c758b10c382aeffc0c8de6930e2. Reviewers: JDevlieghere, ZeGentzy Subscribers: mgorny, l

[Lldb-commits] [lldb] r367273 - [CMake] Move project() call to main CMake file

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Mon Jul 29 16:09:31 2019 New Revision: 367273 URL: http://llvm.org/viewvc/llvm-project?rev=367273&view=rev Log: [CMake] Move project() call to main CMake file Summary: The main CMake file don't have a project() call. In this case, cmake will run a dummy project(Project ) at the

[Lldb-commits] [lldb] r366325 - [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

2019-10-04 Thread Gabor Marton via lldb-commits
Author: martong Date: Wed Jul 17 06:47:46 2019 New Revision: 366325 URL: http://llvm.org/viewvc/llvm-project?rev=366325&view=rev Log: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src Summary: With LLDB we use localUncachedLookup(), however, that fails to find Decls when a transpa

[Lldb-commits] [lldb] r368033 - Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5)

2019-10-04 Thread Igor Kudrin via lldb-commits
Author: ikudrin Date: Tue Aug 6 06:38:27 2019 New Revision: 368033 URL: http://llvm.org/viewvc/llvm-project?rev=368033&view=rev Log: Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5) Differential Revision: https://reviews.llvm.org/D65640 Modified: lldb/trunk/source/Plu

[Lldb-commits] [lldb] r372112 - lldb: move a test input to the test Inputs dir

2019-10-04 Thread Krasimir Georgiev via lldb-commits
Author: krasimir Date: Tue Sep 17 05:23:03 2019 New Revision: 372112 URL: http://llvm.org/viewvc/llvm-project?rev=372112&view=rev Log: lldb: move a test input to the test Inputs dir Summary: This makes the input file for a new test added in r372060 directly available in the Inputs subdirectory of

[Lldb-commits] [lldb] r367618 - [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

2019-10-04 Thread Harlan Haskins via lldb-commits
Author: harlanhaskins Date: Thu Aug 1 14:32:04 2019 New Revision: 367618 URL: http://llvm.org/viewvc/llvm-project?rev=367618&view=rev Log: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure Summary: Currently, clang's FileManager uses NULL as an indicator that a particula

[Lldb-commits] [lldb] r361362 - Add AST logging

2019-10-04 Thread Gabor Marton via lldb-commits
Author: martong Date: Wed May 22 02:10:19 2019 New Revision: 361362 URL: http://llvm.org/viewvc/llvm-project?rev=361362&view=rev Log: Add AST logging Summary: Log the AST of the TU associated with LLDB's `expr` command, once a declaration is completed Reviewers: shafik Subscribers: rnkovacs, dk

[Lldb-commits] [lldb] r373669 - [lldb] Remove unused variables.

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Thu Oct 3 14:56:59 2019 New Revision: 373669 URL: http://llvm.org/viewvc/llvm-project?rev=373669&view=rev Log: [lldb] Remove unused variables. Fixes the comment in https://reviews.llvm.org/D67993 Modified: lldb/trunk/scripts/Python/finishSwigPythonLLDB.py Modified: lldb/t

[Lldb-commits] [lldb] r368069 - Various build fixes for lldb on MinGW

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Tue Aug 6 11:20:43 2019 New Revision: 368069 URL: http://llvm.org/viewvc/llvm-project?rev=368069&view=rev Log: Various build fixes for lldb on MinGW Subscribers: mstorsjo, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D65691 Modified: lldb/trun

Re: [Lldb-commits] D53140: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (.debug_rnglists)

2019-10-04 Thread George Rimar via lldb-commits
I'll revert it. Sorry for the breakage. Best regards, George | Developer | Access Softek, Inc От: Adrian Prantl via Phabricator Отправлено: 24 октября 2018 г. 18:50 Кому: George Rimar; jdevliegh...@apple.com; ted.woodw...@codeaurora.org; sgraen...@apple.com; jmo

[Lldb-commits] [lldb] r360146 - [lldb] Add MacroQualified switch cases for r360109

2019-10-04 Thread Krasimir Georgiev via lldb-commits
Author: krasimir Date: Tue May 7 06:59:30 2019 New Revision: 360146 URL: http://llvm.org/viewvc/llvm-project?rev=360146&view=rev Log: [lldb] Add MacroQualified switch cases for r360109 Summary: r360109 added a new enum case, causing lldb build to fail with several errors like: lldb/source/Symbo

[Lldb-commits] [lldb] r355989 - Add XCOFF triple object format type for AIX

2019-10-04 Thread Jason Liu via lldb-commits
Author: jasonliu Date: Tue Mar 12 15:01:10 2019 New Revision: 355989 URL: http://llvm.org/viewvc/llvm-project?rev=355989&view=rev Log: Add XCOFF triple object format type for AIX This patch adds an XCOFF triple object format type into LLVM. This XCOFF triple object file type will be used later by

[Lldb-commits] [lldb] r372493 - Use _WIN32 instead of _MSC_VER

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Sat Sep 21 18:21:34 2019 New Revision: 372493 URL: http://llvm.org/viewvc/llvm-project?rev=372493&view=rev Log: Use _WIN32 instead of _MSC_VER Summary: This way it works better with MinGW. Subscribers: mstorsjo, lldb-commits Tags: #lldb Differential Revision: https://reviews.

[Lldb-commits] [lldb] r371890 - [Support] Add overload writeFileAtomically(std::function Writer)

2019-10-04 Thread Jan Korous via lldb-commits
Author: jkorous Date: Fri Sep 13 13:08:27 2019 New Revision: 371890 URL: http://llvm.org/viewvc/llvm-project?rev=371890&view=rev Log: [Support] Add overload writeFileAtomically(std::function Writer) Differential Revision: https://reviews.llvm.org/D67424 Modified: lldb/trunk/tools/lldb-server

[Lldb-commits] [lldb] r372047 - Fix swig python package path

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Mon Sep 16 16:31:16 2019 New Revision: 372047 URL: http://llvm.org/viewvc/llvm-project?rev=372047&view=rev Log: Fix swig python package path Summary: The path defined in CMakeLists.txt doesn't match the path generated in our python script. This change fixes that. LLVM_LIBRARY_O

[Lldb-commits] [lldb] r367275 - [NFC] avoid AlignedCharArray in lldb

2019-10-04 Thread JF Bastien via lldb-commits
Author: jfb Date: Mon Jul 29 16:17:08 2019 New Revision: 367275 URL: http://llvm.org/viewvc/llvm-project?rev=367275&view=rev Log: [NFC] avoid AlignedCharArray in lldb As discussed in D65249, don't use AlignedCharArray or std::aligned_storage. Just use alignas(X) char Buf[Size];. This will allow

[Lldb-commits] [lldb] r372221 - [lldb] Fix a test assertion after r372192

2019-10-04 Thread Krasimir Georgiev via lldb-commits
Author: krasimir Date: Wed Sep 18 05:41:17 2019 New Revision: 372221 URL: http://llvm.org/viewvc/llvm-project?rev=372221&view=rev Log: [lldb] Fix a test assertion after r372192 Summary: The `CHECK: frame:py: None` seems to have been a typo, causing build bot failures: ``` # CHECK: frame:py: Non

[Lldb-commits] [lldb] r346478 - [lldb] Fix signature in test to match rL346453

2019-10-04 Thread Kadir Cetinkaya via lldb-commits
Author: kadircet Date: Fri Nov 9 01:00:12 2018 New Revision: 346478 URL: http://llvm.org/viewvc/llvm-project?rev=346478&view=rev Log: [lldb] Fix signature in test to match rL346453 Modified: lldb/trunk/unittests/Host/FileSystemTest.cpp Modified: lldb/trunk/unittests/Host/FileSystemTest.cpp

[Lldb-commits] [lldb] r372905 - [lldb] Excludes private headers from SWIG dependency.

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Wed Sep 25 11:17:45 2019 New Revision: 372905 URL: http://llvm.org/viewvc/llvm-project?rev=372905&view=rev Log: [lldb] Excludes private headers from SWIG dependency. Reviewers: xiaobai Subscribers: mgorny, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.o

[Lldb-commits] [lldb] r370045 - [ASTImporter] Fix name conflict handling with different strategies

2019-10-04 Thread Gabor Marton via lldb-commits
Author: martong Date: Tue Aug 27 04:36:10 2019 New Revision: 370045 URL: http://llvm.org/viewvc/llvm-project?rev=370045&view=rev Log: [ASTImporter] Fix name conflict handling with different strategies There are numorous flaws about the name conflict handling, this patch attempts fixes them. Chang

[Lldb-commits] [lldb] r368497 - Small format fix

2019-10-04 Thread Haibo Huang via lldb-commits
Author: hhb Date: Fri Aug 9 15:59:56 2019 New Revision: 368497 URL: http://llvm.org/viewvc/llvm-project?rev=368497&view=rev Log: Small format fix Differential Revision: https://reviews.llvm.org/D66034 Modified: lldb/trunk/source/Plugins/Process/Utility/StopInfoMachException.cpp Modified: l

[Lldb-commits] [lldb] r366580 - Support Linux signal return trampolines in frame initialization

2019-10-04 Thread Joseph Tremoulet via lldb-commits
Author: josepht Date: Fri Jul 19 07:05:55 2019 New Revision: 366580 URL: http://llvm.org/viewvc/llvm-project?rev=366580&view=rev Log: Support Linux signal return trampolines in frame initialization Summary: Add __kernel_rt_sigreturn to the list of trap handlers for Linux (it's used as such on aar

[Lldb-commits] [lldb] r352035 - Fix potential ODR vialation.

2019-10-04 Thread Haojian Wu via lldb-commits
Author: hokein Date: Thu Jan 24 01:35:08 2019 New Revision: 352035 URL: http://llvm.org/viewvc/llvm-project?rev=352035&view=rev Log: Fix potential ODR vialation. Modified: lldb/trunk/source/Plugins/ObjectFile/Breakpad/BreakpadRecords.h Modified: lldb/trunk/source/Plugins/ObjectFile/Breakpad/

[Lldb-commits] [lldb] r373783 - [Host] Return status directly from RunShellCommand

2019-10-04 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Fri Oct 4 12:54:45 2019 New Revision: 373783 URL: http://llvm.org/viewvc/llvm-project?rev=373783&view=rev Log: [Host] Return status directly from RunShellCommand Thanks for catching this, Pavel! Modified: lldb/trunk/source/Host/macosx/objcxx/Host.mm lldb/trunk

Re: [Lldb-commits] [lldb] r373776 - [Host] Don't discard return value from RunShellCommand

2019-10-04 Thread Jonas Devlieghere via lldb-commits
Thanks! Fixed in 373783. On Fri, Oct 4, 2019 at 12:38 PM Pavel Labath wrote: > > On 04/10/2019 21:37, Jonas Devlieghere via lldb-commits wrote: > > + error.SetErrorString(e.AsCString()); > > + return error; > > +} > > return e; ___ lldb-co

[Lldb-commits] [lldb] r355861 - Fix some comment typos.

2019-10-04 Thread Med Ismail Bennani via lldb-commits
Author: mib Date: Mon Mar 11 13:23:34 2019 New Revision: 355861 URL: http://llvm.org/viewvc/llvm-project?rev=355861&view=rev Log: Fix some comment typos. Signed-off-by: Med Ismail Bennani Modified: lldb/trunk/include/lldb/Core/Address.h lldb/trunk/include/lldb/Target/ExecutionContextSco

[Lldb-commits] [lldb] r369313 - [lldb] Fix typo on the BreakpointLocation header and the lldbtest.py (NFC)

2019-10-04 Thread Med Ismail Bennani via lldb-commits
Author: mib Date: Mon Aug 19 16:59:31 2019 New Revision: 369313 URL: http://llvm.org/viewvc/llvm-project?rev=369313&view=rev Log: [lldb] Fix typo on the BreakpointLocation header and the lldbtest.py (NFC) Summary: This commit fixes some typo I found while exploring LLDB's codebase. Signed-off-by

[Lldb-commits] [lldb] r343318 - Reapply the changes reverted by r343236

2019-10-04 Thread Luke Cheeseman via lldb-commits
Author: lukecheeseman Date: Fri Sep 28 06:38:16 2018 New Revision: 343318 URL: http://llvm.org/viewvc/llvm-project?rev=343318&view=rev Log: Reapply the changes reverted by r343236 Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDefines.cpp lldb/trunk/source/Plugins/SymbolFile/D

[Lldb-commits] [lldb] r343236 - Revert r343193 together with r343192

2019-10-04 Thread Luke Cheeseman via lldb-commits
Author: lukecheeseman Date: Thu Sep 27 09:48:04 2018 New Revision: 343236 URL: http://llvm.org/viewvc/llvm-project?rev=343236&view=rev Log: Revert r343193 together with r343192 Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDefines.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF

[Lldb-commits] [lldb] r360760 - [ASTImporter] Use llvm::Expected and Error in the importer API

2019-10-04 Thread Gabor Marton via lldb-commits
Author: martong Date: Wed May 15 03:29:48 2019 New Revision: 360760 URL: http://llvm.org/viewvc/llvm-project?rev=360760&view=rev Log: [ASTImporter] Use llvm::Expected and Error in the importer API Summary: This is the final phase of the refactoring towards using llvm::Expected and llvm::Error in

[Lldb-commits] [lldb] r343033 - [lldb-mi] Fix bugs in target-select-so-path.test

2019-10-04 Thread Alexander Polyakov via lldb-commits
Author: apolyakov Date: Tue Sep 25 14:49:33 2018 New Revision: 343033 URL: http://llvm.org/viewvc/llvm-project?rev=343033&view=rev Log: [lldb-mi] Fix bugs in target-select-so-path.test Summary: * This patch fixes hanging of the test in case of using python3, changes callback function that will

[Lldb-commits] [lldb] r369453 - [LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (NFC)

2019-10-04 Thread Med Ismail Bennani via lldb-commits
Author: mib Date: Tue Aug 20 14:58:22 2019 New Revision: 369453 URL: http://llvm.org/viewvc/llvm-project?rev=369453&view=rev Log: [LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (NFC) Summary: The test for conditional breakpoints on Windows was skipped because there was no exp

[Lldb-commits] [lldb] r343193 - Update CallFrameString API to account for r343114

2019-10-04 Thread Luke Cheeseman via lldb-commits
Author: lukecheeseman Date: Thu Sep 27 03:42:14 2018 New Revision: 343193 URL: http://llvm.org/viewvc/llvm-project?rev=343193&view=rev Log: Update CallFrameString API to account for r343114 - CallFrameString now takes an Arch parameter to account for multiplexing overlapping CFI directives Mo

[Lldb-commits] [lldb] r347575 - [ASTImporter] Set MustBuildLookupTable on PrimaryContext

2019-10-04 Thread Gabor Marton via lldb-commits
Author: martong Date: Mon Nov 26 09:09:50 2018 New Revision: 347575 URL: http://llvm.org/viewvc/llvm-project?rev=347575&view=rev Log: [ASTImporter] Set MustBuildLookupTable on PrimaryContext Summary: SetMustBuildLookupTable() must always be called on a primary context. Reviewers: labath, shafik,

[Lldb-commits] [lldb] r343342 - Revert r343318 together with llvm commit r343317

2019-10-04 Thread Luke Cheeseman via lldb-commits
Author: lukecheeseman Date: Fri Sep 28 10:02:56 2018 New Revision: 343342 URL: http://llvm.org/viewvc/llvm-project?rev=343342&view=rev Log: Revert r343318 together with llvm commit r343317 Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDefines.cpp lldb/trunk/source/Plugins/Symb

[Lldb-commits] [lldb] r341667 - [ARC] Make char unsigned by default

2019-10-04 Thread Alexander Polyakov via lldb-commits
Author: apolyakov Date: Fri Sep 7 07:45:32 2018 New Revision: 341667 URL: http://llvm.org/viewvc/llvm-project?rev=341667&view=rev Log: [ARC] Make char unsigned by default Summary: This patch specifies 'char' default sign on ARC. Reviewers: tatyana-krasnukha, clayborg Reviewed By: tatyana-krasn

Re: [Lldb-commits] [PATCH] D49750: Add support for ARM and ARM64 breakpad generated minidump files.

2019-10-04 Thread Mark Mentovai via lldb-commits
This can be done unambiguously because Breakpad used its own values for the magic numbers identifying its own context structure. You’ll find this in the ContextFlags field. Breakpad MD_CONTEXT_ARM is 0x4000 and MD_CONTEXT_ARM64 is 0x8000. Microsoft CONTEXT_ARM is 0x0020 and CONTEXT_ARM

[Lldb-commits] [lldb] r342329 - [lldb-mi] Correct regex in the symbol-list-lines test

2019-10-04 Thread Alexander Polyakov via lldb-commits
Author: apolyakov Date: Sat Sep 15 10:05:20 2018 New Revision: 342329 URL: http://llvm.org/viewvc/llvm-project?rev=342329&view=rev Log: [lldb-mi] Correct regex in the symbol-list-lines test Summary: The test failed in case of compiling a test suite with gcc (checked versions are 5.2.0 and 7.3.0)

[Lldb-commits] [lldb] r338995 - Change ConstString::SetCStringWithMangledCounterpart to use StringRef

2019-10-04 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Aug 6 01:27:59 2018 New Revision: 338995 URL: http://llvm.org/viewvc/llvm-project?rev=338995&view=rev Log: Change ConstString::SetCStringWithMangledCounterpart to use StringRef This should simplify the upcoming demangling patch (D50071). While I was in there, I also adde

[Lldb-commits] [lldb] r345563 - [lldb-mi] Implement -gdb-set breakpoint pending on/off

2019-10-04 Thread Marc-Andre Laperle via lldb-commits
Author: malaperle Date: Mon Oct 29 20:10:41 2018 New Revision: 345563 URL: http://llvm.org/viewvc/llvm-project?rev=345563&view=rev Log: [lldb-mi] Implement -gdb-set breakpoint pending on/off Summary: This allows creating pending breakpoint automatically when a location is not found. This is used

[Lldb-commits] [lldb] r342915 - [lldb-mi] Fix hanging of target-select-so-path.test

2019-10-04 Thread Alexander Polyakov via lldb-commits
Author: apolyakov Date: Mon Sep 24 12:10:48 2018 New Revision: 342915 URL: http://llvm.org/viewvc/llvm-project?rev=342915&view=rev Log: [lldb-mi] Fix hanging of target-select-so-path.test Summary: The target-select-so-path test might hang on some platforms. The reason of that behavior was in inco

[Lldb-commits] [lldb] r349020 - Fix for clang interface update

2019-10-04 Thread Mikael Nilsson via lldb-commits
Author: mikael Date: Thu Dec 13 02:17:26 2018 New Revision: 349020 URL: http://llvm.org/viewvc/llvm-project?rev=349020&view=rev Log: Fix for clang interface update FunctionProtoType.TypeQuals is now a Qualifiers object instead of an integer. The related clang commit: r349019 Modified: lldb

[Lldb-commits] [lldb] r347047 - [lldb] NFC: Remove the extra ';'

2019-10-04 Thread Henry Wong via lldb-commits
Author: henrywong Date: Fri Nov 16 05:01:57 2018 New Revision: 347047 URL: http://llvm.org/viewvc/llvm-project?rev=347047&view=rev Log: [lldb] NFC: Remove the extra ';' Summary: Remove extra `;` to eliminate the following pedantic warning. ``` warning: extra ';' [-Wpedantic] ``` Reviewers: sha

[Lldb-commits] [lldb] r357420 - [Process] Fix WriteMemory return value

2019-10-04 Thread Med Ismail Bennani via lldb-commits
Author: mib Date: Mon Apr 1 12:08:47 2019 New Revision: 357420 URL: http://llvm.org/viewvc/llvm-project?rev=357420&view=rev Log: [Process] Fix WriteMemory return value Summary: In case of a breakpoint site overlapping with the destination address, the WriteMemory method reported an incorrect mem

[Lldb-commits] [lldb] r357131 - Teach TypeSystem about PDBASTParser

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Wed Mar 27 16:00:47 2019 New Revision: 357131 URL: http://llvm.org/viewvc/llvm-project?rev=357131&view=rev Log: Teach TypeSystem about PDBASTParser Currently, only ClangASTContext knows about PDBASTParser. Eventually we want the TypeSystem to have getters/setters for the base

[Lldb-commits] [lldb] r347500 - Revert r347491 as it's llvm counterpart breaks buildbots

2019-10-04 Thread Luke Cheeseman via lldb-commits
Author: lukecheeseman Date: Fri Nov 23 09:13:47 2018 New Revision: 347500 URL: http://llvm.org/viewvc/llvm-project?rev=347500&view=rev Log: Revert r347491 as it's llvm counterpart breaks buildbots Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDefines.cpp lldb/trunk/source/Plu

[Lldb-commits] [lldb] r355883 - Add a case in SymbolFile{Native, }PDB::TranslateLanguage for Swift

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Mon Mar 11 16:30:58 2019 New Revision: 355883 URL: http://llvm.org/viewvc/llvm-project?rev=355883&view=rev Log: Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift Summary: see above Reviewers: compnerd Differential Revision: https://reviews.llvm.org/D59230 Mo

[Lldb-commits] [lldb] r346993 - Force SHELL to be cmd.exe on Windows for the test suite

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Thu Nov 15 12:56:44 2018 New Revision: 346993 URL: http://llvm.org/viewvc/llvm-project?rev=346993&view=rev Log: Force SHELL to be cmd.exe on Windows for the test suite Summary: Windows make will search for other shells and choose those over cmd if available (e.g. C:\cygdrive\b

[Lldb-commits] [lldb] r357113 - Kill unused variable m_tu_decl_up in SymbolFilePDB

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Wed Mar 27 12:15:13 2019 New Revision: 357113 URL: http://llvm.org/viewvc/llvm-project?rev=357113&view=rev Log: Kill unused variable m_tu_decl_up in SymbolFilePDB Summary: An TranslationUnitDecl was being brought in from the clang::ASTContext which required clang specific code

[Lldb-commits] [lldb] r346179 - Adjust the comment section of CreateSource to account for lines longer than 60

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Mon Nov 5 14:55:30 2018 New Revision: 346179 URL: http://llvm.org/viewvc/llvm-project?rev=346179&view=rev Log: Adjust the comment section of CreateSource to account for lines longer than 60 Summary: On rare occasions, the address, instruction and arguments of a line of assemb

[Lldb-commits] [lldb] r349474 - Fix typo in r349473

2019-10-04 Thread Luke Cheeseman via lldb-commits
Author: lukecheeseman Date: Tue Dec 18 03:05:43 2018 New Revision: 349474 URL: http://llvm.org/viewvc/llvm-project?rev=349474&view=rev Log: Fix typo in r349473 Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDefines.h Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDefin

[Lldb-commits] [lldb] r346346 - Adjust some id bit shifts to fit inside 32 bit integers

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Wed Nov 7 11:27:36 2018 New Revision: 346346 URL: http://llvm.org/viewvc/llvm-project?rev=346346&view=rev Log: Adjust some id bit shifts to fit inside 32 bit integers Summary: The DAP on vscode uses a JavaScript `number` for identifiers while the Visual Studio version uses a

[Lldb-commits] [lldb] r349538 - Reenable FindLibXml2 on Windows and confirm its at least 2.8 or newer

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Tue Dec 18 12:51:00 2018 New Revision: 349538 URL: http://llvm.org/viewvc/llvm-project?rev=349538&view=rev Log: Reenable FindLibXml2 on Windows and confirm its at least 2.8 or newer Summary: GnuWin32 installs libxml2 2.4. This isn't recent enough for lldb's usage and thus the

[Lldb-commits] [lldb] r346994 - Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Thu Nov 15 12:58:09 2018 New Revision: 346994 URL: http://llvm.org/viewvc/llvm-project?rev=346994&view=rev Log: Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD Summary: This commit implements basic DidAttach and DidLaunch for the windows DynamicLoader plug

[Lldb-commits] [lldb] r366293 - [NativePDB] Make GetTranslationUnitDecl return an lldb CompilerDeclCtx

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Wed Jul 17 00:05:49 2019 New Revision: 366293 URL: http://llvm.org/viewvc/llvm-project?rev=366293&view=rev Log: [NativePDB] Make GetTranslationUnitDecl return an lldb CompilerDeclCtx Summary: We intend to make PdbAstBuilder abstract and implement PdbAstBuilderClang along with

[Lldb-commits] [lldb] r346281 - Remove working directory for debugserver code signing target

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Tue Nov 6 15:54:52 2018 New Revision: 346281 URL: http://llvm.org/viewvc/llvm-project?rev=346281&view=rev Log: Remove working directory for debugserver code signing target Summary: LLVM puts output binaries in `${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin`. This chunk

[Lldb-commits] [lldb] r346174 - Set stdout/stdin to binary mode on Windows

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Mon Nov 5 14:25:00 2018 New Revision: 346174 URL: http://llvm.org/viewvc/llvm-project?rev=346174&view=rev Log: Set stdout/stdin to binary mode on Windows Summary: A file opened in text mode on Windows will have `\n` automatically changed to `13,10` while Darwin and Linux lea

[Lldb-commits] [lldb] r365868 - [windows] re-call signal in sigint_handler for Windows

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Thu Jul 11 21:43:46 2019 New Revision: 365868 URL: http://llvm.org/viewvc/llvm-project?rev=365868&view=rev Log: [windows] re-call signal in sigint_handler for Windows Summary: Windows requires re-setting the signal handler each time it is used and thus ctrl-c was not behaving

[Lldb-commits] [lldb] r366345 - [NativePDB] Add a FromCompilerDecl for going from lldb -> clang

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Wed Jul 17 09:43:36 2019 New Revision: 366345 URL: http://llvm.org/viewvc/llvm-project?rev=366345&view=rev Log: [NativePDB] Add a FromCompilerDecl for going from lldb -> clang Summary: A common transformation in NativePDB is to go from lldb types to clang types and vice versa.

[Lldb-commits] [lldb] r357044 - Get the lang from the CompileUnit for ParseCompileUnitFunctionForPDBFunc

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Tue Mar 26 18:24:03 2019 New Revision: 357044 URL: http://llvm.org/viewvc/llvm-project?rev=357044&view=rev Log: Get the lang from the CompileUnit for ParseCompileUnitFunctionForPDBFunc Summary: Instead of assuming that the language is C++ instead check the compunit for the lan

[Lldb-commits] [lldb] r366394 - Only build lldb-tblgen if it's not a current target

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Wed Jul 17 18:26:53 2019 New Revision: 366394 URL: http://llvm.org/viewvc/llvm-project?rev=366394&view=rev Log: Only build lldb-tblgen if it's not a current target Summary: When doing standalone builds, you could potentially be building against an llvm which also built lldb. I

[Lldb-commits] [lldb] r366520 - check for interrupt from fgets on Windows

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Thu Jul 18 17:40:37 2019 New Revision: 366520 URL: http://llvm.org/viewvc/llvm-project?rev=366520&view=rev Log: check for interrupt from fgets on Windows Windows does not have the error EINTR when a blocking syscall is interrupted by a signal. The ReadFile API that fgets is im

[Lldb-commits] [lldb] r366513 - [cmake] Update NATIVE build variables to account for standalone changes

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Thu Jul 18 16:40:23 2019 New Revision: 366513 URL: http://llvm.org/viewvc/llvm-project?rev=366513&view=rev Log: [cmake] Update NATIVE build variables to account for standalone changes Summary: LLDB_PATH_TO_{CLANG,LLVM}_BUILD were removed and replaced with {LLVM,Clang}_DIR. Adj

[Lldb-commits] [lldb] r366650 - [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Sun Jul 21 00:46:18 2019 New Revision: 366650 URL: http://llvm.org/viewvc/llvm-project?rev=366650&view=rev Log: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl We intend to make PdbAstBuilder abstract and implement PdbAstBuilderClang along with any other lan

[Lldb-commits] [lldb] r367850 - Changing representation of .cv_def_range directives in Codeview debug info assembly format for better readability

2019-10-04 Thread Nilanjana Basu via lldb-commits
Author: nilanjana_basu Date: Mon Aug 5 06:11:51 2019 New Revision: 367850 URL: http://llvm.org/viewvc/llvm-project?rev=367850&view=rev Log: Changing representation of .cv_def_range directives in Codeview debug info assembly format for better readability Modified: lldb/trunk/lit/SymbolFile/N

[Lldb-commits] [lldb] r367867 - Changing representation of .cv_def_range directives in Codeview debug info assembly format for better readability

2019-10-04 Thread Nilanjana Basu via lldb-commits
Author: nilanjana_basu Date: Mon Aug 5 07:16:58 2019 New Revision: 367867 URL: http://llvm.org/viewvc/llvm-project?rev=367867&view=rev Log: Changing representation of .cv_def_range directives in Codeview debug info assembly format for better readability Modified: lldb/trunk/lit/SymbolFile/N

[Lldb-commits] [lldb] r366285 - Don't require python exe and lib versions to match while crosscompiling

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Tue Jul 16 16:54:17 2019 New Revision: 366285 URL: http://llvm.org/viewvc/llvm-project?rev=366285&view=rev Log: Don't require python exe and lib versions to match while crosscompiling Summary: While cross compiling, the python executable is used to run a handful of scripts whi

[Lldb-commits] [lldb] r370106 - [Platform/Android] Read the adb server from an env variable if set

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Tue Aug 27 13:00:02 2019 New Revision: 370106 URL: http://llvm.org/viewvc/llvm-project?rev=370106&view=rev Log: [Platform/Android] Read the adb server from an env variable if set Summary: The environment variable ANDROID_ADB_SERVER_PORT can be defined to have adbd litsen on a

[Lldb-commits] [lldb] r346171 - Add a relocation to ObjectFileELF::ApplyRelocations and a test

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Mon Nov 5 14:18:00 2018 New Revision: 346171 URL: http://llvm.org/viewvc/llvm-project?rev=346171&view=rev Log: Add a relocation to ObjectFileELF::ApplyRelocations and a test Summary: pcm files can end up being processed by lldb with relocations to be made for the .debug_info

[Lldb-commits] [lldb] r351664 - Fix order of arguments in an lldb type summary in examples

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Sat Jan 19 12:08:41 2019 New Revision: 351664 URL: http://llvm.org/viewvc/llvm-project?rev=351664&view=rev Log: Fix order of arguments in an lldb type summary in examples The format for the -w argument is: -w name ( --category name ) Rearrange the flags correctly. Modif

[Lldb-commits] [lldb] r347491 - Revert r343342 together with LLVM commit 347490.

2019-10-04 Thread Luke Cheeseman via lldb-commits
Author: lukecheeseman Date: Fri Nov 23 03:03:00 2018 New Revision: 347491 URL: http://llvm.org/viewvc/llvm-project?rev=347491&view=rev Log: Revert r343342 together with LLVM commit 347490. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDefines.cpp lldb/trunk/source/Plugins/Symb

[Lldb-commits] [lldb] r346988 - Add a check whether or not a str is utf8 prior to emplacing

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Thu Nov 15 11:49:57 2018 New Revision: 346988 URL: http://llvm.org/viewvc/llvm-project?rev=346988&view=rev Log: Add a check whether or not a str is utf8 prior to emplacing Summary: Highlighing junk data on VSCode can send a query for evaluate which fails. In particular cases o

[Lldb-commits] [lldb] r367861 - Revert "Changing representation of .cv_def_range directives in Codeview debug info assembly format for better readability"

2019-10-04 Thread Nilanjana Basu via lldb-commits
Author: nilanjana_basu Date: Mon Aug 5 06:55:21 2019 New Revision: 367861 URL: http://llvm.org/viewvc/llvm-project?rev=367861&view=rev Log: Revert "Changing representation of .cv_def_range directives in Codeview debug info assembly format for better readability" This reverts commit a885afa9fa8c

[Lldb-commits] [lldb] r366281 - add a workaround in GetLine to account for ReadFile not reporintg error

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Tue Jul 16 16:01:59 2019 New Revision: 366281 URL: http://llvm.org/viewvc/llvm-project?rev=366281&view=rev Log: add a workaround in GetLine to account for ReadFile not reporintg error Summary: ReadFile on Windows is supposed to set ERROR_OPERATION_ABORTED according to the docs

[Lldb-commits] [lldb] r346067 - Test commit

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Fri Nov 2 22:12:15 2018 New Revision: 346067 URL: http://llvm.org/viewvc/llvm-project?rev=346067&view=rev Log: Test commit Modified: lldb/trunk/docs/building-with-debug-llvm.txt Modified: lldb/trunk/docs/building-with-debug-llvm.txt URL: http://llvm.org/viewvc/llvm-proj

[Lldb-commits] [lldb] r348526 - Implement WindowsDYLD::DidAttach for use with gdb-server attach

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Thu Dec 6 13:13:03 2018 New Revision: 348526 URL: http://llvm.org/viewvc/llvm-project?rev=348526&view=rev Log: Implement WindowsDYLD::DidAttach for use with gdb-server attach Summary: Windows lldb debugging currently uses a process plugin to handle launching and attaching to

[Lldb-commits] [lldb] r366392 - [cmake] Add NATIVE build for cross compiling standalone builds

2019-10-04 Thread Nathan Lanza via lldb-commits
Author: lanza Date: Wed Jul 17 17:21:57 2019 New Revision: 366392 URL: http://llvm.org/viewvc/llvm-project?rev=366392&view=rev Log: [cmake] Add NATIVE build for cross compiling standalone builds TableGen is a host tool and requires a native variant for every build. While building as a part of llv

[Lldb-commits] [lldb] r349473 - Update CallFrameString API to account for r349472

2019-10-04 Thread Luke Cheeseman via lldb-commits
Author: lukecheeseman Date: Tue Dec 18 02:39:19 2018 New Revision: 349473 URL: http://llvm.org/viewvc/llvm-project?rev=349473&view=rev Log: Update CallFrameString API to account for r349472 - CallFrameString now takes an Arch parameter to account for multiplexing overlapping CFI directives Mo

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

2019-10-04 Thread Shoaib Meenai via Phabricator via lldb-commits
smeenai updated this revision to Diff 188988. smeenai added a comment. Release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-e

[Lldb-commits] [lldb] r351703 - Try to port tests to AST dump changes

2019-10-04 Thread Stephen Kelly via lldb-commits
Author: steveire Date: Sun Jan 20 14:56:02 2019 New Revision: 351703 URL: http://llvm.org/viewvc/llvm-project?rev=351703&view=rev Log: Try to port tests to AST dump changes Modified: lldb/trunk/lit/SymbolFile/NativePDB/ast-functions.cpp lldb/trunk/lit/SymbolFile/NativePDB/function-types-c

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

2019-10-04 Thread Shoaib Meenai via Phabricator via lldb-commits
smeenai added a comment. In D58791#1415496 , @tstellar wrote: > This looks good, but could you also add an entry in the ReleaseNotes for this. Will do – thanks for the reminder :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D61847: [lldb] NFC modernize codebase with modernize-use-nullptr

2019-10-04 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
kwk added a comment. @JDevlieghere can you please commit this in my name? I don't have commit access yet. I've filed an email an hope to get it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61847/new/ https://reviews.llvm.org/D61847 _

[Lldb-commits] [PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

2019-10-04 Thread Puyan Lotfi via Phabricator via lldb-commits
plotfi added a comment. Herald added a subscriber: dexonsmith. In D62034#1506102 , @mstorsjo wrote: > Yes, MinGW headers are all lowercase. > > And the Windows SDK, where the file is spelled with a capital W, isn't > self-consistent (some headers include

[Lldb-commits] [PATCH] D61847: [lldb] modernize codebase with modernize-use-nullptr

2019-10-04 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
kwk added a comment. @teemperor I've addressed all of your comments. Can you please have another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61847/new/ https://reviews.llvm.org/D61847 ___ lldb

<    1   2   3   4   >