[Lldb-commits] [lldb] r373783 - [Host] Return status directly from RunShellCommand

[Jonas Devlieghere via lldb-commits]

Author: jdevlieghere
Date: Fri Oct  4 12:54:45 2019
New Revision: 373783

URL: http://llvm.org/viewvc/llvm-project?rev=373783&view=rev
Log:
[Host] Return status directly from RunShellCommand

Thanks for catching this, Pavel!

Modified:
    lldb/trunk/source/Host/macosx/objcxx/Host.mm
    lldb/trunk/source/Host/windows/Host.cpp

Modified: lldb/trunk/source/Host/macosx/objcxx/Host.mm
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/macosx/objcxx/Host.mm?rev=373783&r1=373782&r2=373783&view=diff
==============================================================================
--- lldb/trunk/source/Host/macosx/objcxx/Host.mm (original)
+++ lldb/trunk/source/Host/macosx/objcxx/Host.mm Fri Oct  4 12:54:45 2019
@@ -1370,10 +1370,8 @@ Status Host::ShellExpandArguments(Proces
                                std::chrono::seconds(10), run_in_default_shell,
                                hide_stderr);
 
-    if (e.Fail()) {
-      error.SetErrorString(e.AsCString());
-      return error;
-    }
+    if (e.Fail())
+      return e;
 
     if (status != 0) {
       error.SetErrorStringWithFormat("lldb-argdumper exited with error %d",

Modified: lldb/trunk/source/Host/windows/Host.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/windows/Host.cpp?rev=373783&r1=373782&r2=373783&view=diff
==============================================================================
--- lldb/trunk/source/Host/windows/Host.cpp (original)
+++ lldb/trunk/source/Host/windows/Host.cpp Fri Oct  4 12:54:45 2019
@@ -230,10 +230,8 @@ Status Host::ShellExpandArguments(Proces
         RunShellCommand(command.c_str(), launch_info.GetWorkingDirectory(),
                         &status, nullptr, &output, std::chrono::seconds(10));
 
-    if (e.Fail()) {
-      error.SetErrorString(e.AsCString());
-      return error;
-    }
+    if (e.Fail())
+      return e;
 
     if (status != 0) {
       error.SetErrorStringWithFormat("lldb-argdumper exited with error %d",


_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits