Author: mib Date: Mon Aug 19 16:59:31 2019 New Revision: 369313 URL: http://llvm.org/viewvc/llvm-project?rev=369313&view=rev Log: [lldb] Fix typo on the BreakpointLocation header and the lldbtest.py (NFC)
Summary: This commit fixes some typo I found while exploring LLDB's codebase. Signed-off-by: Med Ismail Bennani <medismail.benn...@gmail.com> Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D66452 Modified: lldb/trunk/include/lldb/Breakpoint/BreakpointLocation.h lldb/trunk/include/lldb/Breakpoint/BreakpointOptions.h lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trunk/include/lldb/Breakpoint/BreakpointLocation.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Breakpoint/BreakpointLocation.h?rev=369313&r1=369312&r2=369313&view=diff ============================================================================== --- lldb/trunk/include/lldb/Breakpoint/BreakpointLocation.h (original) +++ lldb/trunk/include/lldb/Breakpoint/BreakpointLocation.h Mon Aug 19 16:59:31 2019 @@ -67,7 +67,7 @@ public: // The next section deals with various breakpoint options. - /// If \a enable is \b true, enable the breakpoint, if \b false disable it. + /// If \a enabled is \b true, enable the breakpoint, if \b false disable it. void SetEnabled(bool enabled); /// Check the Enable/Disable state. Modified: lldb/trunk/include/lldb/Breakpoint/BreakpointOptions.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Breakpoint/BreakpointOptions.h?rev=369313&r1=369312&r2=369313&view=diff ============================================================================== --- lldb/trunk/include/lldb/Breakpoint/BreakpointOptions.h (original) +++ lldb/trunk/include/lldb/Breakpoint/BreakpointOptions.h Mon Aug 19 16:59:31 2019 @@ -107,6 +107,12 @@ public: /// \param[in] ignore /// How many breakpoint hits we should ignore before stopping. /// + /// \param[in] one_shot + /// Should this breakpoint delete itself after being hit once. + /// + /// \param[in] auto_continue + /// Should this breakpoint auto-continue after running its commands. + /// BreakpointOptions(const char *condition, bool enabled = true, int32_t ignore = 0, bool one_shot = false, bool auto_continue = false); @@ -319,7 +325,10 @@ public: void GetDescription(Stream *s, lldb::DescriptionLevel level) const; - /// Returns true if the breakpoint option has a callback set. + /// Check if the breakpoint option has a callback set. + /// + /// \return + /// If the breakpoint option has a callback, \b true otherwise \b false. bool HasCallback() const; /// This is the default empty callback. @@ -367,22 +376,32 @@ protected: void SetThreadSpec(std::unique_ptr<ThreadSpec> &thread_spec_up); private: - // For BreakpointOptions only - BreakpointHitCallback m_callback; // This is the callback function pointer - lldb::BatonSP m_callback_baton_sp; // This is the client data for the callback + /// For BreakpointOptions only + + /// This is the callback function pointer + BreakpointHitCallback m_callback; + /// This is the client data for the callback + lldb::BatonSP m_callback_baton_sp; bool m_baton_is_command_baton; bool m_callback_is_synchronous; bool m_enabled; + /// If set, the breakpoint delete itself after being hit once. bool m_one_shot; - uint32_t m_ignore_count; // Number of times to ignore this breakpoint - std::unique_ptr<ThreadSpec> - m_thread_spec_up; // Thread for which this breakpoint will take - std::string m_condition_text; // The condition to test. - size_t m_condition_text_hash; // Its hash, so that locations know when the - // condition is updated. - bool m_auto_continue; // If set, auto-continue from breakpoint. - Flags m_set_flags; // Which options are set at this level. Drawn - // from BreakpointOptions::SetOptionsFlags. + /// Number of times to ignore this breakpoint. + uint32_t m_ignore_count; + /// Thread for which this breakpoint will stop. + std::unique_ptr<ThreadSpec> m_thread_spec_up; + /// The condition to test. + std::string m_condition_text; + /// Its hash, so that locations know when the condition is updated. + size_t m_condition_text_hash; + /// If set, inject breakpoint condition into process. + bool m_inject_condition; + /// If set, auto-continue from breakpoint. + bool m_auto_continue; + /// Which options are set at this level. + /// Drawn from BreakpointOptions::SetOptionsFlags. + Flags m_set_flags; }; } // namespace lldb_private Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=369313&r1=369312&r2=369313&view=diff ============================================================================== --- lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Mon Aug 19 16:59:31 2019 @@ -113,11 +113,11 @@ BREAKPOINT_STATE_CORRECT = "Breakpoint s BREAKPOINT_PENDING_CREATED = "Pending breakpoint created successfully" -BREAKPOINT_HIT_ONCE = "Breakpoint resolved with hit cout = 1" +BREAKPOINT_HIT_ONCE = "Breakpoint resolved with hit count = 1" -BREAKPOINT_HIT_TWICE = "Breakpoint resolved with hit cout = 2" +BREAKPOINT_HIT_TWICE = "Breakpoint resolved with hit count = 2" -BREAKPOINT_HIT_THRICE = "Breakpoint resolved with hit cout = 3" +BREAKPOINT_HIT_THRICE = "Breakpoint resolved with hit count = 3" MISSING_EXPECTED_REGISTERS = "At least one expected register is unavailable." @@ -140,6 +140,8 @@ STOPPED_DUE_TO_BREAKPOINT_CONDITION = "S STOPPED_DUE_TO_BREAKPOINT_IGNORE_COUNT = "Stopped due to breakpoint and ignore count" +STOPPED_DUE_TO_BREAKPOINT_JITTED_CONDITION = "Stopped due to breakpoint jitted condition" + STOPPED_DUE_TO_SIGNAL = "Process state is stopped due to signal" STOPPED_DUE_TO_STEP_IN = "Process state is stopped due to step in" _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
