[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

labath added a comment. Thanks for adding the lit test. Comment at: lldb/lit/SymbolFile/dissassemble-entry-point.s:6 +# RUN: %lldb -x -b \ +# RUN: -o 'settings set disassembly-format "{ <${function.concrete-only-addr-offset-no-padding}>}: "' \ +# RUN: -o 'dis -s 0x8074 -e 0x

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

labath accepted this revision. labath added a comment. Yay. BTW, there's another copy of json serialization code in JSON.cpp (JSONValue::Write). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68248/new/ https://reviews.llvm.org/D68248 __

[Lldb-commits] [lldb] r373312 - [clang][lldb][NFC] Encapsulate ExternalASTMerger::ImporterSource

Author: teemperor Date: Tue Oct 1 02:02:05 2019 New Revision: 373312 URL: http://llvm.org/viewvc/llvm-project?rev=373312&view=rev Log: [clang][lldb][NFC] Encapsulate ExternalASTMerger::ImporterSource NFC preparation work for upcoming ExternalASTMerger patches. Modified: lldb/trunk/source/Pl

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222569. kwk marked 8 inline comments as done. kwk added a comment. - Remove verbose output in test - Fix typo: smymtab -> symtab - Move compare and hash logic out of base class into derived class as requested Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk marked an inline comment as done. kwk added a comment. @labath can you please check this patch one last time (hopefully)? Comment at: lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp:371-373 + r.st_name = st_name; + return elf::ELFSymbol::operator==(r) && + st_nam

[Lldb-commits] [PATCH] D68140: [lldb][clang][modern-type-lookup] Use ASTImporterSharedState in ExternalASTMerger

martong added a comment. Raphael, thanks for working on this. Overall, the changes look good to me, but please see my comment for the constructor. Comment at: cfe/trunk/lib/AST/ExternalASTMerger.cpp:320 + SharedState = std::make_shared( + *Target.AST.getTranslationUnitDe

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM. thanks. Comment at: lldb/include/lldb/API/SBFile.h:31-36 operator bool() const { return IsValid(); } bool operator!() const { return !IsValid(); } private:

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222576. kwk added a comment. - Correct comment of test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/load-from-dynsym-alone.c lldb/lit/Mod

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222577. kwk added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/load-from-dynsym-alone.c lldb/lit/Modules/ELF/loa

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222584. kwk added a comment. - Simplify NamedELFSymbol::hash() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/load-from-dynsym-alone.c lldb

[Lldb-commits] [PATCH] D68140: [lldb][clang][modern-type-lookup] Use ASTImporterSharedState in ExternalASTMerger

peter.smith added a comment. This change has broken a test in the Arm and AArch64 buildbots. Specificallyclang/test/Import/cxx-anon-namespace/test.cpp For example (http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/10542/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Atest.cpp) F

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath added a comment. In D68188#1689104 , @lawrence_danna wrote: > In D68188#1687532 , @labath wrote: > > > It seems to be that instead of subclassing a fully-functional File class, > > it would be better to cre

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds reasonable. Thanks for doing this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68258/new/ https://reviews.llvm.org/D68258 ___

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

labath accepted this revision. labath added a comment. Ok, let's give this one more shot. Thanks for your patience. I do have a couple of additional comments inline, but I don't think we need another round of review for those. Comment at: lldb/lit/Modules/ELF/merge-symbols.ya

[Lldb-commits] [lldb] r373329 - [lldb][NFC] Modernize ClangASTContext constructor

Author: teemperor Date: Tue Oct 1 05:28:14 2019 New Revision: 373329 URL: http://llvm.org/viewvc/llvm-project?rev=373329&view=rev Log: [lldb][NFC] Modernize ClangASTContext constructor Now using default initializers and StringRef. Also formats the member list that we excluded from clang-format

[Lldb-commits] [lldb] r373330 - [lldb][NFC] Disallow changing the ASTContext of an ClangASTContext after construction.

Author: teemperor Date: Tue Oct 1 05:55:37 2019 New Revision: 373330 URL: http://llvm.org/viewvc/llvm-project?rev=373330&view=rev Log: [lldb][NFC] Disallow changing the ASTContext of an ClangASTContext after construction. We have no use case in LLDB where we actually do want to change the ASTCo

[Lldb-commits] [lldb] r373334 - [lldb][NFC] Remove unused ClangASTContext functions for checking/removing the ExternalASTSource

Author: teemperor Date: Tue Oct 1 06:05:57 2019 New Revision: 373334 URL: http://llvm.org/viewvc/llvm-project?rev=373334&view=rev Log: [lldb][NFC] Remove unused ClangASTContext functions for checking/removing the ExternalASTSource Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h

[Lldb-commits] [lldb] r373337 - [lldb][NFC] Remove unused ClangASTContext::GetHasExternalStorage

Author: teemperor Date: Tue Oct 1 06:25:25 2019 New Revision: 373337 URL: http://llvm.org/viewvc/llvm-project?rev=373337&view=rev Log: [lldb][NFC] Remove unused ClangASTContext::GetHasExternalStorage This code isn't used nor tested. Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

jankratochvil added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp:383 + std::hash()(st_name_string.AsCString()), + std::hash()(st_section_name_string.AsCString())); +} llvm::hash_combine already calls std::hash for each o

[Lldb-commits] [lldb] r373339 - [lldb][NFC] Mark ClangASTContext constructor as explicit

Author: teemperor Date: Tue Oct 1 06:45:06 2019 New Revision: 373339 URL: http://llvm.org/viewvc/llvm-project?rev=373339&view=rev Log: [lldb][NFC] Mark ClangASTContext constructor as explicit Given that we can implicitly construct a ClangASTContext from any string, we should really mark this as

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

labath created this revision. labath added reviewers: JDevlieghere, dblaikie, probinson. Herald added a subscriber: aprantl. Herald added a project: LLVM. Interpreting a .debug_loclists entry is not completely trivial [citation needed]. This patch creates a function which can be used by any libDeb

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

dblaikie added inline comments. Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h:93-108 + +/// Return the half-open range of addresses covered by this entry. +/// DW_LLE_offset_pair entries are resolved using the given base address, +/// and the supplied DWARF

[Lldb-commits] [lldb] r373342 - Update SymbolFilePDB for FindTypes API change.

Author: adrian Date: Tue Oct 1 08:29:33 2019 New Revision: 373342 URL: http://llvm.org/viewvc/llvm-project?rev=373342&view=rev Log: Update SymbolFilePDB for FindTypes API change. This is untested, I don't have access to a Windows machine. Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/S

[Lldb-commits] [PATCH] D68171: Remove unused "append" parameter from FindTypes API

aprantl added a comment. I made a blind attempt in r373342. Hopefully that should fix it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68171/new/ https://reviews.llvm.org/D68171 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

aprantl added a comment. Cool. I mean both are supposed to be JSON, but are we expecting any fallout from a debugserver using the old library vs and lldb using the new one? I suppose not.. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68248/new/ https://revie

[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU

jarin created this revision. Herald added subscribers: lldb-commits, JDevlieghere, teemperor. Herald added a project: LLDB. This makes sure that we associate DIEs that are imported from other CUs with the appropriate decl context. Without this fix, nested classes can be dumped directly into thei

[Lldb-commits] [lldb] r373344 - Remove size_t return parameter from FindTypes

Author: adrian Date: Tue Oct 1 08:40:41 2019 New Revision: 373344 URL: http://llvm.org/viewvc/llvm-project?rev=373344&view=rev Log: Remove size_t return parameter from FindTypes In r368345 I accidentally introduced a regression that would over-report the number of matches found by FindTypes if t

[Lldb-commits] [PATCH] D68169: Remove size_t return parameter from FindTypes

This revision was automatically updated to reflect the committed changes. Closed by commit rL373344: Remove size_t return parameter from FindTypes (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp:383 + std::hash()(st_name_string.AsCString()), + std::hash()(st_section_name_string.AsCString())); +} jankratochvil wrote: > llvm::hash_combine already calls std::ha

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222634. kwk marked 10 inline comments as done. kwk added a comment. - Check that no additional symbols follow after the expected ones - Use compiler-generated copy-ctor - Cleanup from experiment - Simplify NamedELFSymbol::hash() - Cleanup Repository: rG LLVM G

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

JDevlieghere added a comment. In D68248#1688975 , @vsk wrote: > Sweet! Does this 'automatically' fix the 'llvm-argdumper has issues escaping > JSON-ified input' issue we discussed in person? No, that uses the JSON class that Pavel mentioned. My hope is

[Lldb-commits] [PATCH] D68279: [JSON] Use LLVM's library for argdumper

JDevlieghere created this revision. JDevlieghere added reviewers: vsk, labath, aprantl. Herald added a subscriber: mgorny. Herald added a project: LLDB. This patch replaces the LLDB's JSON implementation with the one from LLVM in argdumper. Repository: rLLDB LLDB https://reviews.llvm.org/D68

[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU

labath added reviewers: clayborg, JDevlieghere. labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a reviewer: shafik. Just a bit more context (we were discussing this with Jaroslav offline): without this line, the `GetClangDeclCon

[Lldb-commits] [lldb] r373353 - Typo (NFC)

Author: adrian Date: Tue Oct 1 10:08:41 2019 New Revision: 373353 URL: http://llvm.org/viewvc/llvm-project?rev=373353&view=rev Log: Typo (NFC) Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClan

[Lldb-commits] [lldb] r373354 - Fix a condition-flip regression introduced in r373344.

Author: adrian Date: Tue Oct 1 10:08:44 2019 New Revision: 373354 URL: http://llvm.org/viewvc/llvm-project?rev=373354&view=rev Log: Fix a condition-flip regression introduced in r373344. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Modified: lldb/trunk/source

[Lldb-commits] [lldb] r373352 - Simplify condition (NFC)

Author: adrian Date: Tue Oct 1 10:08:38 2019 New Revision: 373352 URL: http://llvm.org/viewvc/llvm-project?rev=373352&view=rev Log: Simplify condition (NFC) Modified: lldb/trunk/source/DataFormatters/TypeFormat.cpp Modified: lldb/trunk/source/DataFormatters/TypeFormat.cpp URL: http://llvm.

[Lldb-commits] [lldb] r373355 - Fix a syntax error.

Author: adrian Date: Tue Oct 1 10:10:25 2019 New Revision: 373355 URL: http://llvm.org/viewvc/llvm-project?rev=373355&view=rev Log: Fix a syntax error. Modified: lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp Modified: lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp U

[Lldb-commits] [PATCH] D68282: [JSON] Use LLVM's library for decoding JSON in StructuredData

JDevlieghere created this revision. JDevlieghere added reviewers: labath, vsk, aprantl. Herald added a project: LLDB. This patch replaces the hand-rolled JSON decoding in StructuredData with LLVM's JSON library. Repository: rLLDB LLDB https://reviews.llvm.org/D68282 Files: lldb/include/ll

[Lldb-commits] [PATCH] D68282: [JSON] Use LLVM's library for decoding JSON in StructuredData

aprantl added inline comments. Comment at: lldb/source/Utility/StructuredData.cpp:48 } - - JSONParser json_parser(buffer_or_error.get()->getBuffer()); - return_sp = ParseJSONValue(json_parser); - return return_sp; + return ParseJSON(buffer_or_error.get()->getBuffer().str()

[Lldb-commits] [PATCH] D68282: [JSON] Use LLVM's library for decoding JSON in StructuredData

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Utility/StructuredData.cpp:48 } - - JSONParser json_parser(buffer_or_error.get()->getBuffer()); - return_sp = ParseJSONValue(json_parser); - return return_sp; + retur

[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. A few short comments what the role of the different classes/members play in the test case would be helpful. E.g. "This member/variable/expressions triggers the loading of Decl

[Lldb-commits] [lldb] r373359 - [JSON] Use LLVM's library for encoding JSON in StructuredData

Author: jdevlieghere Date: Tue Oct 1 10:41:48 2019 New Revision: 373359 URL: http://llvm.org/viewvc/llvm-project?rev=373359&view=rev Log: [JSON] Use LLVM's library for encoding JSON in StructuredData This patch replaces the hand-rolled JSON emission in StructuredData with LLVM's JSON library. D

[Lldb-commits] [lldb] r373360 - [JSON] Use LLVM's library for decoding JSON in StructuredData

Author: jdevlieghere Date: Tue Oct 1 10:41:52 2019 New Revision: 373360 URL: http://llvm.org/viewvc/llvm-project?rev=373360&view=rev Log: [JSON] Use LLVM's library for decoding JSON in StructuredData This patch replaces the hand-rolled JSON decoding in StructuredData with LLVM's JSON library. D

[Lldb-commits] [lldb] r373361 - [JSON] Use LLVM's library for argdumper

Author: jdevlieghere Date: Tue Oct 1 10:41:55 2019 New Revision: 373361 URL: http://llvm.org/viewvc/llvm-project?rev=373361&view=rev Log: [JSON] Use LLVM's library for argdumper This patch replaces the LLDB's JSON implementation with the one from LLVM in argdumper. Differential revision: https:

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

This revision was automatically updated to reflect the committed changes. Closed by commit rL373359: [JSON] Use LLVM's library for encoding JSON in StructuredData (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [PATCH] D68282: [JSON] Use LLVM's library for decoding JSON in StructuredData

This revision was automatically updated to reflect the committed changes. Closed by commit rL373360: [JSON] Use LLVM's library for decoding JSON in StructuredData (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [PATCH] D68279: [JSON] Use LLVM's library for argdumper

This revision was automatically updated to reflect the committed changes. Closed by commit rL373361: [JSON] Use LLVM's library for argdumper (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU

shafik added a comment. The fix makes sense to me, I wonder if we have a similar issue w/ namespaces or perhaps they are handled differently. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68278/new/ https://reviews.llvm.org/D68278 __

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

JDevlieghere added a comment. Hey, I just want to give you a heads up that I'm in the process to replace LLDB's JSON implementation with the one from LLVM. The parts in StructuredData are already gone (r373359, r373360) and I'm currently working on the other uses in LLDB, except for debugserver

[Lldb-commits] [lldb] r373373 - Make another attempt at fixing SymbolFilePDBTests.

Author: adrian Date: Tue Oct 1 11:15:22 2019 New Revision: 373373 URL: http://llvm.org/viewvc/llvm-project?rev=373373&view=rev Log: Make another attempt at fixing SymbolFilePDBTests. Modified: lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp Modified: lldb/trunk/unittests/SymbolFi

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222661. lawrence_danna added a comment. no inlines in the API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h lldb/includ

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 222664. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. no inlines in the API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Fi

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace created this revision. wallace added reviewers: clayborg, aadsm, labath, xiaobai. Herald added subscribers: lldb-commits, kristof.beyls, krytarowski, srhines. Herald added a project: LLDB. By default `platform process list` only shows the processes of the current user that lldb-server can

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace updated this revision to Diff 222671. wallace added a comment. remove file accidentally included Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index: lldb

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace updated this revision to Diff 222673. wallace added a comment. - [process list] make the TRIPLE column wider Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace updated this revision to Diff 222674. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index: lldb/source/Host/linux/Host.cpp

[Lldb-commits] [PATCH] D68291: [process list] make the TRIPLE column wider

wallace created this revision. wallace added reviewers: clayborg, labath, xiaobai, aadsm. Herald added subscribers: lldb-commits, kristof.beyls. Herald added a project: LLDB. Now that `process list` works better on the android platform, the arch aarch64-unknown-linux-android appears quite often.

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm updated this revision to Diff 222680. aadsm added a comment. Update tests and fix logic to correctly add the symtab entry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68069/new/ https://reviews.llvm.org/D68069 Files: lldb/lit/SymbolFile/

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace created this revision. wallace added reviewers: clayborg, aadsm, labath, xiaobai. Herald added subscribers: lldb-commits, atanasyan, JDevlieghere, kristof.beyls, arichardson, sdardis. Herald added a project: LLDB. wallace edited the summary of this revision. The qfProcessInfo and qsProces

[Lldb-commits] [PATCH] D68299: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mgorbach, vsk. This patch replaces the LLDB's JSON implementation with the one from LLVM in GDBRemoteCommunicationServerLLGS. https://reviews.llvm.org/D68299 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommun

[Lldb-commits] [PATCH] D68301: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationClient

JDevlieghere created this revision. JDevlieghere added reviewers: labath, vsk, jasonmolenda, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch replaces the LLDB's JSON implementation with the one from LLVM in GDBRemoteCommunicationClient. Repository: r

[Lldb-commits] [PATCH] D68302: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerPlatform

JDevlieghere created this revision. JDevlieghere added reviewers: labath, vsk. Herald added a project: LLDB. This patch replaces the LLDB's JSON implementation with the one from LLVM in GDBRemoteCommunicationServerPlatform. Repository: rLLDB LLDB https://reviews.llvm.org/D68302 Files: lld

[Lldb-commits] [PATCH] D68304: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerCommon

JDevlieghere created this revision. JDevlieghere added reviewers: labath, aprantl, vsk. Herald added a project: LLDB. This patch replaces the LLDB's JSON implementation with the one from LLVM in GDBRemoteCommunicationServerCommon. Repository: rLLDB LLDB https://reviews.llvm.org/D68304 Files:

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

amccarth added a comment. Why an environment variable rather than a command line option? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68258/new/ https://reviews.llvm.org/D68258 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D68305: [JSON] Remove Utility/JSON.{h|cpp}

JDevlieghere created this revision. JDevlieghere added reviewers: labath, vsk, aprantl, clayborg. Herald added a subscriber: mgorny. Herald added a project: LLDB. JDevlieghere retitled this revision from "[JSON] RemoveUtility/JSON.{h|cpp}" to "[JSON] Remove Utility/JSON.{h|cpp}". This patch is th

[Lldb-commits] [lldb] r373399 - [lldb] Fix unused variable warning

Author: rupprecht Date: Tue Oct 1 15:04:14 2019 New Revision: 373399 URL: http://llvm.org/viewvc/llvm-project?rev=373399&view=rev Log: [lldb] Fix unused variable warning Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/S

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp added a comment. In D68179#1690073 , @JDevlieghere wrote: > Hey, I just want to give you a heads up that I'm in the process to replace > LLDB's JSON implementation with the one from LLVM. The parts in > StructuredData are already gone (r37335

Re: [Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

debugserver doesn't use llvm classes, it's its own stand-alone thing. So debugserver wasn't included in Jonas' changes. Jim > On Oct 1, 2019, at 3:11 PM, Alex Cameron via Phabricator > wrote: > > tetsuo-cpp added a comment. > > In D68179#1690073 , @

[Lldb-commits] [lldb] r373409 - Make yet another attempt in restoring SymbolFilePDBTests

Author: adrian Date: Tue Oct 1 17:06:27 2019 New Revision: 373409 URL: http://llvm.org/viewvc/llvm-project?rev=373409&view=rev Log: Make yet another attempt in restoring SymbolFilePDBTests The original test was passing false to the append argument of FindTypes (the only use of this feature!). Th

[Lldb-commits] [PATCH] D68312: [gdb-remote] process properly effective uid

wallace created this revision. wallace added reviewers: labath, clayborg, aadsm, xiaobai. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Someone wrote SetEffectiveSetEffectiveGroupID instead of SetEffectiveUserID. After this fix, the android process list can show user name

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace updated this revision to Diff 222739. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index: lldb/source/Host/linux/Host.cpp

[Lldb-commits] [PATCH] D68314: [process info] Remove assert in DoGetGroupName

wallace created this revision. wallace added reviewers: clayborg, aadsm, xiaobai, labath. Herald added subscribers: lldb-commits, kristof.beyls, srhines. Herald added a project: LLDB. Disabling this assert prevents lldb-server from crashing, which prevents it from finding the user and group names

[Lldb-commits] [PATCH] D68316: [Host] Return the user's shell from GetDefaultShell

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham, friss. LLDB handles shell expansion by running lldb-argdumper under a shell. Currently, this is always `/bin/sh` on POSIX. This potentially leads to different behavior between lldb and the user's current shell. He

[Lldb-commits] [PATCH] D68316: [Host] Return the user's shell from GetDefaultShell

friss added inline comments. Comment at: lldb/lit/Host/TestCustomShell.test:5 +# RUN: SHELL=bogus %lldb %t.out -b -o 'run' 2>&1 | FileCheck %s +# CHECK: error: shell expansion failed Is there a reliable way to check that the expansion we get in lldb matches the

[Lldb-commits] [PATCH] D68317: factor out an abstract base class for File

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added a parent revision: D68181: SBDebugger::SetInputFile, SetOutputFile, etc.. lawrence_danna added a child revision: D68188: allow arbitrary pyth

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222749. lawrence_danna added a comment. updated based on an abstract base clase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SB

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1689544 , @labath wrote: > This way the decision whether to "own" something is decoupled from the > decision what api do you use to actually write to the file, and I _think_ it > would make things clearer. What d

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222750. lawrence_danna added a comment. rename LLDBPythonFile -> OwnedPythonFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/S

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222751. lawrence_danna added a comment. style fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/include/lldb/Hos

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov added a comment. I've made it in the way similar to Zachary have made for the `SymbolFileNativePDB` plugin. An environment variable could be more convenient e.g. to run a bunch of tests using the `lldb-test` option. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov added a comment. In D68258#1690756 , @aleksandr.urakov wrote: > I've made it in the way similar to Zachary have made for the > `SymbolFileNativePDB` plugin. An environment variable could be more > convenient e.g. to run a bunch of tests

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222753. lawrence_danna added a comment. use a python helper instead of funny tag structs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/ll

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBFile.h:16-21 +/* These tags make no difference at the c++ level, but + * when the constructors are called from python they control + * how python files are c

[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU

jarin updated this revision to Diff 222756. jarin added a comment. I have added some comments to the test (I hope it is not too overboard), removed the LEVEL stuff from the Makefile and fixed the formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68278/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU

jarin updated this revision to Diff 222757. jarin added a comment. Fixed a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68278/new/ https://reviews.llvm.org/D68278 Files: packages/Python/lldbsuite/test/lang/cpp/nested-class-other-compilation-unit/Makefile packages/Python/ll

[Lldb-commits] [PATCH] D68316: [Host] Return the user's shell from GetDefaultShell

JDevlieghere updated this revision to Diff 222759. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Check pointer returned by `getpwuid`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68316/new/ https://reviews.llvm.org/D68316 Files: lldb/lit/Host/Inputs/s

[Lldb-commits] [PATCH] D68316: [Host] Return the user's shell from GetDefaultShell

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/lit/Host/TestCustomShell.test:5 +# RUN: SHELL=bogus %lldb %t.out -b -o 'run' 2>&1 | FileCheck %s +# CHECK: error: shell expansion failed JDevlieghere wrote: > fris

[Lldb-commits] [PATCH] D68316: [Host] Return the user's shell from GetDefaultShell

JDevlieghere added inline comments. Comment at: lldb/lit/Host/TestCustomShell.test:5 +# RUN: SHELL=bogus %lldb %t.out -b -o 'run' 2>&1 | FileCheck %s +# CHECK: error: shell expansion failed friss wrote: > Is there a reliable way to check that the expansion we get