JDevlieghere marked an inline comment as done. JDevlieghere added inline comments.
================ Comment at: lldb/source/Utility/StructuredData.cpp:48 } - - JSONParser json_parser(buffer_or_error.get()->getBuffer()); - return_sp = ParseJSONValue(json_parser); - return return_sp; + return ParseJSON(buffer_or_error.get()->getBuffer().str()); } ---------------- aprantl wrote: > does this propagate the error into `error`? No, `ParseJSON(std::string)` doesn't provide error handling. We probably should add that, but that would mean changing all the call sites. I'd prefer to keep that separate from the JSON change. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68282/new/ https://reviews.llvm.org/D68282 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
