labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you.
https://reviews.llvm.org/D48665
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: labath
Date: Thu Jun 28 03:03:42 2018
New Revision: 335822
URL: http://llvm.org/viewvc/llvm-project?rev=335822&view=rev
Log:
Retrieve a function PDB symbol correctly from nested blocks
Summary:
This patch fixes a problem with retrieving a function symbol by an
address in a nested block. I
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D48463#1145434, @teemperor wrote:
> Well in theory we could poke more holes in our guard from some nested
> function, but this only fixes the deadlock sym
Author: labath
Date: Thu Jun 28 07:23:04 2018
New Revision: 335859
URL: http://llvm.org/viewvc/llvm-project?rev=335859&view=rev
Log:
Skip core file tests on build configurations lacking necessary components
Summary:
To successfully open a core file, we need to have LLVM built with
support for the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335859: Skip core file tests on build configurations lacking
necessary components (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.
labath added inline comments.
Comment at: source/Interpreter/OptionValueUUID.cpp:82
+ llvm::SmallVector uuid_bytes;
+ UUID::DecodeUUIDBytesFromString(s, uuid_bytes);
for (size_t i = 0; i < num_modules; ++i) {
clayborg wrote:
> Probably should hav
labath updated this revision to Diff 153321.
labath added a comment.
Add a check to the tab-completion function.
https://reviews.llvm.org/D48633
Files:
include/lldb/Utility/UUID.h
source/Interpreter/OptionValueUUID.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Utility/UUID.
davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.
Can you write a unittest for this? Thanks.
https://reviews.llvm.org/D48704
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335905: Added test case for: r334978 - Fixed file
completion for paths that start with… (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:/
Author: stella.stamenova
Date: Thu Jun 28 12:42:30 2018
New Revision: 335906
URL: http://llvm.org/viewvc/llvm-project?rev=335906&view=rev
Log:
[lldbsuite] Fix TestBreakpointHitCount on Windows
Summary: On Windows, the newer DIA SDKs end up producing function names that
contain the return type as
Author: jingham
Date: Thu Jun 28 13:02:11 2018
New Revision: 335912
URL: http://llvm.org/viewvc/llvm-project?rev=335912&view=rev
Log:
Add a way to load an image using a library name and list of paths.
This provides an efficient (at least on Posix platforms) way to offload to the
target process th
stella.stamenova added a comment.
This test fails on Windows with the Visual Studio generator.
##[error]llvm\tools\lldb\unittests\interpreter\testcompletion.cpp(291,0):
Error : Value of: ContainsExactString(Twine("~/foo") + path::get_separator() +
"nested" + path::get_separator(), Results)
teemperor created this revision.
teemperor added a reviewer: stella.stamenova.
The test fails because we don't rewrite the slash behind `foo` to the OS
specific
separator (as the completion API doesn't support this kind of rewriting).
However,
we assume that this part of the string is rewritten
teemperor added a comment.
@stella.stamenova I don't have access to a Windows machine. Would you mind
testing if this fixes the issue?
https://reviews.llvm.org/D48746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
teemperor updated this revision to Diff 153408.
teemperor added a comment.
- Fixed an syntax error. Should work now.
https://reviews.llvm.org/D48746
Files:
unittests/Interpreter/TestCompletion.cpp
Index: unittests/Interpreter/TestCompletion.cpp
==
stella.stamenova accepted this revision.
stella.stamenova added a comment.
The test passes with the fix. Thanks!
https://reviews.llvm.org/D48746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335934: Fix path completion test case added in rL335905 on
Windows (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D487
kastiglione created this revision.
kastiglione added reviewers: clayborg, jingham.
Within .lldbinit, regex commands can be structured as a list of substitutions
over
multiple lines. It's possible that this is uninentional, but it works and has
benefits.
For example:
command regex
s/pat1/re
jingham added a comment.
This behavior change seems desirable. But there are other commands that use
the IOHandlerActivated method to print instructions like this, and should get
the same treatment (breakpoint command add, type summary add...). It seems
ugly to have to do this one by one in i
19 matches
Mail list logo
