labath added inline comments.
================
Comment at: source/Interpreter/OptionValueUUID.cpp:82
+ llvm::SmallVector<uint8_t, 20> uuid_bytes;
+ UUID::DecodeUUIDBytesFromString(s, uuid_bytes);
for (size_t i = 0; i < num_modules; ++i) {
----------------
clayborg wrote:
> Probably should have a return value that indicates success or not. What if
> the user enters "aab". The string must have an event number of hex digits.
The function returns the unparsed portion of the string (so empty string means
success), but this code wasn't checking it for some reason.
I've added a check for that.
https://reviews.llvm.org/D48633
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
