jingham added a comment.

This behavior change seems desirable.  But there are other commands that use 
the IOHandlerActivated method to print instructions like this, and should get 
the same treatment (breakpoint command add, type summary add...).  It seems 
ugly to have to do this one by one in individual commands.

The IOHandlerDelegate is a pretty general class, so I don't think it is right 
for the IOHandler to only dispatch "IOHandlerActivated" to it when interactive. 
 There's no requirement that the work you do in this method is only useful when 
interactive.  But it might work if the IOHandlerDelegate could say whether it 
wants to be notified for IOHandlerActivated when non-interactive (like have a 
"ShouldNotifyWhenNonInteractive" method), and then the IOHandler could dispatch 
it or not based on the response to that method.


https://reviews.llvm.org/D48752



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to