Re: [Lldb-commits] [lldb] r335431 - Make testcase classnames unique

BTW, the format of the test trace file names is configurable with a command line option (--session-file-format). Since we already have code which enforces that every test file name is unique, we might want to swap the default format to use the file name instead of the class name. On Sun, 24 Jun 201

Re: [Lldb-commits] [lldb] r335432 - [FileSpec] Always normalize

I believe the raison d'être of the needsNormalization function was the normalization process is not exactly cheap (it constructs a vector of StringRefs and whatnot), and measurements showed that this actually is important for performance of lldb . On Sun, 24

[Lldb-commits] [lldb] r335448 - Revert "[FileSpec] Always normalize"

Author: jdevlieghere Date: Mon Jun 25 03:11:53 2018 New Revision: 335448 URL: http://llvm.org/viewvc/llvm-project?rev=335448&view=rev Log: Revert "[FileSpec] Always normalize" This reverts r335432 because remove_dots() is expensive and measuring its impact showed an observable performance regress

Re: [Lldb-commits] [lldb] r335432 - [FileSpec] Always normalize

Thanks. Reverted in r335448. On Mon, Jun 25, 2018 at 9:59 AM Pavel Labath wrote: > I believe the raison d'être of the needsNormalization function was the > normalization process is not exactly cheap (it constructs a vector of > StringRefs and whatnot), and measurements showed that this actually

Re: [Lldb-commits] [lldb] r335431 - Make testcase classnames unique

On Mon, 25 Jun 2018 10:52:57 +0200, Pavel Labath wrote: > BTW, the format of the test trace file names is configurable with a > command line option (--session-file-format). Since we already have > code which enforces that every test file name is unique, we might want > to swap the default format to

[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

clayborg added inline comments. Comment at: tools/lldb-mi/MICmdCmdExec.cpp:139 + const CMIUtilString &rErrMsg(CMIDriver::Instance().GetErrorDescription()); + this->SetError(CMIUtilString::Format( + MIRSRC(IDS_CMD_ERR_SET_NEW_DRIVER_STATE), any

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

clayborg added a comment. LGTM. Ok when Adrian is happy with testing changes. https://reviews.llvm.org/D48520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r335476 - Fix TestThreadExit for gcc&libc++ combo

Author: labath Date: Mon Jun 25 07:28:38 2018 New Revision: 335476 URL: http://llvm.org/viewvc/llvm-project?rev=335476&view=rev Log: Fix TestThreadExit for gcc&libc++ combo pseudo_barrier_wait() begins by decrementing an atomic variable. Since these are always_inline in libc++, there is no line t

[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

apolyakov updated this revision to Diff 152694. apolyakov added a comment. Removed unnecessary `this->`. https://reviews.llvm.org/D47992 Files: tools/lldb-mi/MICmdCmdExec.cpp tools/lldb-mi/MICmdCmdExec.h Index: tools/lldb-mi/MICmdCmdExec.h ==

[Lldb-commits] [PATCH] D48479: Represent invalid UUIDs as UUIDs with length zero

labath added a comment. In https://reviews.llvm.org/D48479#1141274, @clayborg wrote: > Would love to remove the "accept_zeroes" argument everywhere. Too much > matching happens in LLDB and we can't have multiple shared libraries claiming > zeros as their UUID A zero UUID is a problem only if

[Lldb-commits] [PATCH] D48479: Represent invalid UUIDs as UUIDs with length zero

labath updated this revision to Diff 152699. labath added a comment. - Use static factory functions instead of the extra argument (the best names I could come up with is fromData and fromOptionalData). https://reviews.llvm.org/D48479 Files: include/lldb/Utility/UUID.h source/API/SBModuleSp

[Lldb-commits] [PATCH] D48479: Represent invalid UUIDs as UUIDs with length zero

clayborg added a comment. We should allow 4 and 8 byte UUIDs as pointed out by inlined comments. This means we should probably modify the UUID dumper to handle those cases as well. Comment at: include/lldb/Utility/UUID.h:109 + + uint32_t m_num_uuid_bytes = 0; // Should be 0,

[Lldb-commits] [PATCH] D48479: Represent invalid UUIDs as UUIDs with length zero

clayborg added a comment. Factory methods make things much clearer. https://reviews.llvm.org/D48479 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48500: [DWARFASTParser] Remove special cases for `llvm-gcc`

labath added a comment. I suppose this is fine. My main worry is whether llvm-gcc is the *only* situation where we rely on these tweaks, but I guess the best way to find out is to try removing them. https://reviews.llvm.org/D48500 ___ lldb-commits

[Lldb-commits] [PATCH] D48479: Represent invalid UUIDs as UUIDs with length zero

labath added inline comments. Comment at: include/lldb/Utility/UUID.h:109 + + uint32_t m_num_uuid_bytes = 0; // Should be 0, 16 or 20 ValueType m_uuid; clayborg wrote: > Do we need this comment here? We currently take a 4 byte debug info CRC and > call it a

Re: [Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

On Fri, 22 Jun 2018 at 18:42, Jim Ingham wrote: > > > > > On Jun 22, 2018, at 4:05 AM, Pavel Labath wrote: > > > > On Wed, 20 Jun 2018 at 23:21, Jim Ingham wrote: > >> > >> It is not uncommon that you would be parsing the DWARF for module A and > >> find a type that is only known as a forward d

[Lldb-commits] [lldb] r335489 - [LLDB] Select helper sign comparison fix

Author: devnexen Date: Mon Jun 25 09:10:20 2018 New Revision: 335489 URL: http://llvm.org/viewvc/llvm-project?rev=335489&view=rev Log: [LLDB] Select helper sign comparison fix The constant could be unsigned thus explicit cast to silent compilation warnings Reviewers: aprantl Reviewed By: aprant

[Lldb-commits] [PATCH] D48479: Represent invalid UUIDs as UUIDs with length zero

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Patch is good. Feel free to remove the DataExtractor::DumpUUID() in a separate NFC commit or just remove it in this patch Comment at: source/Utility/DataExtractor.cpp:11

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

apolyakov updated this revision to Diff 152715. apolyakov added a comment. Removed duplicated and error prone(without --synchronous option) testing. https://reviews.llvm.org/D48520 Files: lit/tools/lldb-mi/exec/exec-finish.test lit/tools/lldb-mi/exec/exec-interrupt.test lit/tools/lldb-mi/

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:228 -# Test that --thread is optional -self.runCmd("-exec-next-instruction --frame 0") -self.expect("\^running") Is this combina

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

apolyakov added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:228 -# Test that --thread is optional -self.runCmd("-exec-next-instruction --frame 0") -self.expect("\^running") aprantl wrote

[Lldb-commits] [lldb] r335541 - Implement new methods for handling an error in MI commands.

Author: apolyakov Date: Mon Jun 25 15:01:44 2018 New Revision: 335541 URL: http://llvm.org/viewvc/llvm-project?rev=335541&view=rev Log: Implement new methods for handling an error in MI commands. Summary: The new methods take SBError object and call handler, specified by user, depending on SBErro

[Lldb-commits] [PATCH] D48295: Implement new methods for handling an error in MI commands.

This revision was automatically updated to reflect the committed changes. Closed by commit rL335541: Implement new methods for handling an error in MI commands. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48

[Lldb-commits] [lldb] r335552 - Fix windows build for r335541.

Author: apolyakov Date: Mon Jun 25 16:29:52 2018 New Revision: 335552 URL: http://llvm.org/viewvc/llvm-project?rev=335552&view=rev Log: Fix windows build for r335541. I didn't include header and used std::function. Modified: lldb/trunk/tools/lldb-mi/MICmdBase.h Modified: lldb/trunk/tools/l

[Lldb-commits] [lldb] r335556 - A little cleanup in ObjectFileMachO::GetSDKVersion.

Author: jmolenda Date: Mon Jun 25 16:45:39 2018 New Revision: 335556 URL: http://llvm.org/viewvc/llvm-project?rev=335556&view=rev Log: A little cleanup in ObjectFileMachO::GetSDKVersion. This method does one of two things: 1. finds a minimum os deployment version # in a Mach-O load command and

[Lldb-commits] Adding a test for split-dwarf

This is a first draft. Just trying to do some basic breakpoint and line number checks on a split dwarf compiled binary for now. Also, is there an LLDB phabricator? I didn't notice it in the project listing in reviews.llvm.org. PL commit 901971ff8bfcc42679eb8113b5f2a251bc0b9094 Author: Puyan Lotf