clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Patch is good. Feel free to remove the DataExtractor::DumpUUID() in a separate
NFC commit or just remove it in this patch
================
Comment at: source/Utility/DataExtractor.cpp:1101
//----------------------------------------------------------------------
void DataExtractor::DumpUUID(Stream *s, offset_t offset) const {
if (s) {
----------------
labath wrote:
> clayborg wrote:
> > This should take a UUID byte size as a second parameter and callers should
> > be required to specify it explicitly
> Hmm.. this is actually unused. Can I just remove it?
Yes, please remove.
https://reviews.llvm.org/D48479
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
