Re: [Lldb-commits] [lldb] r335431 - Make testcase classnames unique

[Pavel Labath via lldb-commits]

BTW, the format of the test trace file names is configurable with a
command line option (--session-file-format). Since we already have
code which enforces that every test file name is unique, we might want
to swap the default format to use the file name instead of the class
name.
On Sun, 24 Jun 2018 at 11:41, Jan Kratochvil via lldb-commits
<lldb-commits@lists.llvm.org> wrote:
>
> Author: jankratochvil
> Date: Sun Jun 24 03:36:44 2018
> New Revision: 335431
>
> URL: http://llvm.org/viewvc/llvm-project?rev=335431&view=rev
> Log:
> Make testcase classnames unique
>
> Filenames with test results contain only the class name which makes it more
> difficult to find it if the same class name is present in multiple *.py files.
>
> packages/Python/lldbsuite/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py
> -class ReturnValueTestCase(TestBase):
> +class StepAvoidsNoDebugTestCase(TestBase):
> as ReturnValueTestCase is already present in:
> packages/Python/lldbsuite/test/functionalities/return-value/TestReturnValue.py
>
> packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py
> -class CreateDuringStepTestCase(TestBase):
> +class CrashDuringStepTestCase(TestBase):
> as CreateDuringStepTestCase is already present in:
> packages/Python/lldbsuite/test/functionalities/thread/create_during_step/TestCreateDuringStep.py
>
> packages/Python/lldbsuite/test/functionalities/thread/step_until/TestStepUntil.py
> -class TestCStepping(TestBase):
> +class StepUntilTestCase(TestBase):
> as TestCStepping is already present in:
> packages/Python/lldbsuite/test/lang/c/stepping/TestStepAndBreakpoints.py
>
> Modified:
>     
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py
>     
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py
>     
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/step_until/TestStepUntil.py
>
> Modified: 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py
> URL: 
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py?rev=335431&r1=335430&r2=335431&view=diff
> ==============================================================================
> --- 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py
>  (original)
> +++ 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py
>  Sun Jun 24 03:36:44 2018
> @@ -15,7 +15,7 @@ from lldbsuite.test.lldbtest import *
>  from lldbsuite.test import lldbutil
>
>
> -class ReturnValueTestCase(TestBase):
> +class StepAvoidsNoDebugTestCase(TestBase):
>
>      mydir = TestBase.compute_mydir(__file__)
>
>
> Modified: 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py
> URL: 
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py?rev=335431&r1=335430&r2=335431&view=diff
> ==============================================================================
> --- 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py
>  (original)
> +++ 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py
>  Sun Jun 24 03:36:44 2018
> @@ -12,7 +12,7 @@ from lldbsuite.test.lldbtest import *
>  from lldbsuite.test import lldbutil
>
>
> -class CreateDuringStepTestCase(TestBase):
> +class CrashDuringStepTestCase(TestBase):
>
>      mydir = TestBase.compute_mydir(__file__)
>
>
> Modified: 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/step_until/TestStepUntil.py
> URL: 
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/step_until/TestStepUntil.py?rev=335431&r1=335430&r2=335431&view=diff
> ==============================================================================
> --- 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/step_until/TestStepUntil.py
>  (original)
> +++ 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/step_until/TestStepUntil.py
>  Sun Jun 24 03:36:44 2018
> @@ -11,7 +11,7 @@ from lldbsuite.test.lldbtest import *
>  from lldbsuite.test import lldbutil
>
>
> -class TestCStepping(TestBase):
> +class StepUntilTestCase(TestBase):
>
>      mydir = TestBase.compute_mydir(__file__)
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits