labath added a comment.
Do you have a test for this patch?
Repository:
rL LLVM
https://reviews.llvm.org/D39825
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317779: Simplify
NativeProcessProtocol::GetArchitecture/GetByteOrder (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D39733
Files:
lldb/trunk/include/lldb/Host/common/NativeProces
Author: labath
Date: Thu Nov 9 02:43:16 2017
New Revision: 317779
URL: http://llvm.org/viewvc/llvm-project?rev=317779&view=rev
Log:
Simplify NativeProcessProtocol::GetArchitecture/GetByteOrder
Summary:
These functions used to return bool to signify whether they were able to
retrieve the data. Th
alexandreyy updated this revision to Diff 14.
alexandreyy added a comment.
Update according to reviews.
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionalities/postmortem/
alexandreyy added a comment.
Thanks for all the reviews @labath and @clayborg.
I changed the code to use the DenseMap and added the files for testing.
The backtrace is not working properly yet,
It is showing all frames, just the current.
Am I missing something?
https://reviews.llvm.org/D39681
labath added a comment.
I'm not sure what's the problem with backtracing without more info, but the
nice thing about core files is that you can open a ppc and x86 one side by side
and see how for do you get before things start to diverge. The interesting
commands you can start with are "image l
labath created this revision.
Herald added subscribers: kbarton, kristof.beyls, arichardson, javed.absar,
nemanjai, sdardis, aemerson.
This commit removes the concrete_frame_idx member from
NativeRegisterContext and related functions, which was always set to
zero and never used.
I also change th
alexandreyy updated this revision to Diff 122239.
alexandreyy marked an inline comment as done.
alexandreyy added a comment.
Moved core enums to header file.
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages
alexandreyy added a comment.
In https://reviews.llvm.org/D39681#920349, @labath wrote:
> I'm not sure what's the problem with backtracing without more info, but the
> nice thing about core files is that you can open a ppc and x86 one side by
> side and see how for do you get before things start
Author: labath
Date: Thu Nov 9 07:06:31 2017
New Revision: 317792
URL: http://llvm.org/viewvc/llvm-project?rev=317792&view=rev
Log:
Add a unit test for ClangASTContext template arguments handling
I am planning to make changes to this piece of code, so I wrote this
test to add more coverage to it
labath created this revision.
Despite it's name, GetTemplateArgument was only really working for Type
template arguments. This adds the ability to retrieve integral arguments
as well (which I've needed for the std::bitset data formatter).
I've done this by splitting the function into three pieces
labath added inline comments.
Comment at: source/API/SBType.cpp:422
+ CompilerType template_arg_type =
+ m_opaque_sp->GetCompilerType(false).GetTypeTemplateArgument(idx);
+ if (template_arg_type.IsValid())
I should point out that this changes the behaviour
labath added a comment.
Thank you. I've just noticed a couple of details we should address.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:1
+//===-- ProcessElfCore.cpp --*- C++
-*-===//
+//
Please update the f
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317795: llgs-tests: Replace the "log+return false" pattern
with llvm::Error (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D39790
Files:
lldb/trunk/source/Plugins/Process/gdb-rem
Author: labath
Date: Thu Nov 9 07:45:09 2017
New Revision: 317795
URL: http://llvm.org/viewvc/llvm-project?rev=317795&view=rev
Log:
llgs-tests: Replace the "log+return false" pattern with llvm::Error
Summary:
These tests used to log the error message and return plain bool mainly
because at the t
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine to me as long as you got a clean test suite run. Be sure to keep an
eye on the buildbots after this goes in.
Repository:
rL LLVM
https://reviews.llvm.org/D39825
_
clayborg added a comment.
If no tests currently fail due to this, then we need to add some.
Repository:
rL LLVM
https://reviews.llvm.org/D39825
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
tberghammer added a comment.
How are you end up calling SymbolFileDWARFDwo::Index? If I remember correctly
you are not supposed to index a dwo file directly because without the main
object file you won't have all of the necessary information.
Repository:
rL LLVM
https://reviews.llvm.org/D39
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just a few changes.
- I would like the see the SBType returned for the integer template types as it
is what I would expect to happen.
- we should add default implementations for
krytarowski added a comment.
The NetBSD part looks fine.
https://reviews.llvm.org/D39837
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added inline comments.
Comment at: include/lldb/Symbol/TypeSystem.h:356-360
+ virtual CompilerType GetTypeTemplateArgument(lldb::opaque_compiler_type_t
type,
+ size_t idx) = 0;
+ virtual std::pair
+ GetIntegralTemplateArgumen
alexshap added a comment.
@tberghammer - for example, any call of
SymbolFileDWARF::FindCompleteObjCDefinitionTypeForDIE (with an object of the
type SymbolFileDWARFDwo)
will trigger indexing of the dwo file.
@labath - yeah, i will add a test & update this patch
Repository:
rL LLVM
https://r
alexandreyy updated this revision to Diff 122265.
alexandreyy added a comment.
Changed namespaces in core enums.
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionalities/postmo
labath added a comment.
In https://reviews.llvm.org/D39844#920621, @clayborg wrote:
> Just a few changes.
>
> - I would like the see the SBType returned for the integer template types as
> it is what I would expect to happen.
I tried to explain my reasoning in the inline comments. I don't feel
zturner added inline comments.
Comment at: unittests/Symbol/TestClangASTContext.cpp:418-419
-arg = m_ast->GetTemplateArgument(t.GetOpaqueQualType(), 1, kind);
-EXPECT_EQ(kind, eTemplateArgumentKindIntegral);
-EXPECT_EQ(arg, int_type);
+EXPECT_EQ(m_ast->GetTempla
tberghammer added a comment.
I never tried debugging Objective-C using dwo but I am pretty sure this won't
fix the issue you are seeing for FindCompleteObjCDefinitionTypeForDIE correctly
because this way you will index the compile unit twice (once from the main
object file and once from the dwo
clayborg added a comment.
I see your point. But if we do ask a template parameter for its type, I would
like to be able to get it's type somehow. Seems wrong to leave this out. I know
it doesn't mirror clang, but we should do the right thing here. At least at the
SB API layer. I am fine with le
alexandreyy updated this revision to Diff 122276.
alexandreyy added a comment.
Fixed test identation
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionalities/postmortem/elf-cor
alexshap added a comment.
@tberghammer, SymbolFileDWARF (the base class of SymbolFileDWARFDwo) calls
Index()
"lazily" in may places, so indexing of dwo happens almost inevitably (at the
moment)
(FindCompleteObjCDefinitionTypeForDIE is just one example).
> because this way you will index the c
alexshap added a comment.
i'd like to think about this problem a little bit more (maybe i'm missing smth)
+ as i said above - will add a test
Repository:
rL LLVM
https://reviews.llvm.org/D39825
___
lldb-commits mailing list
lldb-commits@lists.ll
labath added inline comments.
Comment at: unittests/Symbol/TestClangASTContext.cpp:418-419
-arg = m_ast->GetTemplateArgument(t.GetOpaqueQualType(), 1, kind);
-EXPECT_EQ(kind, eTemplateArgumentKindIntegral);
-EXPECT_EQ(arg, int_type);
+EXPECT_EQ(m_ast->GetTemplat
tberghammer added a comment.
In https://reviews.llvm.org/D39825#920739, @alexshap wrote:
> @tberghammer, SymbolFileDWARF (the base class of SymbolFileDWARFDwo) calls
> Index()
> "lazily" in may places, so indexing of dwo happens almost inevitably (at the
> moment)
> (FindCompleteObjCDefiniti
alexshap added a comment.
> The main point is that you should almost always interact with the
> SymbolFileDWARF instance belonging to the main object file and it
> (actually DWARFCompileUnit) will know when to access data from the Dwo >file
> instead.
> The original goal was to not leak pointe
labath added a comment.
In https://reviews.llvm.org/D39844#920722, @clayborg wrote:
> I see your point. But if we do ask a template parameter for its type, I would
> like to be able to get it's type somehow. Seems wrong to leave this out. I
> know it doesn't mirror clang, but we should do the r
alexshap updated this revision to Diff 122389.
alexshap added a comment.
Change the approach: add assert to ensure we don't double index .dwo files,
rerun the tests.
@tberghammer - many thanks for the suggestions.
p.s. didn't add new tests (in this commit) - standalone repo is not trivial
(objc
35 matches
Mail list logo
