labath added a comment.
Thank you. I've just noticed a couple of details we should address.
================
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:1
+//===-- ProcessElfCore.cpp --------------------------------------*- C++
-*-===//
+//
----------------
Please update the file name here and add header guards.
================
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:11
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
----------------
I'm sorry for the back and forth, but since we're already moving these, I think
we should also put these into a linux namespace, as these are really
linux-specific constants (except the NT_OPENBSD_*** ones, which should
obviously get a namespace of their own (`namespace OPENBSD { enum {NT_PROCINFO
= ...}; }`)).
https://reviews.llvm.org/D39681
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
