zturner added a comment.
Hi Greg, are you going to have a chance to try this out today?
http://reviews.llvm.org/D18381
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner requested changes to this revision.
zturner added a comment.
This revision now requires changes to proceed.
Mostly small comments, but a lot of them. Mostly around style issues such as
indentation, putting platform specific `#defines` in the right header file, and
some nuances around `_
zturner added inline comments.
Comment at: source/API/SystemInitializerFull.cpp:90
@@ -89,3 +89,3 @@
-#if defined(_MSC_VER)
+#if defined(_MSC_VER) || defined(__MINGW32__)
#include "lldb/Host/windows/windows.h"
Just use `LLVM_ON_WIN32` for both of these places,
zturner added a comment.
Everywhere I said `LLVM_ON_WINDOWS` earlier, it's actually called
`LLVM_ON_WIN32`.
http://reviews.llvm.org/D18519
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
zturner added inline comments.
Comment at: source/API/SystemInitializerFull.cpp:90
@@ -89,3 +89,3 @@
-#if defined(_MSC_VER)
+#if defined(_MSC_VER) || defined(__MINGW32__)
#include "lldb/Host/windows/windows.h"
eran.ifrah wrote:
> zturner wrote:
> > Just use `LL
amccarth added a subscriber: amccarth.
amccarth added a comment.
I'm not a CMake expert, so I haven't really reviewed those bits.
Comment at: cmake/modules/LLDBConfig.cmake:253
@@ -250,2 +252,3 @@
+else()
add_definitions( /D _UNICODE /D UNICODE )
endif()
---
Author: spyffe
Date: Mon Mar 28 16:07:53 2016
New Revision: 264659
URL: http://llvm.org/viewvc/llvm-project?rev=264659&view=rev
Log:
Removed an override of LookupSymbol that mistakenly disabled it for Clang.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.h
Author: spyffe
Date: Mon Mar 28 16:10:36 2016
New Revision: 264660
URL: http://llvm.org/viewvc/llvm-project?rev=264660&view=rev
Log:
Don't try to actually run code when the expression is top-level.
Modified:
lldb/trunk/source/Expression/UserExpression.cpp
Modified: lldb/trunk/source/Expressi
eran.ifrah created this revision.
eran.ifrah added a reviewer: zturner.
eran.ifrah added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
As the title
http://reviews.llvm.org/D18519
Files:
CMakeLists.txt
cmake/modules/AddLLDB.cmake
cmake/modules/LLDBC
eran.ifrah created this revision.
eran.ifrah added a reviewer: zturner.
eran.ifrah added a subscriber: lldb-commits.
Initialize ProcessWindowsLive when building LLDB with MinGW
http://reviews.llvm.org/D18520
Files:
source/API/SystemInitializerFull.cpp
Index: source/API/SystemInitializerFull.c
eran.ifrah added inline comments.
Comment at: source/API/SystemInitializerFull.cpp:90
@@ -89,3 +89,3 @@
-#if defined(_MSC_VER)
+#if defined(_MSC_VER) || defined(__MINGW32__)
#include "lldb/Host/windows/windows.h"
zturner wrote:
> Just use `LLVM_ON_WIN32` for bo
Author: spyffe
Date: Mon Mar 28 16:20:05 2016
New Revision: 264662
URL: http://llvm.org/viewvc/llvm-project?rev=264662&view=rev
Log:
Expose top-level Clang expressions via the command line and the API.
Top-level Clang expressions are expressions that act as new translation units,
and define their
N.b., the Clang ASTImporter fixes for this went in as r264669. Make sure Clang
has this fix if your testcases are failing.
Sean
> On Mar 28, 2016, at 2:20 PM, Sean Callanan via lldb-commits
> wrote:
>
> Author: spyffe
> Date: Mon Mar 28 16:20:05 2016
> New Revision: 264662
>
> URL: http://l
Author: zturner
Date: Mon Mar 28 17:53:41 2016
New Revision: 264685
URL: http://llvm.org/viewvc/llvm-project?rev=264685&view=rev
Log:
Move some functions from DWARFASTParserClang to ClangASTImporter.
This allows these functions to be re-used by a forthcoming
PDBASTParser. The functions in questi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264685: Move some functions from DWARFASTParserClang to
ClangASTImporter. (authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D18381?vs=51705&id=51848#toc
Repository:
rL LLVM
htt
zturner created this revision.
zturner added reviewers: spyffe, clayborg.
zturner added a subscriber: lldb-commits.
This is pretty mechanical, so you don't really have to look at this in too much
detail. I'm mostly posting it here to make sure people are ok with the high
level idea. Basically
fjricci created this revision.
fjricci added reviewers: tberghammer, ADodds, tfiala.
fjricci added subscribers: sas, lldb-commits.
The logic to read modules from memory was added to LoadModuleAtAddress
in the dynamic loader, but not in process gdb remote. This means that when
the remote uses svr4
eran.ifrah updated this revision to Diff 51873.
eran.ifrah marked 21 inline comments as done.
eran.ifrah added a comment.
An updated patch that fixes all your comments and in includes this one as well:
http://reviews.llvm.org/D18520
I also added new command line argument option to `CMake` : `-DMI
It's night here, so I will have a detailed look tomorrow. But in the
meantime, some of the issues don't appear to be addressed. For example the
issue about why logging is disabled, the disabled code in
ProcessWinMiniDump.cpp, and a few other things. If you view the diff in
Phabricator, you can r
zturner added a subscriber: zturner.
zturner added a comment.
It's night here, so I will have a detailed look tomorrow. But in the
meantime, some of the issues don't appear to be addressed. For example the
issue about why logging is disabled, the disabled code in
ProcessWinMiniDump.cpp, and a fe
20 matches
Mail list logo
