zturner added inline comments.
================
Comment at: source/API/SystemInitializerFull.cpp:90
@@ -89,3 +89,3 @@
-#if defined(_MSC_VER)
+#if defined(_MSC_VER) || defined(__MINGW32__)
#include "lldb/Host/windows/windows.h"
----------------
eran.ifrah wrote:
> zturner wrote:
> > Just use `LLVM_ON_WIN32` for both of these places, otherwise looks good.
> I tried using `LLVM_ON_WIN32` but it does not defined with MinGW ( to
> confirm this, I placed an `#error` directive to ensure that it does not reach
> there, so I ended up using `__MINGW32__` which is defined for both MinGW32
> and 64
Strange, I looked at the CMake code in `HandleLLVMOptions.cmake` and it says
this:
```
if(WIN32)
set(LLVM_HAVE_LINK_VERSION_SCRIPT 0)
if(CYGWIN)
set(LLVM_ON_WIN32 0)
set(LLVM_ON_UNIX 1)
else(CYGWIN)
set(LLVM_ON_WIN32 1)
set(LLVM_ON_UNIX 0)
endif(CYGWIN)
```
So it `LLVM_ON_WIN32` should be false only if you are building from inside of
Cygwin. Is that the case for you?
What if you use `#if defined(_WIN32)`?
http://reviews.llvm.org/D18520
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
