zturner added a subscriber: zturner. zturner added a comment. It's night here, so I will have a detailed look tomorrow. But in the meantime, some of the issues don't appear to be addressed. For example the issue about why logging is disabled, the disabled code in ProcessWinMiniDump.cpp, and a few other things. If you view the diff in Phabricator, you can respond inline to each of those with some kind of explanation if possible.
http://reviews.llvm.org/D18519 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits