labath added a comment.
Looks good to me. :)
If you do end up adding a command line option, I think you can go for
`--enable-core-on-timeout` and default to off for all platforms. I suspect I am
the only one using this, and it makes a much safer default.
http://reviews.llvm.org/D13124
labath added a subscriber: labath.
labath added a comment.
In http://reviews.llvm.org/D12994#254468, @brucem wrote:
> I'm also not sure offhand how this would impact the Xcode build that the
> Apple folks use.
Since the xcode build is only used on Darwin, I think we can hardcode any
#defines
enlight added a comment.
I've updated the summary with the scenario. I don't know how one would go about
writing a test for this, mixed platform remote debugging is a bit finicky.
Comment at: source/Host/common/Symbols.cpp:238-250
@@ -237,15 +237,15 @@
// Add /usr/li
Author: labath
Date: Mon Sep 28 04:37:51 2015
New Revision: 248702
URL: http://llvm.org/viewvc/llvm-project?rev=248702&view=rev
Log:
Revert "Fix race condition during process detach"
This fix is not correct on its own until D12968 is resolved. Will resumbit once
that is done.
Modified:
lldb
labath added a comment.
I have reverted this for now. This fix is not complete without
http://reviews.llvm.org/D12968.
Repository:
rL LLVM
http://reviews.llvm.org/D13056
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
krytarowski added inline comments.
Comment at: include/lldb/Config/config.h.cmake:6
@@ +5,3 @@
+#else
+#define CONFIG_H
+
brucem wrote:
> brucem wrote:
> > This should be `LLDB_CONFIG_CONFIG_H` rather than just `CONFIG_H`.
> >
> > Also, why not use the same `#ifn
Author: labath
Date: Mon Sep 28 08:27:48 2015
New Revision: 248711
URL: http://llvm.org/viewvc/llvm-project?rev=248711&view=rev
Log:
Remove XTIMEOUT from TestProcessAttach on linux
Modified:
lldb/trunk/test/dosep.py
Modified: lldb/trunk/test/dosep.py
URL:
http://llvm.org/viewvc/llvm-project
KLapshin updated the summary for this revision.
KLapshin updated this revision to Diff 35865.
Repository:
rL LLVM
http://reviews.llvm.org/D12977
Files:
test/tools/lldb-mi/control/TestMiExec.py
tools/lldb-mi/MICmdCmdExec.cpp
tools/lldb-mi/MICmdCmdExec.h
tools/lldb-mi/MICmdCmdSupportList
KLapshin marked an inline comment as done.
KLapshin added a comment.
Requested changes applied, updated patch uploaded.
Comment at: tools/lldb-mi/MICmdCmdExec.h:58
@@ -57,2 +57,3 @@
bool Acknowledge() override;
+bool ParseArgs() override;
// From CMICmnBase
---
mohit.bhakkad updated this revision to Diff 35879.
mohit.bhakkad added a comment.
Adding a simple test to check displayed value of vector
Repository:
rL LLVM
http://reviews.llvm.org/D13202
Files:
source/Breakpoint/Watchpoint.cpp
test/functionalities/watchpoint/watchpoint_on_vectors/Makef
tfiala added a comment.
In http://reviews.llvm.org/D13124#254487, @labath wrote:
> Looks good to me. :)
>
> If you do end up adding a command line option, I think you can go for
> `--enable-core-on-timeout` and default to off for all platforms. I suspect I
> am the only one using this, and it m
Sorry, our desks were reconfigured over the weekend, so I just now got my
computer turned on. I'm syncing code and hopefully will have a working
build soon.
On Mon, Sep 28, 2015 at 9:28 AM Todd Fiala wrote:
> tfiala added a comment.
>
> In http://reviews.llvm.org/D13124#254487, @labath wrote:
>
Author: ovyalov
Date: Mon Sep 28 12:42:16 2015
New Revision: 248722
URL: http://llvm.org/viewvc/llvm-project?rev=248722&view=rev
Log:
Bind listener to 127.0.0.1 to make sure that loopback address is used.
Modified:
lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cp
tfiala added a comment.
In http://reviews.llvm.org/D13124#254900, @zturner wrote:
> Sorry, our desks were reconfigured over the weekend, so I just now got my
> computer turned on. I'm syncing code and hopefully will have a working
> build soon.
Sounds good. I expect you'll find a few things
tfiala added a comment.
In http://reviews.llvm.org/D13124#254935, @tfiala wrote:
> In http://reviews.llvm.org/D13124#254900, @zturner wrote:
>
> > Sorry, our desks were reconfigured over the weekend, so I just now got my
> > computer turned on. I'm syncing code and hopefully will have a working
zturner added a comment.
Looks good to me. Just add a decorator to both tests to skip unless the
compiler is gcc or clang ( `__attribute((vector_size))__` doesn't work on MSVC
or clang-cl, for example
Repository:
rL LLVM
http://reviews.llvm.org/D13202
__
zturner added a comment.
Actually I'm wrong. Leave it enabled and I'll see what happens. clang-cl
(which we require for windows tests) supports that syntax after all.
Repository:
rL LLVM
http://reviews.llvm.org/D13202
___
lldb-commits mailing
Can you rebase against ToT? I'm having trouble applying the patch.
On Mon, Sep 28, 2015 at 11:00 AM Todd Fiala wrote:
> tfiala added a comment.
>
> In http://reviews.llvm.org/D13124#254935, @tfiala wrote:
>
> > In http://reviews.llvm.org/D13124#254900, @zturner wrote:
> >
> > > Sorry, our desks
zturner added a comment.
Sorry, ignore me. My brain is just off, it's working
http://reviews.llvm.org/D13124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
In http://reviews.llvm.org/D13124#254950, @zturner wrote:
> Sorry, ignore me. My brain is just off, it's working
Okay, cool. Yeah I can update it if needed, I think I saw a 1-line dosep.py go
in between my last update late last night and early this morning. But it
s
This is what I get.
d:\src\llvm\tools\lldb\test>cd test_runner
d:\src\llvm\tools\lldb\test\test_runner>cd test
d:\src\llvm\tools\lldb\test\test_runner\test>c:\Python27_LLDB\x86\python_d.exe
process_control_tests.py
..E.EE
==
ERR
emaste added a comment.
No objection from me on the FreeBSD side. I'm leaving shortly to travel to
EuroBSDCon so probably will not be able to test before Wednesday, but I can
investigate and update decorators as appropriate afterwards.
http://reviews.llvm.org/D13028
tfiala added a comment.
In http://reviews.llvm.org/D13124#254958, @zturner wrote:
> This is what I get.
>
> d:\src\llvm\tools\lldb\test>cd test_runner
>
> d:\src\llvm\tools\lldb\test\test_runner>cd test
>
> d:\src\llvm\tools\lldb\test\test_runner\test>c:\Python27_LLDB\x86\python_d.exe
> process_
tfiala added a comment.
The "was_soft_terminate()" method is looking at the subprocess.Popen-like
object's returncode and, judging by that, certifying that it was (or was not) a
soft terminate that caused the exit.
If you need the Popen-like object to figure that out (e.g. if you need to look
As far as I can tell, the value of the return code is undocumented when you
use Popen.terminate() on Windows. I don't know what that means for the
patch. It's quite a bit more complicated than I anticipated based on the
original thread to lldb-dev. I thought it was just going to call
Popen.termi
tfiala added a comment.
In http://reviews.llvm.org/D13124#255034, @zturner wrote:
> As far as I can tell, the value of the return code is undocumented when you
> use Popen.terminate() on Windows.
Okay, interesting. I found what looked like a race on Linux and OS X where
calling the Popen-obj
tfiala added a comment.
> I can get that together (assuming option #1) relatively quickly.
>
> I don't think we can drop the complexity of the 2-tier kill level in the
> driver, though, given the desire to support core dump generation.
I'm not going to touch this until I hear back from you
Yea, on Windows we can support core dump generation externally without
touching the python script, so that's not neded for us.
Ironically, at the system level there is a way to specify the return code
of the process when you terminate it. And Python internally must be using
this API, because it's
tfiala added a comment.
In http://reviews.llvm.org/D13124#255044, @zturner wrote:
> Yea, on Windows we can support core dump generation externally without
> touching the python script, so that's not neded for us.
Okay, good!
> Ironically, at the system level there is a way to specify the retu
zturner added a comment.
A few more comments
Comment at: test/test_runner/test/process_control_tests.py:63
@@ +62,3 @@
+def _suppress_soft_terminate(cls, command):
+if platform.system() == 'nt':
+# Add whatever is needed to the command line to
---
Random thought: If you want to generate a core dump, we already have LLDB
attached to the process, so you have an SBProcess. Couldn't you use
Process.Halt, then call whatever method is necessary to have the debugger
create a core, then Process.Kill?
On Mon, Sep 28, 2015 at 1:03 PM Zachary Turner
sivachandra created this revision.
sivachandra added a reviewer: clayborg.
sivachandra added a subscriber: lldb-commits.
This change fixes pr24916. As associated test has been added.
http://reviews.llvm.org/D13224
Files:
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
test/lang/cpp/p
zturner added a subscriber: zturner.
zturner added a comment.
Can you change the name of the folder to something more descripive than
`pr24916`. For example, you could put `pr24916` in a comment in the test, but
the test itself could have a descriptive name. Enrico at Apple just went and
did
sivachandra updated this revision to Diff 35907.
sivachandra added a comment.
Rename test directory to limit-debug-info.
http://reviews.llvm.org/D13224
Files:
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
test/lang/cpp/limit-debug-info/Makefile
test/lang/cpp/limit-debug-info/Tes
zturner added a comment.
Makefile stuff looks good. Is the plan to do the same thing for the previous
patch you submitted last week? What's the status of that?
http://reviews.llvm.org/D13224
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
zturner added a comment.
As for the test, this could be a good candidate for a unit test. It's not
advertised very well so there's definitely some work for us to do on that
front, but basically you can run `ninja check-lldb-unit`. Seems like you could
just create a `ModuleSpec` on the stack,
sivachandra added a comment.
About Makefile changes in other tests, I will one day clean all places where
no-limit-debug-info shows up in the Makefile.
Just in case, zturner's comment about Makefiles on the other change came in a
day after I landed the change. So, I will have to do it in another
tfiala added inline comments.
Comment at: test/test_runner/test/process_control_tests.py:63
@@ +62,3 @@
+def _suppress_soft_terminate(cls, command):
+if platform.system() == 'nt':
+# Add whatever is needed to the command line to
zturner wro
zturner added inline comments.
Comment at: test/test_runner/test/process_control_tests.py:63
@@ +62,3 @@
+def _suppress_soft_terminate(cls, command):
+if platform.system() == 'nt':
+# Add whatever is needed to the command line to
tfiala wro
tfiala added a comment.
In http://reviews.llvm.org/D13124#255058, @zturner wrote:
> Random thought: If you want to generate a core dump, we already have LLDB
> attached to the process, so you have an SBProcess. Couldn't you use
> Process.Halt, then call whatever method is necessary to have the
zturner added inline comments.
Comment at: test/test_runner/test/process_control_tests.py:63
@@ +62,3 @@
+def _suppress_soft_terminate(cls, command):
+if platform.system() == 'nt':
+# Add whatever is needed to the command line to
zturner wr
zturner added a comment.
In http://reviews.llvm.org/D13124#255140, @tfiala wrote:
> In http://reviews.llvm.org/D13124#255058, @zturner wrote:
>
> > Random thought: If you want to generate a core dump, we already have LLDB
> > attached to the process, so you have an SBProcess. Couldn't you use
>
tfiala added a comment.
Ah I see I morphed all those together (the platform naming).
> ... bummed to see them under test_runner...
Heh, that's funny. I was attempting to do a service of decluttering that top
level test directory, which to me looks like somebody threw up a bunch of
python cod
tfiala added a comment.
In http://reviews.llvm.org/D13124#255142, @zturner wrote:
> In http://reviews.llvm.org/D13124#255140, @tfiala wrote:
>
> > In http://reviews.llvm.org/D13124#255058, @zturner wrote:
> >
> > > Random thought: If you want to generate a core dump, we already have LLDB
> > > a
zturner added a comment.
In http://reviews.llvm.org/D13124#255144, @tfiala wrote:
> Ah I see I morphed all those together (the platform naming).
>
> > ... bummed to see them under test_runner...
>
>
> Heh, that's funny. I was attempting to do a service of decluttering that top
> level test dire
Hi Sean, I was digging around in FileSystem.h and I noticed we already have
`FileSystem::Readlink`. Reading the documentation of `readlink` and
`realpath` there seem to be a few minor differences, but they are just that
- minor. I'm wondering if you actually *need* any semantics of `realpath`
tha
tfiala added a comment.
> If it weren't for the fact that we have all these switches on `os.name`,
> `sys.platform`, and `platform.system` inside the tests as well as the test
> running infrastructure, then hiding it would be good. But yea, the test
> suite itself is still really fragile due
Author: jmolenda
Date: Mon Sep 28 18:02:00 2015
New Revision: 248755
URL: http://llvm.org/viewvc/llvm-project?rev=248755&view=rev
Log:
Remove one of the three spaces after a period in one of the breakpoint
set help messages.
Modified:
lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp
tfiala updated this revision to Diff 35921.
tfiala added a comment.
Changes:
- soft terminate is now optional by platform, not supported by default, and
listed as supported on POSIX-y systems.
- run with timeout now uses soft terminate only when supported.
- soft terminate tests are now skipped
krytarowski updated this revision to Diff 35922.
krytarowski added a comment.
Fix typo.
Repository:
rL LLVM
http://reviews.llvm.org/D12994
Files:
CMakeLists.txt
cmake/LLDBDependencies.cmake
cmake/modules/LLDBConfig.cmake
include/lldb/Config/config.h.cmake
include/lldb/Config/config
krytarowski updated this revision to Diff 35923.
krytarowski added a comment.
Put the include into proper line and use "" instead of <>.
Repository:
rL LLVM
http://reviews.llvm.org/D12748
Files:
tools/lldb-server/lldb-gdbserver.cpp
Index: tools/lldb-server/lldb-gdbserver.cpp
=
tfiala added inline comments.
Comment at: test/test_runner/lib/process_control.py:552
@@ +551,3 @@
+# We don't have anything else to try.
+terminated = self.process.returncode is not None
+done_trying = True
Drats, t
tfiala updated this revision to Diff 35925.
tfiala added a comment.
Fixed up my previous inline comments. I was caching the popen object's
returncode returned from wait(), since it was showing unstable characteristics
when reading after a successful wait(). But I failed to use it everywhere.
tfiala marked 6 inline comments as done.
tfiala added a comment.
Clearing out all fixed comments.
http://reviews.llvm.org/D13124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
55 matches
Mail list logo
