zturner added inline comments. ================ Comment at: test/test_runner/test/process_control_tests.py:63 @@ +62,3 @@ + def _suppress_soft_terminate(cls, command): + if platform.system() == 'nt': + # Add whatever is needed to the command line to ---------------- zturner wrote: > tfiala wrote: > > zturner wrote: > > > Change `nt` to `Windows` (unless you're removing this logic as discussed > > > earlier) > > Ah okay. I was copying the "nt" from somewhere else in the source code. > > We might want to grep for that if it is wholesale wrong. I assumed that > > was leftover from transition over to the NT codebase in W2k time period. > It's really confusing. There's `os.name` and `sys.platform()`, which which > return different strings. It's possible the one you saw was checking > `os.name`, for which `nt` is one of the valid return values. That's another > good candidate for the cross-platform portability module, we could just have > lldb_platform.os() which returns an enum. I was a little bummed to see the > `process_control` module as a subfolder of `test_runner`, because all of the > helper-related stuff could be at a higher level usable by anywhere in the > test suite. But we can tackle that later. Oh yea, in addition to `sys.platform` there's also `platform.system`, as you've used here. And even *those* don't return the same values.
http://reviews.llvm.org/D13124 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
