[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

This revision was automatically updated to reflect the committed changes. Closed by commit rL363098: Add support to read aux vector values (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://reviews.llvm.org/D62500 __

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Utility/AuxVector.cpp:24-28 + while (true) { +uint64_t type = 0; +uint64_t value = 0; +if (!ReadUInt(data, &offset, &type) || !ReadUInt(data, &offset, &value)) break; claybor

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm updated this revision to Diff 202853. aadsm marked an inline comment as done. aadsm added a comment. Herald added a subscriber: emaste. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://reviews.llvm.org/D62500

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:183 + m_process->GetAddressByteSize()); + m_auxv = llvm::make_unique(auxv_data);

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm marked 2 inline comments as done. aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Utility/AuxVector.cpp:11 -using namespace lldb; -using namespace lldb_private; +AuxVector::AuxVector(lldb_private::DataExtractor &data) { ParseAuxv(data); } --

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

clayborg added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:91-92 m_process ? m_process->GetID() : LLDB_INVALID_PROCESS_ID); - - m_auxv.reset(new AuxVector(m_process)); + DataExtractor auxv_data(m_process

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

labath accepted this revision. labath added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:629-631 + llvm::Optional vdso_base = + m_auxv->GetAuxValue(AuxVector::AUXV_AT_SYSINFO_EHDR); + if (vdso_base)

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm updated this revision to Diff 202654. aadsm added a comment. Missing clang-format-diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://reviews.llvm.org/D62500 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm updated this revision to Diff 202649. aadsm added a comment. Fix patch snafu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://reviews.llvm.org/D62500 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lldb/sourc

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm updated this revision to Diff 202642. aadsm added a comment. Address commentds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://reviews.llvm.org/D62500 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lldb/sou

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:549-550 - if (ModuleSP module_sp = target.GetOrCreateModule(module_spec, -

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:94 + m_process->GetAddressByteSize()); + m_auxv.reset(new AuxVector(auxv_data)); if (log) `llvm::make_unique< Aux

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

labath added inline comments. Comment at: lldb/source/Plugins/Process/Utility/AuxVector.cpp:38 -AuxVector::AuxVector(Process *process) : m_process(process) { - DataExtractor data; - Log *log(GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER)); - - data.SetData(GetAuxvData(

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm marked 3 inline comments as done. aadsm added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:91-94 + DataExtractor auxv_data(m_process ? m_process->GetAuxvData() : DataBufferSP(), + m_process-

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

labath added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:91-94 + DataExtractor auxv_data(m_process ? m_process->GetAuxvData() : DataBufferSP(), + m_process->GetByteOrder(), +

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm updated this revision to Diff 202324. aadsm added a comment. Rnamed ELFAuxVector to AuxVector and got rid of the one that existed in the POSIX-DYLD plugin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://reviews.llvm.org/D62

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2091-2093 +DataExtractor auxv_data(buffer_or_error.get()->getBufferStart(), +buffer_or_error.get()->getBufferS

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

labath added a comment. In D62500#1519658 , @JDevlieghere wrote: > > A third option would be to create a completely new library for this. In the > > past we've talked about a new library for "classes describing various > > properties of a process", wher

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

JDevlieghere added a comment. In D62500#1518815 , @labath wrote: > Definitely go for the option of refactoring the DYLD AuxVector class to make > it usable from lldb-server. +1 > It doesn't look like it should be that complicated even. Instead of passi

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/Utility/ELFAuxVector.cpp:18 + lldb::offset_t saved_offset = *offset_ptr; + *value = data.GetMaxU64(offset_ptr, data.GetAddressByteSize()); + return *offset_ptr != saved_offset; aadsm wrote

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm marked 2 inline comments as done. aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Utility/ELFAuxVector.cpp:18 + lldb::offset_t saved_offset = *offset_ptr; + *value = data.GetMaxU64(offset_ptr, data.GetAddressByteSize()); + return *offset_ptr != saved

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

clayborg added a comment. I like this being in a Utility class like it is coded, but we should fix the POSIX DYLD plug-in to use this common code as part of this patch. Comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://rev

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

clayborg requested changes to this revision. clayborg added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2091-2093 +DataExtractor auxv_data(buffer_or_error.get()->getBufferStart(), +buffer_or_error.get()->ge

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

labath requested changes to this revision. labath added a reviewer: JDevlieghere. labath added a subscriber: JDevlieghere. labath added a comment. This revision now requires changes to proceed. Definitely go for the option of refactoring the DYLD AuxVector class to make it usable from lldb-server

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm created this revision. aadsm added reviewers: clayborg, xiaobai. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. aadsm added a parent revision: D62499: Create a generic handler for Xfer packets. aadsm added a child revision: D62501: Implement GetSharedLibraryInf