aadsm added inline comments.
================
Comment at: lldb/source/Plugins/Process/Utility/AuxVector.cpp:24-28
+ while (true) {
+ uint64_t type = 0;
+ uint64_t value = 0;
+ if (!ReadUInt(data, &offset, &type) || !ReadUInt(data, &offset, &value))
break;
----------------
clayborg wrote:
> ```
> const size_t value_type_size = data.GetAddressByteSize() * 2;
> while (data.ValidOffsetForDataOfSize(value_type_size)) {
> const uint64_t type = data.GetAddress(&offset);
> const uint64_t value = data.GetAddress(&offset);
> if (type == AUXV_AT_NULL)
> ...
> ```
>
nice, this is a much better loop.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62500/new/
https://reviews.llvm.org/D62500
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
