JDevlieghere added inline comments.
================
Comment at:
lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:94
+ m_process->GetAddressByteSize());
+ m_auxv.reset(new AuxVector(auxv_data));
if (log)
----------------
`llvm::make_unique< AuxVector>(auxv_data);`
================
Comment at:
lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:631
void DynamicLoaderPOSIXDYLD::EvalSpecialModulesStatus() {
- auto I = m_auxv->FindEntry(AuxVector::AUXV_AT_SYSINFO_EHDR);
- if (I != m_auxv->end() && I->value != 0)
- m_vdso_base = I->value;
+ auto vdso_base = m_auxv->GetAuxValue(AuxVector::AUXV_AT_SYSINFO_EHDR);
+ if (vdso_base != 0)
----------------
This shouldn't be `auto` anymore, as it's not obvious what the type is. Same
below.
================
Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.h:105
}
+ uint64_t GetAuxValue(enum AuxVector::EntryType type);
----------------
Newline before the function to keep things consistent.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62500/new/
https://reviews.llvm.org/D62500
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
