This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB360216: Propagate command interpreter errors from
lldlbinit (authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61579?vs=198215&id=198571#toc
Repository:
jingham added inline comments.
Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2472
+ flags |= eHandleCommandFlagPrintErrors;
+} else if (m_command_source_flags.back() & eHandleCommandFlagPrintErrors) {
+ flags |= eHandleCommandFlagPrintErrors;
--
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2472
+ flags |= eHandleCommandFlagPrintErrors;
+} else if (m_command_source_flags.back() & eHandleCommandFlagPrintErrors) {
+
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Seems plausible.
Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2472
+ flags |= eHandleCommandFlagPrintErrors;
+} else if (m_command_source_flags.back(
jingham added a comment.
I wonder if it would make this a little more convenient if we added a SetNoisy
as the opposite of SetSilent?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61579/new/
https://reviews.llvm.org/D61579
__
JDevlieghere created this revision.
JDevlieghere added reviewers: clayborg, labath, jingham.
Herald added a subscriber: abidh.
Herald added a project: LLDB.
JDevlieghere added a parent revision: D61578: [Driver] Add command line option
to allow loading local lldbinit file.
This patch ensures that
