[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

labath added a comment. I've created https://reviews.llvm.org/D42572 with the fixups necessary to make this run on linux. It's way smaller than I expected we would need -- I basically fixed one typo and corrected for some shared library weirdness. Can you apply that on top of your CL? I'll try

[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This looks good to me. I think it would be cleaner if there were a getSourceFileSpec equivalent to getBuildArtifact. I had a few inline trivial questions. Also, before you forget

[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/dotest_args.py:166 +metavar='Test build directory', +help='The root build directory for the tests') clayborg wrote: > Maybe add a default right here?: > > ``` > defau

Re: [Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

> On Jan 19, 2018, at 9:04 AM, Adrian Prantl via Phabricator > wrote: > > aprantl added a comment. > > In https://reviews.llvm.org/D42281#981969, @clayborg wrote: > >> Looks like a good start. It might be nice to validate that after "clean" >> that we have no files that are untracked in the

[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. This looks like a decent way of going forward, I'm a little concerned about swallowing an error, see comment inline. Comment at: packages/Python/lldbsuite/test/dot

[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

davide added a comment. In https://reviews.llvm.org/D42281#981973, @aprantl wrote: > In https://reviews.llvm.org/D42281#981969, @clayborg wrote: > > > Looks like a good start. It might be nice to validate that after "clean" > > that we have no files that are untracked in the test directory? This

[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

aprantl added a comment. In https://reviews.llvm.org/D42281#981969, @clayborg wrote: > Looks like a good start. It might be nice to validate that after "clean" that > we have no files that are untracked in the test directory? This could help us > to verify that we don't leave artifacts around.

[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

clayborg added a comment. Looks like a good start. It might be nice to validate that after "clean" that we have no files that are untracked in the test directory? This could help us to verify that we don't leave artifacts around. Comment at: packages/Python/lldbsuite/test/dot

[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

labath added a comment. I like the direction this is going in. When looking at this, it occurred to me some of our tests do recursive make invocations, generally to build shared libraries (TestConflictingSymbol is a good example). The $(MAKE) line in those may need to be fixed somehow. =

[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

zturner added inline comments. Comment at: packages/Python/lldbsuite/test/dotest.py:625 os.environ["LLDB_TEST"] = scriptPath +os.environ["LLDB_BUILD"] = configuration.test_build_dir Here this has the possibility of setting `os.environ["LLDB_BUILD"] = N

[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

aprantl created this revision. This patch is the result of a discussion on lldb-dev, see http://lists.llvm.org/pipermail/lldb-dev/2018-January/013111.html for background. This is a first sketch of how to move building of the testcases in the LLDB testsuite out of the source tree. The patch is