brunoalr added a comment.
In https://reviews.llvm.org/D35065#803602, @brunoalr wrote:
> @labath @joerg @krytarowski thanks for the review. Can anyone commit this,
> please? I still don't have commit privileges.
thanks, @labath
Repository:
rL LLVM
https://reviews.llvm.org/D35065
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307632: [LLDB][ppc64le] Rename enums in AuxVector (authored
by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D35065
Files:
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
brunoalr added a comment.
@labath @joerg thanks for the review. Can anyone commit this, please? I still
don't have commit privileges.
https://reviews.llvm.org/D35065
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
cool. thanks
https://reviews.llvm.org/D35065
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
brunoalr updated this revision to Diff 105640.
brunoalr added a comment.
Small fix
https://reviews.llvm.org/D35065
Files:
source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYL
brunoalr updated this revision to Diff 105639.
brunoalr added a comment.
Use string+5 instead of concatenation
https://reviews.llvm.org/D35065
Files:
source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h
source/Plugins/DynamicLoader/POSI
brunoalr updated this revision to Diff 105638.
brunoalr added a comment.
Applying suggestions from review
https://reviews.llvm.org/D35065
Files:
source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h
source/Plugins/DynamicLoader/POSIX-DYL
On 6 July 2017 at 18:40, Bruno Rosa via Phabricator
wrote:
> brunoalr added a comment.
>
> In https://reviews.llvm.org/D35065#800877, @krytarowski wrote:
>
>> What are the build failures?
>
>
>
>
> [2397/3183] Building CXX object
> tools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/CMakeFiles/l
labath added inline comments.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115
_type:
\
name = #_type
switch (type) {
joerg wrote:
> krytarowski wrote:
> > brunoa
joerg added inline comments.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115
_type:
\
name = #_type
switch (type) {
krytarowski wrote:
> brunoalr wrote:
> > joer
krytarowski added inline comments.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115
_type:
\
name = #_type
switch (type) {
brunoalr wrote:
> joerg wrote:
> > laba
brunoalr added inline comments.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115
_type:
\
name = #_type
switch (type) {
joerg wrote:
> labath wrote:
> > If we go
brunoalr added inline comments.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h:46
+ /// Added AUXV prefix because some targets already define names such as
+ /// AT_DCACHEBSIZE in system headers
enum EntryType {
joerg wrote:
> I think most t
joerg added inline comments.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115
_type:
\
name = #_type
switch (type) {
labath wrote:
> If we go about renaming them,
brunoalr updated this revision to Diff 105517.
brunoalr added a comment.
Add comments
https://reviews.llvm.org/D35065
Files:
source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIX
brunoalr updated this revision to Diff 105515.
brunoalr added a comment.
Fixing replace mistake.
https://reviews.llvm.org/D35065
Files:
source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h
source/Plugins/DynamicLoader/POSIX-DYLD/Dynamic
brunoalr updated this revision to Diff 105514.
brunoalr added a comment.
Renaming enum consistently and updating name ENTRY_NAME macro to
correctly assign the standard names of aux vector entries.
https://reviews.llvm.org/D35065
Files:
source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
s
brunoalr marked 2 inline comments as done.
brunoalr added a comment.
In https://reviews.llvm.org/D35065#800906, @joerg wrote:
> If you want to go this way, rename them consistently and use a different
> prefix (e.g. AUXV_*) please.
Wiil do.
https://reviews.llvm.org/D35065
brunoalr marked an inline comment as done.
brunoalr added inline comments.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:11
// C Includes
#include
#include
labath wrote:
> Do you still get the error if you remove these includes?
>
> As f
brunoalr added a comment.
In https://reviews.llvm.org/D35065#800877, @krytarowski wrote:
> What are the build failures?
[2397/3183] Building CXX object
tools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/CMakeFiles/lldbPluginDynamicLoaderPosixDYLD.dir/AuxVector.cpp.o
FAILED:
tools/lldb/s
labath added inline comments.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:11
// C Includes
#include
#include
Do you still get the error if you remove these includes?
As far as I can tell they are unused, and this part of the code shoul
joerg added a comment.
If you want to go this way, rename them consistently and use a different prefix
(e.g. AUXV_*) please.
https://reviews.llvm.org/D35065
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
krytarowski added a comment.
What are the build failures?
https://reviews.llvm.org/D35065
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brunoalr added a comment.
In https://reviews.llvm.org/D35065#800852, @krytarowski wrote:
> Values like AT_NULL are macros on NetBSD and there are no problems?
I haven't tested in ppc64le on NetBSD, but I'm afraid the same problems would
occur.
https://reviews.llvm.org/D35065
_
krytarowski added a comment.
Values like AT_NULL are macros on NetBSD and there are no problems?
https://reviews.llvm.org/D35065
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
25 matches
Mail list logo
