brunoalr added inline comments.

================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h:46
+  /// Added AUXV prefix because some targets already define names such as
+  /// AT_DCACHEBSIZE in system headers
   enum EntryType {
----------------
joerg wrote:
> I think most targets do, but they don't pull the relevant system headers in 
> via namespace pollution.
Should I change this comment to

```
/// Added AUXV prefix to avoid potential conflicts with system-defined MACROS
```
?


https://reviews.llvm.org/D35065



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to