[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

dblaikie added a comment. In D157609#4645298 , @clayborg wrote: > In D157609#4644194 , @DavidSpickett > wrote: > >>> Any chance we could simplify this situation and have dwo searches use >>> exactly the same/sha

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

clayborg added a comment. In D157609#4644194 , @DavidSpickett wrote: >> Any chance we could simplify this situation and have dwo searches use >> exactly the same/shared logic as source file searches? > > I'm not sure what exactly this means, can you cla

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett added a comment. > Any chance we could simplify this situation and have dwo searches use exactly > the same/shared logic as source file searches? I'm not sure what exactly this means, can you clarify? I know that DWP and DWO have different search functions, that could certainly b

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

dblaikie added a comment. Any chance we could simplify this situation and have dwo searches use exactly the same/shared logic as source file searches? It seems like the dwarf spec intent was for that to be the case. I don't mind adding more ways to find things, but think it'd be useful if we o

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett added a comment. From what I gather, split dwarf isn't a thing on Darwin so I've relanded with the tests skipped (https://github.com/llvm/llvm-project/commit/b1f14d647300b0ed003fa7c24af311b11605d009). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

JDevlieghere added a comment. Looks like this broke the X86 bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/59815/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 _

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

This revision was automatically updated to reflect the committed changes. Closed by commit rGa723694321b9: [lldb] Add more ways to find split DWARF files (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett added a comment. No problem. I doubt this is all of them but at least users can now workaround the gaps using the setting, and hack up one of these test cases to make reproducers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks a lot for acting on all feedback and getting all of the edge cases! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ ht

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1779 +FileSystem::Instance().Resolve(dirspec); +if (!FileSystem::Instance().IsDirectory(dirspec)) + c

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1747-1754 if (!comp_dir) { unit.SetDwoError(Status::createWithFormat( "unable to locate relative .dwo d

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett updated this revision to Diff 556016. DavidSpickett added a comment. Log when comp dir not found and carry on to fallback search. Add a test for the search path being a symlink. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1747-1754 if (!comp_dir) { unit.SetDwoError(Status::createWithFormat( "unable to locate relative .dwo debug file \"{0}\" for " "skeleton DIE {1:x

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1808-1810 +FileSpec dwo_name_next_to_binary(next_to_binary); +dwo_name_next_to_binary.AppendPathComponent(dwo_name); +dwo_paths.Append(dwo_name_next_to_binary); -

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett updated this revision to Diff 555827. DavidSpickett added a comment. In the fallback, only check binary dir + dwo name if the dwo name is relative. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett updated this revision to Diff 555822. DavidSpickett added a comment. Rename as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 Files: lldb/source/Plugins/SymbolFile/DWARF/Symbol

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1801 +FileSpecList dwo_paths; +FileSpec spec_to_get_name(dwo_name); +llvm::StringRef filename_only = spec_to_get_name.GetFilename(); Rename to "dwo_na

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett updated this revision to Diff 555333. DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. Use *.dwo in commands since I'm not sure the DWO name will be the same everywhere. The specific name isn't important, we know there's only going to be one. Repositor

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1755 + dwo_file.AppendPathComponent(dwo_name); + found = FileSystem::Instance().Exists(dwo_file); +} else {