[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

2022-09-12 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionValue.h:86-87 + // TODO: make this function pure virtual after implementing it in all + // child classes. + virtual llvm::json::Value ToJSON(const ExecutionContext *exe_ctx) {

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

2022-09-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/UserSettingsController.h:62-64 virtual void DumpAllPropertyValues(const ExecutionContext *exe_ctx, - Stream &strm, uint32_t dump_mask); +

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

2022-09-11 Thread jeffrey tan via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd5f54751048b: Add SBDebugger::GetSetting() public APIs (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.l

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

2022-09-09 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan updated this revision to Diff 459208. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files: lldb/bindings/interface/SBDebugger.i lldb/in

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

2022-09-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a comment fix and allow the "char" option value to be saved as zero and this will be good to go. Comment at: lldb/include/lldb/API/SBDebugger.h:120-121 +

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

2022-09-09 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan updated this revision to Diff 459120. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files: lldb/bindings/interface/SBDebugger.i lldb/in

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

2022-09-09 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionValueChar.h:34-37 +if (m_current_value != '\0') + return m_current_value; +else + return "(null)"; clayborg wrote: > Since this is actually a character, it should

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

2022-09-08 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/API/SBDebugger.h:119 + /// Get all settings into SBStructuredData. + lldb::SBStructuredData GetSetting(); +

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

2022-09-08 Thread Will Hawkins via Phabricator via lldb-commits
hawkinsw added inline comments. Comment at: lldb/test/API/functionalities/source-map/TestTargetSourceMap.py:25 +src_dir = self.getSourceDir() +self.runCmd('settings set target.source-map . "%s"' % src_dir) + yinghuitan wrote: > hawkinsw wrote: > >

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

2022-09-08 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan marked an inline comment as done. yinghuitan added a comment. @jingham , @clayborg, thanks for the feedback. Seems like the major concern is creating a general GetSettings() API instead of API for each setting. I like and agree with this idea. Per the reading, Comm