yinghuitan added inline comments.
================ Comment at: lldb/include/lldb/Interpreter/OptionValueChar.h:34-37 + if (m_current_value != '\0') + return m_current_value; + else + return "(null)"; ---------------- clayborg wrote: > Since this is actually a character, it should store what ever the character > value is. So if the character is zero, it should store zero, not a string > "(null)" I am not sure about this. This mimics what `OptionValueChar::DumpValue()` does. Do we want to keep consistence here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
