Re: [Lldb-commits] [PATCH] D12039: Make @skipUnlessArch actually skip instead of XFAIL

chaoren accepted this revision. This revision is now accepted and ready to land. Comment at: test/lldbtest.py:943 @@ -947,1 +942,3 @@ +def skipUnlessArch(archlist): +def myImpl(func): zturner wrote: > chaoren wrote: > > Is there a reason > > ``` > > return u

Re: [Lldb-commits] [PATCH] D12039: Make @skipUnlessArch actually skip instead of XFAIL

zturner added inline comments. Comment at: test/lldbtest.py:943 @@ -947,1 +942,3 @@ +def skipUnlessArch(archlist): +def myImpl(func): chaoren wrote: > Is there a reason > ``` > return unittest2.skipUnless(getArchitecture() in archlist, ...) > ``` > is not su

Re: [Lldb-commits] [PATCH] D12039: Make @skipUnlessArch actually skip instead of XFAIL

chaoren added inline comments. Comment at: test/lldbtest.py:943 @@ -947,1 +942,3 @@ +def skipUnlessArch(archlist): +def myImpl(func): Is there a reason ``` return unittest2.skipUnless(getArchitecture() in archlist, ...) ``` is not sufficient? Also, please a

[Lldb-commits] [PATCH] D12039: Make @skipUnlessArch actually skip instead of XFAIL

zturner created this revision. zturner added a reviewer: chaoren. zturner added a subscriber: lldb-commits. http://reviews.llvm.org/D12039 Files: test/lldbtest.py Index: test/lldbtest.py === --- test/lldbtest.py +++ test/lldbtest.