Re: [Lldb-commits] [PATCH] D12039: Make @skipUnlessArch actually skip instead of XFAIL

[Chaoren Lin via lldb-commits]

chaoren added inline comments.

================
Comment at: test/lldbtest.py:943
@@ -947,1 +942,3 @@
 
+def skipUnlessArch(archlist):
+    def myImpl(func):
----------------
Is there a reason
```
return unittest2.skipUnless(getArchitecture() in archlist, ...)
```
is not sufficient?

Also, please add a doc string, like the other skip{If,Unless} methods.


http://reviews.llvm.org/D12039



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits