[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

Ericson2314 updated this revision to Diff 448493. Ericson2314 added a comment. Herald added a project: All. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116467/new/ https://reviews.llvm.org/D116467 Files: lld/CMakeLists.txt lldb/cmake/

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

Ericson2314 updated this revision to Diff 398287. Ericson2314 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116467/new/ https://reviews.llvm.org/D116467 Files: lld/CMakeLists.txt lldb/cmake/modules/LLDBConfig.cmake ll

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

Ericson2314 updated this revision to Diff 398286. Ericson2314 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116467/new/ https://reviews.llvm.org/D116467 Files: lld/CMakeLists.txt lldb/cmake/modules/LLDBConfig.cmake ll

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

Ericson2314 updated this revision to Diff 396940. Ericson2314 added a comment. Rebase on top of D116497 I will probably just close this, but doing the rebase in case we should get rid of `LLVM_LIBRARY_DIRS` after all. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

Ericson2314 added inline comments. Comment at: llvm/cmake/modules/LLVMConfig.cmake.in:115 set(LLVM_MAIN_INCLUDE_DIR "@LLVM_CONFIG_MAIN_INCLUDE_DIR@") -set(LLVM_LIBRARY_DIR "@LLVM_CONFIG_LIBRARY_DIRS@") @beanz > it would definitely break many uses of `LLVM_LI

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

beanz added a comment. `LLVM_LIBRARY_DIR` and `LLVM_LIBRARY_DIRS` aren’t intended to serve the same purpose. The `S` in `DIRS` is intentional to convey that it is a list of directories, not necessarily a single value, and it would definitely break many uses of `LLVM_LIBRARY_DIR` if it was a lis

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

Ericson2314 added inline comments. Comment at: llvm/cmake/modules/CMakeLists.txt:58 set(LLVM_CONFIG_TOOLS_BINARY_DIR "${LLVM_TOOLS_BINARY_DIR}") +set(LLVM_CONFIG_LIBRARY_DIR "${LLVM_LIBRARY_DIR}") mstorsjo wrote: > Curious: Why the reordering? I presume you're

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

mstorsjo added subscribers: beanz, mstorsjo. mstorsjo added a reviewer: beanz. mstorsjo added a comment. This looks reasonable to me, but I'm not sure if I know all the aspects that might be at play here, so I don't think I'm comfortable with accepting it on my own. Adding @beanz who should know

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

Ericson2314 created this revision. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. In all cases we now just set a single lib dir, so the somewhat newer `LLVM_LIBRARY_DIR` vari