Ericson2314 added inline comments.
================
Comment at: llvm/cmake/modules/CMakeLists.txt:58
set(LLVM_CONFIG_TOOLS_BINARY_DIR "${LLVM_TOOLS_BINARY_DIR}")
+set(LLVM_CONFIG_LIBRARY_DIR "${LLVM_LIBRARY_DIR}")
----------------
mstorsjo wrote:
> Curious: Why the reordering? I presume you're moving `LLVM_CONFIG_CMAKE_DIR`
> into alphabetical order, but then `LLVM_CONFIG_LIBRARY_DIR` seems out of
> place?
Oh I just moved the prefix one to the top, since it is unlike the others, and
put library on the bottom, moving it away from the other "weird" one (the
include dirs). The ordering of cmake then binaries is simply because that is
the way it was before --- the diff algorithm just happened to hide that in
choosing to make `LLVM_CONFIG_BINARY_DIR` the "stable" one line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116467/new/
https://reviews.llvm.org/D116467
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits