Ericson2314 added inline comments.
================ Comment at: llvm/cmake/modules/LLVMConfig.cmake.in:115 set(LLVM_MAIN_INCLUDE_DIR "@LLVM_CONFIG_MAIN_INCLUDE_DIR@") -set(LLVM_LIBRARY_DIR "@LLVM_CONFIG_LIBRARY_DIRS@") ---------------- @beanz > it would definitely break many uses of `LLVM_LIBRARY_DIR` if it was a list. The code right here is dangerously close to doing that. So I think some change is waranted. Perhaps I can add back `set(LLVM_LIBRARY_DIRS "@LLVM_CONFIG_LIBRARY_DIRS@")` above and add a TODO next to the definitions of `LLVM_CONFIG_LIBRARY_DIRS` with the cases you mentioned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116467/new/ https://reviews.llvm.org/D116467 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
