[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

sgraenitz added a comment. Backport for 17.x release: https://github.com/llvm/llvm-project/issues/64800 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158205/new/ https://reviews.llvm.org/D158205 ___ lldb

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf2eb838309d: [lldb] Fix performance regression after adding GNUstep ObjC runtime (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1582

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

sgraenitz added a comment. Thanks for your quick feedback everyone! > Did you have the chance to verify that it improves performance of non-objc > inferiors on Linux? Nope, but the author of the bug report confirmed that this fixes the issue for them. Since I will be on vacation starting tomor

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

sgraenitz added a comment. Herald added a subscriber: JDevlieghere. The issue was reported in https://github.com/llvm/llvm-project/issues/64582 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158205/new/ https://reviews.llvm.org/D158205

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

sgraenitz created this revision. sgraenitz added reviewers: jasonmolenda, jingham, bulbazord, aprantl. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We added support for the GNUstep ObjC runtime in 0

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b6264738f3d: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on… (authored by sgraenitz). Changed prior to commit: https://reviews.llvm.org/D146154?vs=522951&id=523004#toc R

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz updated this revision to Diff 522951. sgraenitz added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146154/new/ https://reviews.llvm.org/D146154 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4241ac542d69: [lldb][gnustep] Add basic test and infrastructure fo

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz updated this revision to Diff 522582. sgraenitz added a comment. Rebase and re-run pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/new/ https://reviews.llvm.org/D146058 Files: lldb/cmake/modules/FindGNUstepObjC.cm

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. This patch adds test coverage for existing functionality. It was ready to land 6 weeks ago. There was plenty of opportunity to raise concerns and discuss details over the last 2 months of review. I assume the topic is just too niche to attract a lot of attention. I a

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz updated this revision to Diff 518169. sgraenitz edited the summary of this revision. sgraenitz added a comment. Rebase and double-check default config: GNUstep disabled, objc-gnustep-print test unsupported Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64a2520bacb5: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 518167. sgraenitz marked an inline comment as done. sgraenitz added a comment. Address feedback and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642 Files:

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. In D146058#4305046 , @labath wrote: > That's not entirely what I was referring to. What I fear is the following > situation. A random developer makes a random patch that happens to break > gnustep support. That developer canno

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. Great. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147669/new/ https://reviews.llvm.org/D147669 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz added a comment. Double-checked and found source locations on Raspberry Pi 3b with this patch applied https://github.com/llvm/llvm-project/issues/61948#issuecomment-1508305542 Is there more feedback on this? It would be nice to land it soon, i.e. before EuroLLVM =) Repository: rG

[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

sgraenitz added a comment. I think it's a very good practice that objects in moved-from state will only ever get destroyed. While the move ctor itself has no preconditions and thus might be fine to call again, the implementation of `consumeError()` does inspect the object. This adds an unnecess

[Lldb-commits] [PATCH] D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

This revision was automatically updated to reflect the committed changes. sgraenitz marked an inline comment as done. Closed by commit rGcc6ab268d89b: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

sgraenitz marked an inline comment as done. sgraenitz added a comment. Thanks for your feedback Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2704 +default: + assert(false && "unexpected relocation type"); + break; D

[Lldb-commits] [PATCH] D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

sgraenitz updated this revision to Diff 513187. sgraenitz added a comment. Include `R_386_NONE` for error reporting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147627/new/ https://reviews.llvm.org/D147627 Files: lldb/source/Plugins/ObjectFile/

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz added a comment. Addressed feedback and added handling for `R_ARM_REL32`. I didn't see a real-world case for it yet. Hope it's ok to have the error reported for the time being. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2640 +static void Appl

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 513179. sgraenitz added a comment. Add error reporting for `R_ARM_REL32` relocations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642 Files: lldb/source/Plugins/Ob

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 513178. sgraenitz marked an inline comment as done. sgraenitz added a comment. Rename new function to `ApplyELF32ABS32RelRelocation()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews

[Lldb-commits] [PATCH] D147669: PECOFF: enforce move semantics and consume errors properly

sgraenitz requested changes to this revision. sgraenitz added a comment. This revision now requires changes to proceed. First of all, yes the existing code is incorrect. Thanks for looking into this. However, I am afraid this isn't the right solution. In the `if` body you can not `std::move()` f

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 511155. sgraenitz added a comment. Second try for the out-of-range test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642 Files: lldb/source/Plugins/ObjectFile/ELF/

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 511151. sgraenitz added a comment. Add the missing 5th relocation to the test that exercises the out-of-range case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642 F

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz added a comment. Adding an abstraction for reading implicit addend or somehow integrate it into `ELFRelocation::RelocAddend32()` might be more confusing for the reader than keeping it in the function inline. What do you think? Comment at: lldb/source/Plugins/ObjectF

[Lldb-commits] [PATCH] D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

sgraenitz added a comment. This would be good to land in preparation for D147642 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147627/new/ https://reviews.llvm.org/D147627 ___

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz created this revision. sgraenitz added reviewers: DavidSpickett, peter.smith, labath, davide. Herald added subscribers: omjavaid, kristof.beyls, emaste. Herald added a project: All. sgraenitz requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: LL

[Lldb-commits] [PATCH] D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

sgraenitz created this revision. sgraenitz added reviewers: DavidSpickett, SixWeining. Herald added a subscriber: emaste. Herald added a project: All. sgraenitz requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: LLDB. ObjectFileELF::ApplyRelocations() co

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. The modified proposal keeps GNUstep support off by default (even if installed). It must be enabled explicitly by passing `-DLLDB_TEST_OBJC_GNUSTEP=On` and it can be disabled easily by passing `-DLLDB_TEST_OBJC_GNUSTEP=Off` to CMake. A custom install location `/path/to

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz updated this revision to Diff 510732. sgraenitz added a comment. Split config in two parts: On/Off and DIR Move standard find library logic into FindGNUstepObjC.cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/new/ https://revie

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. In D146058#4223575 , @labath wrote: > What kind of setup is necessary to make that work? If it's not too > complicated, I think we could make something work. Thanks, that'd be awesome! The last official release is from 2020,

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. Is there any more feedback on this patch? After all, this adds test coverage for existing functionality (with the new GNUstep runtime plugin from D146154 that is ready to land). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D146536: SymbolFile: ensure that we have a value before invoking `getBitWidth`

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. Perfect, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146536/new/ https://reviews.llvm.org/D146536 _

[Lldb-commits] [PATCH] D146541: [lldb][expr] Propagate ClangDynamicCheckerFunctions::Install() errors to caller

This revision was automatically updated to reflect the committed changes. Closed by commit rG32baf5c1c29b: [lldb][expr] Propagate ClangDynamicCheckerFunctions::Install() errors to caller (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz added a comment. Thanks for reviewing! I will land this as soon as the previous review is ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146154/new/ https://reviews.llvm.org/D146154 ___ l

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz updated this revision to Diff 507054. sgraenitz marked an inline comment as done. sgraenitz added a comment. Make shared library name checks OS-dependent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146154/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D146541: [lldb][expr] Propagate ClangDynamicCheckerFunctions::Install() errors to caller

sgraenitz added a comment. Thanks for the quick replies! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146541/new/ https://reviews.llvm.org/D146541 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D146547: [lldb][gnustep][PDB] Add special handling for ObjC built-in types eBasicTypeObjCID and eBasicTypeObjCSel

sgraenitz created this revision. sgraenitz added reviewers: aleksandr.urakov, rnk, teemperor, DavidSpickett, aprantl, zturner, jdoerfert. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: LLDB. Let the PDB parser recognize special ObjC type names li

[Lldb-commits] [PATCH] D146541: [lldb][expr] Propagate ClangDynamicCheckerFunctions::Install() errors to caller

sgraenitz created this revision. sgraenitz added reviewers: teemperor, bulbazord, JDevlieghere. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sgraenitz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: LLDB. I

[Lldb-commits] [PATCH] D146536: SymbolFile: ensure that we have a value before invoking `getBitWidth`

sgraenitz added a comment. Thanks for tackling this! Yes, I hit it as well during development and wondered what is the right thing to do. The effect of the proposed change will be log messages like this right? ... which resolves to a constant value of mismatched width (-1 bits). Ignoring con

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz added a comment. In D146154#4203277 , @aprantl wrote: > Here is an example of how the Swift Runtime plugin detects both itself and > whether ObjC interop is enabled. Basically all I'm asking is to not > accidentally break this mechanism. Than

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz updated this revision to Diff 506989. sgraenitz added a comment. Check for GNUstep EH personality in ELF targets and `__objc_load` on native Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146154/new/ https://reviews.llvm.org/D1461

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. I think this is ready to land, but I will leave it here for a few more days to allow for further questions. Comment at: lldb/test/Shell/helper/toolchain.py:46 +if config.objc_gnustep_dir: + build_script_args.append('--objc-gnustep-dir="{0

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef006eb0bc5e: [CodeView] Add source languages ObjC and ObjC++ (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

sgraenitz added inline comments. Comment at: llvm/test/DebugInfo/COFF/objc.ll:4-6 +; ASM: .short 4412# Record kind: S_COMPILE3 +; ASM-NEXT: .long 17 # Flags and language +; ASM-NEXT: .short 208 # CPUType --

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

sgraenitz updated this revision to Diff 506100. sgraenitz marked 7 inline comments as done. sgraenitz added a comment. Cut down check-lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146221/new/ https://reviews.llvm.org/D146221 Files: lldb/so

[Lldb-commits] [PATCH] D146297: [lldb][gnustep][PDB] Parse ObjC base classes and recognize NSObject type

sgraenitz added a comment. In D146297#4202172 , @DavidSpickett wrote: > I don't know anything about Objective C internals, perhaps you can provide > some reference that talks about this? Honestly, I am mostly looking what the DWARF parser does and try

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

sgraenitz added a comment. Maybe I should have noted immediately, that this is mostly following the change for Rust from https://reviews.llvm.org/D115300 Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:142 +/// These values correspond to the CV_CFL_LANG enumeration

[Lldb-commits] [PATCH] D146297: [lldb][gnustep][PDB] Parse ObjC base classes and recognize NSObject type

sgraenitz created this revision. sgraenitz added reviewers: aleksandr.urakov, rnk, teemperor, DavidSpickett, aprantl, zturner. Herald added a project: All. sgraenitz requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. Herald added a pr

[Lldb-commits] [PATCH] D146286: [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl()

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9987f0ac81a: [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl() (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[Lldb-commits] [PATCH] D146286: [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl()

sgraenitz added a comment. Thanks for the quick response! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146286/new/ https://reviews.llvm.org/D146286 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D146293: [lldb][gnustep][PDB] Recognize ObjC classes and start definition only once the complete type is requested

sgraenitz added a comment. In order to run the test yourself locally, you also need to apply D146058 , D146154 and D146221 first (right now they are still in review). Comm

[Lldb-commits] [PATCH] D146293: [lldb][gnustep][PDB] Recognize ObjC classes and start definition only once the complete type is requested

sgraenitz created this revision. sgraenitz added reviewers: aleksandr.urakov, rnk, aprantl, DavidSpickett, omjavaid, zturner, asmith. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: LLDB. This patch allows the PDB parser to recognize UDT symbols a

[Lldb-commits] [PATCH] D146286: [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl()

sgraenitz created this revision. sgraenitz added reviewers: aleksandr.urakov, labath, rnk, asmith, zturner. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: LLDB. The old name of this function was confusing for me, when I started working on the PDB

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

sgraenitz created this revision. sgraenitz added reviewers: rnk, zturner, compnerd, aleksandr.urakov. Herald added a subscriber: hiraditya. Herald added a project: All. sgraenitz requested review of this revision. Herald added projects: LLDB, LLVM. Herald added a subscriber: lldb-commits. This pat

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:131 +ExecutionContext &exe_ctx) { + // TODO: This function is supposed to check whether an ObjC selector is +

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz updated this revision to Diff 505760. sgraenitz marked 3 inline comments as done. sgraenitz added a comment. Extend the test to check both, zero initialization and assigned ivars Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146154/new/ h

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz marked 3 inline comments as done. sgraenitz added a comment. In D146154#4197454 , @aprantl wrote: > One thing I just realized — we need to make sure that we don't accidentally > create a GNUstep ObjC runtime in a Swift process that was built wi

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz marked 3 inline comments as done. sgraenitz added a comment. Hi David, thanks for your notes. Please find responses inline. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:42 +

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp:253 +} + ObjCLanguageRuntime::ObjCISA This was always declared in the header, but never implemented. Instead, AppleObjCRuntime had its own implementati

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz created this revision. sgraenitz added reviewers: DavidSpickett, theraven, teemperor, bulbazord, labath. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is the next patch after D146058

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added inline comments. Comment at: lldb/test/CMakeLists.txt:39 +if (LLDB_TEST_OBJC_GNUSTEP_DIR) + message(STATUS "Found GNUstep ObjC runtime: ${LLDB_TEST_OBJC_GNUSTEP_DIR}/${gnustep_info}") +endif() sgraenitz wrote: > theraven wrote: > > DavidSpickett

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz updated this revision to Diff 505529. sgraenitz added a comment. Make the test more extensible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/new/ https://reviews.llvm.org/D146058 Files: lldb/test/CMakeLists.txt lldb/test/Shell

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. In D146058#4196060 , @DavidSpickett wrote: > If I run the test without the runtime installed I get these run lines [...] Oh, excellent catch. Thanks! Now, with my last patch, given that: > grep GNUSTEP CMakeCache.txt LLDB

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz updated this revision to Diff 505528. sgraenitz marked an inline comment as done. sgraenitz added a comment. Fix CMakeLists.txt and build.py for the case that GNUstep is not installed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/ne

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Soo, @DavidSpickett In D146058#4193446 , @DavidSpickett wrote: > I am not familiar with Objective C, especially beyond Apple platforms. Are > you aiming to run all the existing Obje

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. In D146058#4193795 , @stella.stamenova wrote: > The one I was referring to is https://lab.llvm.org/buildbot/#/builders/219. Ok, thanks for the update. Then we are lacking a Windows x86 build bot for LLDB now! > Also, the one

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz updated this revision to Diff 505189. sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Polish assertion message in build.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/new/ https://reviews.llvm.org/D146058

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a subscriber: stella.stamenova. sgraenitz added a comment. In D146058#4193470 , @DavidSpickett wrote: > Myself and Omair both work on Linaro's bots. We run lldb checks on linux > arm/aarch64 and Windows on Arm. We could look at installin

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz updated this revision to Diff 505149. sgraenitz marked 3 inline comments as done. sgraenitz added a comment. Improve help text for the build.py --objc-gnustep option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/new/ https://review

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. I am not in touch with any of the build bot maintainers for Windows/Linux LLDB. Do you think it's worth asking for mainline test support? They'd basically need to build and install libobjc2 once. It's a few hundred kilobytes. For me the test expectedly fails on Window

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz created this revision. sgraenitz added reviewers: theraven, triplef, mgorny, labath, omjavaid, xiaobai, aleksandr.urakov, zturner. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: LLDB. We are planning to add basic ObjC debug support for

[Lldb-commits] [PATCH] D138750: [lldb][JITLoaderGDB] Resolve __jit_debug_register_code as eSymbolTypeCode

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1a419c6cf6d: [lldb][JITLoaderGDB] Resolve __jit_debug_register_code as eSymbolTypeCode (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D138750: [lldb][JITLoaderGDB] Resolve __jit_debug_register_code as eSymbolTypeCode

sgraenitz created this revision. sgraenitz added reviewers: mgorny, labath. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: LLDB. Fix failling jit-loader tests in SHARED_LIBS build as discussed in https://github.com/llvm/llvm-project/issues/56085

[Lldb-commits] [PATCH] D96634: [lldb][JITLoaderGDB] Test debug support in llvm-jitlink

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ff533cba18a: [lldb][JITLoaderGDB] Test debug support in JITLink (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D96634: [lldb][JITLoaderGDB] Test debug support in llvm-jitlink

sgraenitz updated this revision to Diff 329301. sgraenitz added a comment. For the entry point, prefer lli over llvm-jitlink. D97339 added debug support for JITLink in lli. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D96634: [lldb][JITLoaderGDB] Test debug support in llvm-jitlink

sgraenitz added a comment. Thanks for taking a look. Planning to to give this a try as soon as JITLink support landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96634/new/ https://reviews.llvm.org/D96634 __

[Lldb-commits] [PATCH] D96634: [lldb][JITLoaderGDB] Test debug support in llvm-jitlink

sgraenitz created this revision. sgraenitz added reviewers: labath, teemperor, JDevlieghere, lhames. sgraenitz requested review of this revision. Herald added a project: LLDB. LLVM OrcJIT is shifting from RuntimeDyld to JITLink. Starting with D96627 I am planning

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz added a comment. Thanks! Eventually, I closed https://llvm.org/PR36209 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90789/new/ https://reviews.llvm.org/D90789 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG332e220ef42b: [docs] Update DebuggingJITedCode page after fix in LLDB (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz added a comment. I'd like to land this before release 12 branches. If you have any objections, please speak up before the end of the week. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90789/new/ https://reviews.llvm.org/D90789

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz added a comment. Does anyone have objections to this documentation update? Preview is here still: https://weliveindetail.github.io/docs-pub/html/DebuggingJITedCode.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90789/new/ https://revi

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz added a comment. One issue with the `orc-lazy` JIT will be symbol renaming for lazy reexports: Upfront we only emit stubs for our function symbols and they trigger compilation of the actual code in a separate logical unit once they are called. The debug object we hand over to LLDB doe

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz added a comment. Thanks for having a look. That's right and it's on my wishlist. However, the example doesn't actually work with `--jit-kind=orc-lazy` (yet). On Linux it should use RTDyldObjectLinkingLayer and so it should notify LLDB when new code is loaded, but somehow it doesn't:

[Lldb-commits] [PATCH] D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG203b4774b883: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via… (authored by sgraenitz). Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB)

sgraenitz added a comment. That's right, but I don't see how even the static ones could be resolved. Wouldn't it hard-wire the objects together? In the next session we want to load some object files from cache while others have changed.. Maybe one day I should check how ccache and the likes han

[Lldb-commits] [PATCH] D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB)

sgraenitz added a comment. Thanks for having a look! The JIT implementations in LLVM operate on relocatable object files, so someone needs to resolve them. MCJIT has a flag `ProcessAllSections` to control which sections will be loaded and relocated. As it is off by default, it will usually ign

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz added a comment. LLDB regression https://bugs.llvm.org/show_bug.cgi?id=36209 fixed with D61611 and D90769 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90789/new/ https:

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz added a comment. Preview for the update: https://weliveindetail.github.io/docs-pub/html/DebuggingJITedCode.html (well I hope styles and scripts will pop up at some point). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90789/new/ https:/

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz created this revision. sgraenitz added reviewers: rnk, eliben. Herald added a project: LLVM. sgraenitz requested review of this revision. Generalize the documentation to include both, GDB and LLDB. Add a link to the interface definition. Make a note on MCJIT's restriction to ELF. Mentio

[Lldb-commits] [PATCH] D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB)

sgraenitz created this revision. sgraenitz added reviewers: labath, clayborg, bkoropoff, loladiro, lhames. Herald added a project: LLDB. sgraenitz requested review of this revision. Herald added a subscriber: JDevlieghere. Part 2 of a fix for JITed code debugging. This has been a regression from 5

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

sgraenitz added a comment. I'd recommend to be careful when making a change of this size. There are a lot of possible configurations. If you split it up into a few smaller and more dedicated commits, you will make your life easier. Otherwise someone might just revert everything if this happens

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz updated this revision to Diff 214139. sgraenitz added a comment. Achieve the same via extra `HINT` to `find_package(Clang ...)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65798/new/ https://reviews.llvm.org/D65798 Files: lldb/cmake/

[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

sgraenitz abandoned this revision. sgraenitz added a comment. In D65939#1620780 , @labath wrote: > So, why doesn't LLVM_ENABLE_WERROR suffice? It looks like that ought to work > even in standalone builds... LLVM_ENABLE_WERROR affects the entire build tr

[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

sgraenitz added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:318 + if(MSVC) +set(flag_werror "/WX") + endif() I copied the flag from LLVM. Is it the right one for MSVC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

sgraenitz created this revision. sgraenitz added reviewers: teemperor, JDevlieghere, davide, labath, stella.stamenova. Herald added a subscriber: mgorny. Herald added a project: LLDB. Treat warnings as errors all over LLDB when enabled. Defaults to `OFF`. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D65874: [lldb][CMake] Disable modules in Xcode projects

sgraenitz created this revision. sgraenitz added reviewers: aprantl, jingham, davide, teemperor. Herald added a subscriber: mgorny. Herald added a project: LLDB. Apparently, module-enabled builds clash with Xcode's analysis. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65874

  1   2   3   4   5   6   >